Herbert Voss wrote:
> I have an image with an unknown format, so LyX returns user.
> If I save all these files as *.user then I am able to define
> a converter so that all these images can be previewed inside
> LyX. which is not possible when '' is returned, if I am not
> wrong here. Defining a co
Georg Baum wrote:
Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes:
I am quite happy with your patch...
Good.
with this fixed.
Of course ;-)
I am applying this now. I'll fix the "users" format later if it is needed
after Herberts explanation (which he hopefully gives).
I have an
Am Dienstag, 9. November 2004 09:19 schrieb Lars Gullik Bjønnes:
> I am quite happy with your patch...
Good.
> with this fixed.
Of course ;-)
I am applying this now. I'll fix the "users" format later if it is needed
after Herberts explanation (which he hopefully gives).
Georg
Georg Baum <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> Georg Baum <[EMAIL PROTECTED]>
>> writes:
>> This is a wrapper...
>
| Yes, it was a misunderstanding, I was thinking you suggested a wrapper
| around the wrapper, and I could not see why we want two wrappers ;-)
>
>> is forma
Lars Gullik Bjønnes wrote:
> Georg Baum <[EMAIL PROTECTED]>
> writes:
> This is a wrapper...
Yes, it was a misunderstanding, I was thinking you suggested a wrapper
around the wrapper, and I could not see why we want two wrappers ;-)
> is formatlist a member of something, or a global var?
It is
Herbert Voss wrote:
> Georg Baum wrote:
>
>> Here comes the patch. I removed the useless "user" format in the process.
>> Now getFormatFromContents() either returns a format name or an empty
>> string if it cannot determine the format. I even found two cases where
>> the return value of getFormat
Georg Baum <[EMAIL PROTECTED]> writes:
| +string Formats::getFormatFromFile(string const & filename) const
| +{
| + if (filename.empty())
| + return string();
| +
| + string const format =
| lyx::support::getFormatFromContents(filename)
This is a wrapper...
is formatlist a
Herbert Voss <[EMAIL PROTECTED]> writes:
| Georg Baum wrote:
>
>> Here comes the patch. I removed the useless "user" format in the process.
>> Now getFormatFromContents() either returns a format name or an empty string
>> if it cannot determine the format. I even found two cases where the return
>
Georg Baum <[EMAIL PROTECTED]> writes:
| Lars Gullik Bjønnes wrote:
>
>> Georg Baum <[EMAIL PROTECTED]>
>> writes:
>> | Would it be ok with you to have something like
>> | Format const *Formats::getFormatFromFile(string filename)
>> | that does what getFormatFromContents() did before your patch?
>
Georg Baum wrote:
Here comes the patch. I removed the useless "user" format in the process.
Now getFormatFromContents() either returns a format name or an empty string
if it cannot determine the format. I even found two cases where the return
value of getFormatFromContents() needed to be checked.
t
Lars Gullik Bjønnes wrote:
> Georg Baum <[EMAIL PROTECTED]>
> writes:
> | Would it be ok with you to have something like
> | Format const *Formats::getFormatFromFile(string filename)
> | that does what getFormatFromContents() did before your patch?
>
> Yes.
>
> One solution will be a wrapper fun
Georg Baum <[EMAIL PROTECTED]> writes:
| Am Sonntag, 7. November 2004 13:52 schrieb Lars Gullik Bjønnes:
>>
>> This hack (dummy Format object to make libsupport link), is not
>> acceptable.
>
| Then it needs to be removed from tex2lyx, too.
>
>> This means that the usage for Format and format.h i
Am Sonntag, 7. November 2004 13:52 schrieb Lars Gullik Bjønnes:
>
> This hack (dummy Format object to make libsupport link), is not
> acceptable.
Then it needs to be removed from tex2lyx, too.
> This means that the usage for Format and format.h in
> support/filetools.C is not acceptable and must
This hack (dummy Format object to make libsupport link), is not
acceptable.
This means that the usage for Format and format.h in
support/filetools.C is not acceptable and must go away.
libsupport should should not include anything from "core". It is a
support library. I am going to apply the pat
14 matches
Mail list logo
