These have mostly been posted before, yes?
Riki
Yes, only the latest three are new. Please review them when you'll have
time. I'm finished with it for now.
Here is the thread in which I've sent previous patches:
https://marc.info/?t=16071855355=1=2
Yuriy
--
lyx-devel mailing list
On 1/15/21 2:10 PM, Yuriy Skalko wrote:
> The branch, InsetParams-refactoring, has been updated.
> discards f7c88f53c728d138a7a4292cb94c7ea9d8b560d4 (commit)
> discards 84563911f714f30b8b794bc2fd938f4f73be6f61 (commit)
> discards 8ea179303d9e1a0dfb40a28b51154c8c2d76
Here is an update to my previous patch. I've separated it into several
patches. The next step will be moving `string2params` into InsetParams.
Please review these patches.
Yuriy
From f8a2c8a143bd54cec1da51b611e0a66c4af3305e Mon Sep 17 00:00:00 2001
From: Yuriy Skalko
Date: Sun, 6 Dec 2020
diff --git a/src/frontends/qt/GuiGraphics.cpp
b/src/frontends/qt/GuiGraphics.cpp
index 7b1e348251..acfc7f609a 100644
--- a/src/frontends/qt/GuiGraphics.cpp
+++ b/src/frontends/qt/GuiGraphics.cpp
@@ -110,7 +110,8 @@ static void setAutoTextCB(QCheckBox * checkBox,
QLineEdit * lineEdit,
On 12/5/20 11:23 AM, Yuriy Skalko wrote:
> I'm trying to refactor implementation of Inset[...]Params
> (InsetBoxParams, InsetPhantomParams etc). The steps are:
>
> 1. Unify Inset[...]Params interfaces and extract InsetParams
> superclass.
> 2. Move `params2string` and `string2params` static
On 12/5/20 11:23 AM, Yuriy Skalko wrote:
> I'm trying to refactor implementation of Inset[...]Params
> (InsetBoxParams, InsetPhantomParams etc). The steps are:
>
> 1. Unify Inset[...]Params interfaces and extract InsetParams
> superclass.
> 2. Move `params2string` and `string2params` static
I'm trying to refactor implementation of Inset[...]Params
(InsetBoxParams, InsetPhantomParams etc). The steps are:
1. Unify Inset[...]Params interfaces and extract InsetParams
superclass.
2. Move `params2string` and `string2params` static methods of Insets to
methods of Inset[...]Params.
3.
