Hi Guillaume,
I thought about it again, and you are right, of course.
JMarc
Le 24 février 2017 22:10:17 GMT+01:00, Guillaume Munch a écrit :
>Le 22/02/2017 à 18:03, Jean-Marc Lasgouttes a écrit :
>> It would be nice to hide these subtleties in the Cache
>implementation,
>> if possible.
>>
>I a
Le 22/02/2017 à 18:03, Jean-Marc Lasgouttes a écrit :
Le 21/02/2017 à 20:13, Guillaume Munch a écrit :
BTW, why don't you use Cache::contains in getLayout like you do for
other cache uses?
This is explained in the documentation of Cache::object. It is enough to
check for a null pointer in th
Le 23/02/2017 à 18:05, Richard Heck a écrit :
Here is for reference the updated patch (even with comment
clarification). Richard?
OK. I'll test it over the next couple weeks, and if all is well move
toward 2.2.3.
rh
Done at 998c3e7c8ef. There is no status.22x entry, since this is a fix
over
On 02/23/2017 04:46 AM, Jean-Marc Lasgouttes wrote:
> Le 22/02/2017 à 18:03, Jean-Marc Lasgouttes a écrit :
>> Indeed. Richard, I think this patch should go in 2.2.3, because the
>> caching code that is in stable causes bad memory leaks with Qt5.
>
> Here is for reference the updated patch (even wi
On 02/23/2017 04:46 AM, Jean-Marc Lasgouttes wrote:
> Le 22/02/2017 à 18:03, Jean-Marc Lasgouttes a écrit :
>> Indeed. Richard, I think this patch should go in 2.2.3, because the
>> caching code that is in stable causes bad memory leaks with Qt5.
>
> Here is for reference the updated patch (even wi
Le 22/02/2017 à 18:03, Jean-Marc Lasgouttes a écrit :
Indeed. Richard, I think this patch should go in 2.2.3, because the
caching code that is in stable causes bad memory leaks with Qt5.
Here is for reference the updated patch (even with comment
clarification). Richard?
JMarc
From 8e04248b
Le 21/02/2017 à 20:13, Guillaume Munch a écrit :
Thanks for doing this. I thought there was some bigger adaptation to the
code to do but indeed it only looks like a matter of C++98 conversion.
You mean it was a trap? It did not work %-p
I think it's all good except:
class Cache : private QCa
Le 21/02/2017 à 07:19, Jean-Marc Lasgouttes a écrit :
Le 21/02/2017 à 00:08, Guillaume Munch a écrit :
Could you do the backport to stable? :)
What about that? Please check especially the code related to
LYX_USE_CXX11 in Cache.h. For the caching, I re-read the code to make
sure that my hand-m
Le 20/02/2017 à 18:25, Jean-Marc Lasgouttes a écrit :
Le 10/02/2017 à 17:58, Guillaume Munch a écrit :
There's more data, but I am not sure how to interpret the results that
massif-visualizer shows.
If you send the file or make it available, I can take a look.
Here it is. But if it is like c
Le 21/02/2017 à 00:08, Guillaume Munch a écrit :
Could you do the backport to stable? :)
What about that? Please check especially the code related to
LYX_USE_CXX11 in Cache.h. For the caching, I re-read the code to make
sure that my hand-merging was correct, I hope I did not miss anything.
Le 21/02/2017 à 00:08, Guillaume Munch a écrit :
Le 20/02/2017 à 18:27, Jean-Marc Lasgouttes a écrit :
Le 13/02/2017 à 20:55, Jean-Marc Lasgouttes a écrit :
What I mean is that you can easily force
QCache into shared ownership by replacing
QCache
with
QCache>
and create the appropri
Le 20/02/2017 à 18:27, Jean-Marc Lasgouttes a écrit :
Le 13/02/2017 à 20:55, Jean-Marc Lasgouttes a écrit :
What I mean is that you can easily force
QCache into shared ownership by replacing
QCache
with
QCache>
and create the appropriate wrappers for insertion and retrieval.
Could
Le 13/02/2017 à 20:55, Jean-Marc Lasgouttes a écrit :
What I mean is that you can easily force
QCache into shared ownership by replacing
QCache
with
QCache>
and create the appropriate wrappers for insertion and retrieval.
Could you have a go at this solution?
JMarc
Le 10/02/2017 à 17:58, Guillaume Munch a écrit :
There's more data, but I am not sure how to interpret the results that
massif-visualizer shows.
If you send the file or make it available, I can take a look.
Here it is. But if it is like callgrind, it might lack the symbols.
Interestingly, t
14 matches
Mail list logo