Re: New Patches

2020-11-20 Thread Jean-Marc Lasgouttes
Le 20/11/2020 à 23:16, Yuriy Skalko a écrit : And here are next 3 patches. Yuriy Look good to me. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel

New Patches

2020-11-20 Thread Yuriy Skalko
And here are next 3 patches. Yuriy From 83a9828c25ab2501bbaadcfe86040b076905d3c5 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 19 Nov 2020 14:51:00 +0200 Subject: [PATCH 1/4] Remove unused header --- src/mathed/InsetMathSymbol.cpp | 1 - src/mathed/MathSupport.cpp | 1 - 2 files c

Re: New Patches

2020-11-20 Thread Richard Kimberly Heck
On 11/19/20 2:03 PM, José Abílio Matos wrote: On Thursday, November 19, 2020 2:23:14 PM WET Jean-Marc Lasgouttes wrote: > I have to say that lambdas are not my cup of tea, but the original code > is not great either. With variable capture lambdas can sometimes be subtle, but in this case th

Re: New Patches

2020-11-19 Thread José Abílio Matos
On Thursday, November 19, 2020 2:23:14 PM WET Jean-Marc Lasgouttes wrote: > I have to say that lambdas are not my cup of tea, but the original code > is not great either. With variable capture lambdas can sometimes be subtle, but in this case that is not an issue and the code is a lot more readab

Re: New Patches

2020-11-19 Thread Jean-Marc Lasgouttes
Le 19/11/2020 à 14:54, Pavel Sanda a écrit : On Thu, Nov 19, 2020 at 02:09:08PM +0200, Yuriy Skalko wrote: New patches for LyX. Patch 1 looks good to go, I am not sure about the sencond, i.e. to what extent we want to use lambdas. IIRC some people complained about readability (OTOH constructs

Re: New Patches

2020-11-19 Thread Pavel Sanda
On Thu, Nov 19, 2020 at 02:09:08PM +0200, Yuriy Skalko wrote: > New patches for LyX. Patch 1 looks good to go, I am not sure about the sencond, i.e. to what extent we want to use lambdas. IIRC some people complained about readability (OTOH constructs like firster are not that nice either). Any

New Patches

2020-11-19 Thread Yuriy Skalko
New patches for LyX. Yuriy From c083a56f9ddb2e4d5d2cc4bb0586fbb83ae598e9 Mon Sep 17 00:00:00 2001 From: Yuriy Skalko Date: Thu, 19 Nov 2020 13:24:04 +0200 Subject: [PATCH 1/2] Simplify constructors --- src/Dimension.h| 28 +++- src/graphics