Patch: Drawing a box at the end of proofs

2000-02-18 Thread Dekel Tsur
I'm a little surprised that LyX doesn't draw an end-of-proof symbol at the end of proofs, so I've written a patch that does this. It is possible to select either a filled box or an outline box, using the EndLabelType keyword in the layout file. There are some things that can be improved: 1. Chang

Re: Patch: Drawing a box at the end of proofs

2000-02-25 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | I'm a little surprised that LyX doesn't draw an end-of-proof symbol at the | end of proofs, so I've written a patch that does this. | It is possible to select either a filled box or an outline box, using | the EndLabelType keyword in the layout file. I fi

Re: Patch: Drawing a box at the end of proofs

2000-02-25 Thread Dekel Tsur
On Fri, Feb 25, 2000 at 08:28:11PM +0100, Lars Gullik Bj&resh;nnes wrote: > Dekel Tsur <[EMAIL PROTECTED]> writes: > > | I'm a little surprised that LyX doesn't draw an end-of-proof symbol at the > | end of proofs, so I've written a patch that does this. > > I finally got time to respond to this

Re: Patch: Drawing a box at the end of proofs

2000-02-25 Thread Dekel Tsur
> | PS: The code in layout.C is horrible (all those cases). > > _why_ is it horrible. It used to be more horrible just a _huge_ > switch. After the change the different layout contructs get parsed > separately and we get and warning/error reported if you have used the > layout format wrong. (it i

Re: Patch: Drawing a box at the end of proofs

2000-02-28 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | > | PS: The code in layout.C is horrible (all those cases). | > | > _why_ is it horrible. It used to be more horrible just a _huge_ | > switch. After the change the different layout contructs get parsed | > separately and we get and warning/error reported

Re: Patch: Drawing a box at the end of proofs

2000-02-28 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | On Fri, Feb 25, 2000 at 08:28:11PM +0100, Lars Gullik Bjønnes wrote: | > Dekel Tsur <[EMAIL PROTECTED]> writes: | > | > | I'm a little surprised that LyX doesn't draw an end-of-proof symbol at the | > | end of proofs, so I've written a patch that does thi

Re: Patch: Drawing a box at the end of proofs

2000-02-28 Thread Dekel Tsur
On Mon, Feb 28, 2000 at 09:20:11AM +0100, Lars Gullik Bj&resh;nnes wrote: > | Consider the code of LyXLayout::readLabelType. > | It uses a LyXLex::lex() for converting the current token (defining the label > | type) to a number (of type LabelTypeTags), and then it does a big switch > | for conver