Re: (Patch] fix 4317 Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: It's the same and it works fine in branch. Shall I commit? Yes, please. Since the worst that could happen would be an update too much, it cannot harm anyway. Done. Abdel.

Re: (Patch] fix 4317 Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > It's the same and it works fine in branch. Shall I commit? Yes, please. Since the worst that could happen would be an update too much, it cannot harm anyway. Jürgen

Re: (Patch] fix 4317 Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Hum, following the wide()-removal, the situation has changed WRT bug 3992 so I committed the following to trunk instead. I guess the same fix also applies to branch. A patch is, of course, welcome. It's the same and it works fine in branch.

Re: (Patch] fix 4317 Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Hum, following the wide()-removal, the situation has changed WRT bug > 3992 so I committed the following to trunk instead. I guess the same fix > also applies to branch. A patch is, of course, welcome. Jürgen

Re: (Patch] fix 4317 Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Martin Vermeer wrote: On Mon, 05 Nov 2007 11:15:23 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Could you post a status update please? Here are the bugs that must be fixed for 1.5.3, IMHO: 4301 cri crash

Re: (Patch] fix 4317 Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Martin Vermeer
On Mon, 05 Nov 2007 12:43:51 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Martin Vermeer wrote: > > On Mon, 05 Nov 2007 11:15:23 +0100 > > Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > > > >> Jürgen Spitzmüller wrote: > >>> Abdelrazak Younes wrote: > Could you post a status update p

Re: (Patch] fix 4317 Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Abdelrazak Younes
Martin Vermeer wrote: On Mon, 05 Nov 2007 11:15:23 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Could you post a status update please? Here are the bugs that must be fixed for 1.5.3, IMHO: 4301 cri crash on bookmark in ERT This c

(Patch] fix 4317 Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Martin Vermeer
On Mon, 05 Nov 2007 11:15:23 +0100 Abdelrazak Younes <[EMAIL PROTECTED]> wrote: > Jürgen Spitzmüller wrote: > > Abdelrazak Younes wrote: > >> Could you post a status update please? > > > > Here are the bugs that must be fixed for 1.5.3, IMHO: > > > > 4301 cri crash on bookmark in ERT > > T

Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > This crashes only when assertion are disabled. To all package producers, > in particular for Windows (Uwe, Bo, Joost!) please, make sure assertion > are disabled in the production packages. Andre', before you comment, I > am talking about 1.5.x. I couldn't agree more. Fu

Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Could you post a status update please? Here are the bugs that must be fixed for 1.5.3, IMHO: 4301 cri crash on bookmark in ERT This crashes only when assertion are disabled. To all package producers, in particular for Windows (Uwe, Bo

Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Could you post a status update please? Here are the bugs that must be fixed for 1.5.3, IMHO: 4301 cri crash on bookmark in ERT => patch by Bernhard available. 4317 cri Cursor placement crash => no fix available yet. 4323 cri Crash on adding/removing ro

Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Done!!! Thanks (and congratulations). Thanks, this was a lot of work! I've also fixed last drawing issue reported by Bennett. 1.5.3 will be the fastest, smoothest release ever! Time to freeze and release I say... Almost. We still have

Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Done!!! Thanks (and congratulations). > I've also fixed last drawing issue reported by Bennett. 1.5.3 will be > the fastest, smoothest release ever! > > Time to freeze and release I say... Almost. We still have some crashes pending. After those are fixed, I plan to re

Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-05 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Juergen? OK. Done!!! I've also fixed last drawing issue reported by Bennett. 1.5.3 will be the fastest, smoothest release ever! Time to freeze and release I say... Abdel.

Re: Wide patch? (was Re: Patch Candidate List #6)

2007-11-02 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Juergen? OK. Jürgen

Wide patch? (was Re: Patch Candidate List #6)

2007-11-02 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Bennett Helm wrote: On Oct 24, 2007, at 11:45 AM, Abdelrazak Younes wrote: Bennett Helm wrote: On Oct 24, 2007, at 2:16 AM, Abdelrazak Younes wrote: I'm not sure what to be testing here. Is the patch already applied in changeset 20728? (If not, what is the patch?) In

Re: Patch Candidate List #6

2007-10-27 Thread Anders Ekberg
Solution (in case you need help): go to the po directory, and do: rm ca.* svn up Then try recompiling. Bennett Thanks it worked ( as did reverting the patch -- I don't think I ever understand the black wodoo by which those files get corrupted...) Anyway the result is that I don't see any

Re: Patch Candidate List #6

2007-10-26 Thread Bennett Helm
On Oct 26, 2007, at 1:53 PM, Pavel Sanda wrote: I get an error in the compilation: ca.po: warning: Charset missing in header. Message conversion to user's charset will not work. ca.po:21:2: parse error ca.po:21: keyword "mine" unknown ca.po:22: keyword "mine" unknown ca.po:23: k

Re: Patch Candidate List #6

2007-10-26 Thread Pavel Sanda
> I get an error in the compilation: > > ca.po: warning: Charset missing in header. > Message conversion to user's charset will not work. > ca.po:21:2: parse error > ca.po:21: keyword "mine" unknown > ca.po:22: keyword "mine" unknown > ca.po:23: keyword "mine" unknown > ca.po:24: ke

Re: Patch Candidate List #6

2007-10-26 Thread Anders Ekberg
Bennett Helm Wed, 24 Oct 2007 11:00:00 -0700 On Oct 24, 2007, at 11:45 AM, Abdelrazak Younes wrote: Bennett Helm wrote: On Oct 24, 2007, at 2:16 AM, Abdelrazak Younes wrote: I'm not sure what to be testing here. Is the patch already applied in changeset 20728? (If not, what is the patch?) I

Re: Patch Candidate List #6

2007-10-24 Thread Abdelrazak Younes
Bennett Helm wrote: On Oct 24, 2007, at 11:45 AM, Abdelrazak Younes wrote: Bennett Helm wrote: On Oct 24, 2007, at 2:16 AM, Abdelrazak Younes wrote: I'm not sure what to be testing here. Is the patch already applied in changeset 20728? (If not, what is the patch?) In any case, what should I

Re: Patch Candidate List #6

2007-10-24 Thread Bennett Helm
On Oct 24, 2007, at 11:45 AM, Abdelrazak Younes wrote: Bennett Helm wrote: On Oct 24, 2007, at 2:16 AM, Abdelrazak Younes wrote: I'm not sure what to be testing here. Is the patch already applied in changeset 20728? (If not, what is the patch?) In any case, what should I be testing? The a

Re: Patch Candidate List #6

2007-10-24 Thread Juergen Spitzmueller
Enrico Forestieri wrote: > Then I am going to commit it and reflect the changes in trunk, too. Good. Jürgen

Re: Patch Candidate List #6

2007-10-24 Thread Abdelrazak Younes
Bennett Helm wrote: On Oct 24, 2007, at 2:16 AM, Abdelrazak Younes wrote: I'm not sure what to be testing here. Is the patch already applied in changeset 20728? (If not, what is the patch?) In any case, what should I be testing? The attached patch. Sorry, I meant: what functionality should

Re: Patch Candidate List #6

2007-10-24 Thread Enrico Forestieri
On Wed, Oct 24, 2007 at 10:53:56AM +0200, Juergen Spitzmueller wrote: > Enrico Forestieri wrote: > > > Here is a revised patch. I've done some renaming and now don't even > > call anymore the relevant method when a character can be translated > > using the current encoding. > > This looks good (m

Re: Patch Candidate List #6

2007-10-24 Thread Enrico Forestieri
On Wed, Oct 24, 2007 at 10:27:59AM +0200, Jean-Marc Lasgouttes wrote: > Enrico Forestieri <[EMAIL PROTECTED]> writes: > > > Here is a revised patch. I've done some renaming and now don't even > > call anymore the relevant method when a character can be translated > > using the current encoding. >

Re: Patch Candidate List #6

2007-10-24 Thread Bennett Helm
On Oct 24, 2007, at 2:16 AM, Abdelrazak Younes wrote: I'm not sure what to be testing here. Is the patch already applied in changeset 20728? (If not, what is the patch?) In any case, what should I be testing? The attached patch. Sorry, I meant: what functionality should I be testing? By

Re: Patch Candidate List #6

2007-10-24 Thread Juergen Spitzmueller
Enrico Forestieri wrote: > Here is a revised patch. I've done some renaming and now don't even > call anymore the relevant method when a character can be translated > using the current encoding. This looks good (much more intuitive than the first version, IMHO). Jürgen

Re: Patch Candidate List #6

2007-10-24 Thread Jean-Marc Lasgouttes
Enrico Forestieri <[EMAIL PROTECTED]> writes: > Here is a revised patch. I've done some renaming and now don't even > call anymore the relevant method when a character can be translated > using the current encoding. > +int Paragraph::Pimpl::writeScriptChars(odocstream & os, Looks like the variab

Re: Patch Candidate List #6

2007-10-23 Thread Abdelrazak Younes
Bennett Helm wrote: On Oct 22, 2007, at 3:57 AM, Jürgen Spitzmüller wrote: The patch from Abdel (including wide() removal) needs testing. I am sure it will get any if it is not committed quite frankly... I really would appreciate some testing, since this is a sensitive area (remember the d

Re: Patch Candidate List #6

2007-10-23 Thread Bennett Helm
On Oct 22, 2007, at 3:57 AM, Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: ? http://www.lyx.org/trac/changeset/20523 - Crash fix for in mathed cursor. Don't think so (Abdel?) Not sure. The patch fix the crash but also enable paragraph settings when the cursor is within mathed. If we wa

Re: Patch Candidate List #6

2007-10-23 Thread Enrico Forestieri
On Tue, Oct 23, 2007 at 05:24:52PM +0200, Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > > If so, do you really have to enter this loop in knownLangChars in any > > > case? Can't you return earlier if a proper language is set? I guess you > > > only need to do the check for "if (prefixIs(

Re: Patch Candidate List #6

2007-10-23 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > No. Replace "we are simply passed a code point" by something that makes > > sense. > > Please, search for "we are passed" at the URLs below, then tell me > what doesn't make sense. Aha, so that's passive voice (in the sense of "we received a code point")?! This was ob

Re: Patch Candidate List #6

2007-10-23 Thread Enrico Forestieri
On Tue, Oct 23, 2007 at 05:24:52PM +0200, Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > > > +       // When the proper language is set, we are simply passed > > > > a code +       // point, so we should not try to close the > > > > \textLANG command. > > > > > > grammar fi

Re: Patch Candidate List #6

2007-10-23 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > If so, do you really have to enter this loop in knownLangChars in any > > case? Can't you return earlier if a proper language is set? I guess you > > only need to do the check for "if (prefixIs(latex1, from_ascii("\\" + > > preamble)))" before the loop, no? > > Yes, but

Re: Patch Candidate List #6

2007-10-23 Thread Enrico Forestieri
On Tue, Oct 23, 2007 at 08:04:49AM +0200, Jürgen Spitzmüller wrote: > A few questions and comments. > > Generally: do I get it right that knownLangChars knows that the proper lang > is > set from the return value of latexChar? I.e., if the language is set to > greek, econding.latexChar returns

Re: Patch Candidate List #6

2007-10-22 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > Here it is. May I apply it? A few questions and comments. Generally: do I get it right that knownLangChars knows that the proper lang is set from the return value of latexChar? I.e., if the language is set to greek, econding.latexChar returns 'α', while it returns '\\

Re: Patch Candidate List #6

2007-10-22 Thread Martin Vermeer
On Mon, Oct 22, 2007 at 11:26:20AM +0200, Jürgen Spitzmüller wrote: > Martin Vermeer wrote: > > > > http://www.lyx.org/trac/changeset/20915 - Sanitize behaviour of line > > > > break in simple math inset > > > > > > Martin? > > > > I think yes. > > > > ... > >   > > > > > > http://www.lyx.org/trac/

Re: Patch Candidate List #6

2007-10-22 Thread Enrico Forestieri
On Mon, Oct 22, 2007 at 08:48:30AM +0200, Jürgen Spitzmüller wrote: > Enrico Forestieri wrote: > > > http://www.lyx.org/trac/changeset/20931 - Add support for greek and > > > cyrillic chars such that it is not necessary to mark them in the proper > > > language for typesetting. > > > http://www.lyx

Re: Patch Candidate List #6

2007-10-22 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes: > Martin Vermeer wrote: >> > > http://www.lyx.org/trac/changeset/20915 - Sanitize behaviour of line >> > > break in simple math inset >> > >> > Martin? > > Both look simple. So if you test it carefully, you can commit. Something that would be nice to

Re: Patch Candidate List #6

2007-10-22 Thread Jean-Marc Lasgouttes
[EMAIL PROTECTED] (Jürgen Spitzmüller) writes: >> I am sure it will get any if it is not committed quite frankly... > > I really would appreciate some testing, since this is a sensitive area > (remember the drawing errors we fixed last-minute before 1.5.2 was > released?). Yes. It is not accept

Re: Patch Candidate List #6

2007-10-22 Thread Jürgen Spitzmüller
Martin Vermeer wrote: > > > http://www.lyx.org/trac/changeset/20915 - Sanitize behaviour of line > > > break in simple math inset > > > > Martin? > > I think yes. > > ... >   > > > > http://www.lyx.org/trac/changeset/20947 - Off-by-one error addCol() > > > > Martin? > > I think so yes. Both look s

Re: Patch Candidate List #6

2007-10-22 Thread Martin Vermeer
On Mon, 22 Oct 2007 09:15:25 +0200 [EMAIL PROTECTED] (Jürgen Spitzmüller) wrote: > Michael Gerz wrote: > > New > > --- ... > > http://www.lyx.org/trac/changeset/20687 - Fix empty blue box painting in > > mathed. > > dunno. Not a bug in 1.5 ... > > http://www.lyx.org/trac/changeset/20869 -

Re: Patch Candidate List #6

2007-10-22 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: http://www.lyx.org/trac/changeset/20728 - the singlepar optimization (r20567) The patch from Abdel (including wide() removal) needs testing. I am sure it will get any if it is not committed quite frankly... I really would appreciate some test

Re: Patch Candidate List #6

2007-10-22 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > > is the crash reproducable in 1.5.2? > > No. OK, then let's leave it for now. > http://www.lyx.org/trac/changeset/20728 - the singlepar optimization > (r20567) > >>> > >>> The patch from Abdel (including wide() removal) needs testing. > >> > >> I am sure it w

Re: Patch Candidate List #6

2007-10-22 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: ? http://www.lyx.org/trac/changeset/20523 - Crash fix for in mathed cursor. Don't think so (Abdel?) Not sure. The patch fix the crash but also enable paragraph settings when the cursor is within mathed. If we want to support that in 1.5, than

Re: Patch Candidate List #6

2007-10-22 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > >> ? http://www.lyx.org/trac/changeset/20523 - Crash fix for in mathed > >> cursor. > > > > Don't think so (Abdel?) > > Not sure. The patch fix the crash but also enable paragraph settings > when the cursor is within mathed. If we want to support that in 1.5, > than yes.

Re: Patch Candidate List #6

2007-10-22 Thread Abdelrazak Younes
Abdelrazak Younes wrote: http://www.lyx.org/trac/changeset/20728 - the singlepar optimization (r20567) The patch from Abdel (including wide() removal) needs testing. I am sure it will get any if it is not committed quite frankly... I am _not_ sure...

Re: Patch Candidate List #6

2007-10-22 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Michael Gerz wrote: New --- ? http://www.lyx.org/trac/changeset/20523 - Crash fix for in mathed cursor. Don't think so (Abdel?) Not sure. The patch fix the crash but also enable paragraph settings when the cursor is within mathed. If we want to support that in 1.5,

Re: Patch Candidate List #6

2007-10-22 Thread Jürgen Spitzmüller
Michael Gerz wrote: > New > --- > ? http://www.lyx.org/trac/changeset/20523 - Crash fix for in mathed cursor. Don't think so (Abdel?) > ? http://www.lyx.org/trac/changeset/20547 - GuiBox: fix bug 3242 > http://bugzilla.lyx.org/show_bug.cgi?id=3242: make minipage optional > height argument optiona

Re: Patch Candidate List #6

2007-10-21 Thread Jürgen Spitzmüller
Enrico Forestieri wrote: > > http://www.lyx.org/trac/changeset/20931 - Add support for greek and > > cyrillic chars such that it is not necessary to mark them in the proper > > language for typesetting. > > http://www.lyx.org/trac/changeset/20932 - Correct ordering > > http://www.lyx.org/trac/chang

Re: Patch Candidate List #6

2007-10-21 Thread Enrico Forestieri
On Sun, Oct 21, 2007 at 07:52:07PM +0200, Michael Gerz wrote: > http://www.lyx.org/trac/changeset/20725 - Fix (again) bug 3510 after r20508 Not applicable. > http://www.lyx.org/trac/changeset/20931 - Add support for greek and > cyrillic chars such that it is not necessary to mark them in the pr

Patch Candidate List #6

2007-10-21 Thread Michael Gerz
Hi, here comes a new 1.5.X patch candidate list. It is rather large but I guess that most entries are complete useless. Best regards, Michael /// Patch Candidate List #6 Approved by Jürgen -- http://www.lyx.org/trac/changeset/20419 - GuiApplication