Re: Patch for "read-only thesaurus" [Was: Re: ANNOUNCE: LyX version 2.0.0 (beta 3)]

2011-01-13 Thread Pavel Sanda
Stephan Witt wrote: > What I do not understand: > why depends the call of GuiDialog::updateView() on the result of canApply()? these two commits may reveal something r22049 (younes, 'Factorize general code out of GuiDialog...') r29217 (vfr, 'Enable dialogs that can apply for read-only documents.'

Re: Patch for "read-only thesaurus" [Was: Re: ANNOUNCE: LyX version 2.0.0 (beta 3)]

2011-01-12 Thread Stephan Witt
Am 12.01.2011 um 23:15 schrieb Pavel Sanda: > Stephan Witt wrote: >> Am 12.01.2011 um 20:21 schrieb Pavel Sanda: >> >>> Stephan Witt wrote: I tried to verify this... it seems the flow of control is too tricky. The thesaurus dialog "cannot apply" (Dialog::canApply() return false). T

Re: Patch for "read-only thesaurus" [Was: Re: ANNOUNCE: LyX version 2.0.0 (beta 3)]

2011-01-12 Thread Pavel Sanda
Stephan Witt wrote: > Am 12.01.2011 um 20:21 schrieb Pavel Sanda: > > > Stephan Witt wrote: > >> I tried to verify this... it seems the flow of control is too tricky. > >> The thesaurus dialog "cannot apply" (Dialog::canApply() return false). > >> Therefore when buffer is readonly the Dialog::chec

Re: Patch for "read-only thesaurus" [Was: Re: ANNOUNCE: LyX version 2.0.0 (beta 3)]

2011-01-12 Thread Stephan Witt
Am 12.01.2011 um 20:21 schrieb Pavel Sanda: > Stephan Witt wrote: >> I tried to verify this... it seems the flow of control is too tricky. >> The thesaurus dialog "cannot apply" (Dialog::canApply() return false). >> Therefore when buffer is readonly the Dialog::checkStatus() method >> doesn't call

Re: Patch for "read-only thesaurus" [Was: Re: ANNOUNCE: LyX version 2.0.0 (beta 3)]

2011-01-12 Thread Pavel Sanda
Stephan Witt wrote: > I tried to verify this... it seems the flow of control is too tricky. > The thesaurus dialog "cannot apply" (Dialog::canApply() return false). > Therefore when buffer is readonly the Dialog::checkStatus() method > doesn't call GuiDialog::updateView() and the current selection

Patch for "read-only thesaurus" [Was: Re: ANNOUNCE: LyX version 2.0.0 (beta 3)]

2011-01-12 Thread Stephan Witt
Am 12.01.2011 um 15:57 schrieb Stephan Witt: > Am 12.01.2011 um 13:14 schrieb Vincent van Ravesteijn: > >>> >>> The real problem is: why shouldn't I be able to look up >>> something with thesaurus when viewing an read-only lyx file. >> >> >> What is _exactly_ the problem then ? >> >> (I can't