Re: Question on undo: Remove a finishUndo() after a recordUndo() ?

2020-02-02 Thread Scott Kostyshak
On Sat, Feb 01, 2020 at 08:41:12PM +0100, Jean-Marc Lasgouttes wrote: > Le 01/02/2020 à 18:39, Scott Kostyshak a écrit : > > What would the consequences be of the attached patch? > > > > From what I understand, finishUndo() is meant for when there have been > > som undos of type INSERT or DELETE

Re: Question on undo: Remove a finishUndo() after a recordUndo() ?

2020-02-01 Thread Jean-Marc Lasgouttes
Le 01/02/2020 à 18:39, Scott Kostyshak a écrit : What would the consequences be of the attached patch? From what I understand, finishUndo() is meant for when there have been som undos of type INSERT or DELETE recorded, but PARAGRAPH_MOVE_DOWN itself does not record any INSERTs or DELETEs. What

Question on undo: Remove a finishUndo() after a recordUndo() ?

2020-02-01 Thread Scott Kostyshak
What would the consequences be of the attached patch? From what I understand, finishUndo() is meant for when there have been som undos of type INSERT or DELETE recorded, but PARAGRAPH_MOVE_DOWN itself does not record any INSERTs or DELETEs. What would happen if the finishUndo() is removed? Is