Re: Patch: bug fix

2001-01-08 Thread Dekel Tsur
On Mon, Jan 08, 2001 at 01:42:57PM +0100, Juergen Vigna wrote: > > If there are more than one paragraphs then the column must be a fixed width > > column, in which case the test GetPWidth(cell).empty() fails, so LyX doesn't > > write the \R{}. However, the \selectlanguage{} commands between the >

Re: Patch: bug fix

2001-01-08 Thread Juergen Vigna
On 08-Jan-2001 Dekel Tsur wrote: > > If there are more than one paragraphs then the column must be a fixed width > column, in which case the test GetPWidth(cell).empty() fails, so LyX doesn't > write the \R{}. However, the \selectlanguage{} commands between the > paragraph will cause the correct

Re: Patch: bug fix

2001-01-08 Thread Dekel Tsur
On Mon, Jan 08, 2001 at 12:24:35PM +0100, Juergen Vigna wrote: > > On 08-Jan-2001 Dekel Tsur wrote: > > >> Last() returns a pointer so it really should be .. && inset->par->Last() && > >> shouldn't it? > > > > No, Last() returns LyXParagraph::size_type (= unsigned int). > > > > Sure dump from

Re: Patch: bug fix

2001-01-08 Thread Juergen Vigna
On 08-Jan-2001 Dekel Tsur wrote: >> Last() returns a pointer so it really should be .. && inset->par->Last() && >> shouldn't it? > > No, Last() returns LyXParagraph::size_type (= unsigned int). > Sure dump from me :(, but what if the inset has more then one paragraph and one is RTL and the ot

Re: Patch: bug fix

2001-01-08 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | No, Last() returns LyXParagraph::size_type (= unsigned int). signed int I hope... will be a unsigned int later, but not yet. Lgb

Re: Patch: bug fix

2001-01-08 Thread Dekel Tsur
On Mon, Jan 08, 2001 at 11:04:16AM +0100, Juergen Vigna wrote: > 1. > > @@ -2195,7 +2195,16 @@ int LyXTabular::Latex(Buffer const * buf > + bool rtl = inset->par->isRightToLeftPar(buf->params) && > +

RE: Patch: bug fix

2001-01-08 Thread Juergen Vigna
On 07-Jan-2001 Dekel Tsur wrote: > The following patch fixes several bugs with insettabular/insettext (mostly RTL > stuff). I've also made one change which isn't exactly a bug fix: The changes seems sound I just have some questions to the patch: 1. ++

Re: Patch (bug fix)

2000-05-05 Thread Juergen Vigna
On 05-May-2000 Jean-Marc Lasgouttes wrote: >> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes: > > Dekel> The place with a conflict was in the insettext. Since it isn't > Dekel> being used currently, I just removed the new code from there. > Dekel> The following patch also fixes the "americ

Re: Patch (bug fix)

2000-05-05 Thread Jean-Marc Lasgouttes
> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes: Dekel> The place with a conflict was in the insettext. Since it isn't Dekel> being used currently, I just removed the new code from there. Dekel> The following patch also fixes the "american" language problem. Thanks. JMarc

Re: Patch (bug fix)

2000-05-04 Thread Dekel Tsur
On Thu, May 04, 2000 at 02:56:39PM +0200, Jean-Marc Lasgouttes wrote: > > Could re-re-redo your patch? (I know it's a pain...) The place with a conflict was in the insettext. Since it isn't being used currently, I just removed the new code from there. The following patch also fixes the "american

Re: Patch (bug fix)

2000-05-04 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Lars> > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> Lars> So that means that if the command is robust we don't need Lars> a | Lars> \protect even if

Re: Patch (bug fix)

2000-05-04 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> So that means that if the command is robust we don't need a | Lars> \protect even if it is in a moving argument? | | That's it. Why protect something which is robust, aft

Re: Patch (bug fix)

2000-05-04 Thread Jean-Marc Lasgouttes
> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes: Dekel> I used style.isCommand() because it was used in Dekel> SimpleTeXSpecialChars() (in other words, LyX currently put Dekel> \protect in the argument of any command). As you suggested, it Dekel> should be style.needprotect, so I've change

Re: Patch (bug fix)

2000-05-04 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> So that means that if the command is robust we don't need a Lars> \protect even if it is in a moving argument? That's it. Why protect something which is robust, after all? JMarc

Re: Patch (bug fix)

2000-05-04 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | > "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: | | Lars> Dekel Tsur <[EMAIL PROTECTED]> writes: | As you suggested, it | Lars> should be style.needprotect, so I've changed it, | and also | Lars> renamed the 'fragile' variable to

Re: Patch (bug fix)

2000-05-04 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Dekel Tsur <[EMAIL PROTECTED]> writes: | As you suggested, it Lars> should be style.needprotect, so I've changed it, | and also Lars> renamed the 'fragile' variable to 'need_protect'. Lars> Not sure about this one. Oh, I agree

Re: Patch (bug fix)

2000-04-28 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | As you suggested, it should be style.needprotect, so I've changed it, | and also renamed the 'fragile' variable to 'need_protect'. Not sure about this one. Oh, I agree that the name should change. 'need_protect' seems to demand a '\protect' and I don't t

Re: Patch (bug fix)

2000-04-28 Thread Dekel Tsur
On Fri, Apr 28, 2000 at 04:59:44PM +0200, Jean-Marc Lasgouttes wrote: > > "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes: > > Dekel> The following patch allows using the URL inset inside the > Dekel> \thanks{} command (it adds \protect to the LaTeX file). > > Dekel, I still do not understa

Re: Patch (bug fix)

2000-04-28 Thread Jean-Marc Lasgouttes
> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes: Dekel> The following patch allows using the URL inset inside the Dekel> \thanks{} command (it adds \protect to the LaTeX file). Dekel, I still do not understand the statement fragile |= style.isCommand(); in your patch. As I see it, it will

Re: Patch (bug fix)

2000-04-26 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Lars> Lars> run_arg running_argument | | Lars> or something similar. | Lars> | 'Running argument' is something else. I guess you mean 'moving Lars> | argument'. Lars> Probaly.

Re: Patch (bug fix)

2000-04-26 Thread Lars Gullik Bjønnes
Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: | Lars> run_arg running_argument | | Lars> or something similar. | | 'Running argument' is something else. I guess you mean 'moving | argument'. Probaly. Care to explain the difference? Lgb

Re: Patch (bug fix)

2000-04-26 Thread Jean-Marc Lasgouttes
> "Lars" == Lars Gullik Bjønnes <[EMAIL PROTECTED]> writes: Lars> Dekel Tsur <[EMAIL PROTECTED]> writes: | The name of the Lars> variable is misleading. It should be in_command or something | Lars> similar (note that this is also the case in the inset classes Lars> Latex() | methods: the 2nd

Re: Patch (bug fix)

2000-04-26 Thread Lars Gullik Bjønnes
Dekel Tsur <[EMAIL PROTECTED]> writes: | The name of the variable is misleading. It should be in_command or something | similar (note that this is also the case in the inset classes Latex() | methods: the 2nd argument is badly called fragile). I have been thinking about that earlier... we should

Re: Patch (bug fix)

2000-04-25 Thread Dekel Tsur
On Tue, Apr 25, 2000 at 06:39:21PM +0200, Jean-Marc Lasgouttes wrote: > > "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes: > > Dekel> The following patch allows using the URL inset inside the > Dekel> \thanks{} command (it adds \protect to the LaTeX file). > > I am not sure about the follow

Re: Patch (bug fix)

2000-04-25 Thread Jean-Marc Lasgouttes
> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes: Dekel> --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Dekel> The following patch allows using the URL inset inside the Dekel> \thanks{} command (it adds \protect to the LaTeX file). I am not sure about the following: @@ -22