Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-10-06 Thread Scott Kostyshak
On Sat, Oct 6, 2012 at 11:03 AM, Richard Heck wrote: > On 10/06/2012 12:55 AM, Scott Kostyshak wrote: >> >> Are these patches OK for trunk and branch? >> > I meant to have said yes here: They're in. Thanks, Scott > > Good for branch, then. Scott, you know about status.20x,

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-10-06 Thread Richard Heck
On 10/06/2012 12:55 AM, Scott Kostyshak wrote: Are these patches OK for trunk and branch? I meant to have said yes here: Good for branch, then. Scott, you know about status.20x, yes? I do, but I would have forgotten to update it. Thank you for the reminder. Attached are the patches for t

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-10-05 Thread Scott Kostyshak
Are these patches OK for trunk and branch? Thanks, Scott On Tue, Oct 2, 2012 at 6:34 AM, Scott Kostyshak wrote: > On Mon, Oct 1, 2012 at 9:43 AM, Richard Heck wrote: >> On 10/01/2012 04:04 AM, Jean-Marc Lasgouttes wrote: >>> >>> Le 01/10/2012 08:56, Scott Kostyshak a écrit : On Mon,

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-10-02 Thread Scott Kostyshak
On Mon, Oct 1, 2012 at 9:43 AM, Richard Heck wrote: > On 10/01/2012 04:04 AM, Jean-Marc Lasgouttes wrote: >> >> Le 01/10/2012 08:56, Scott Kostyshak a écrit : >>> >>> On Mon, Oct 1, 2012 at 2:46 AM, Yihui Xie wrote: I have tested it on my Windows 7 and I did not see any problems. >>> >>

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-10-01 Thread Richard Heck
On 10/01/2012 04:04 AM, Jean-Marc Lasgouttes wrote: Le 01/10/2012 08:56, Scott Kostyshak a écrit : On Mon, Oct 1, 2012 at 2:46 AM, Yihui Xie wrote: I have tested it on my Windows 7 and I did not see any problems. Great, thanks for doing that Yihui. In that case, the question becomes -- shoul

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-10-01 Thread Jean-Marc Lasgouttes
Le 01/10/2012 08:56, Scott Kostyshak a écrit : On Mon, Oct 1, 2012 at 2:46 AM, Yihui Xie wrote: I have tested it on my Windows 7 and I did not see any problems. Great, thanks for doing that Yihui. In that case, the question becomes -- should this be committed only to trunk? I would be in favo

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-09-30 Thread Scott Kostyshak
On Mon, Oct 1, 2012 at 2:46 AM, Yihui Xie wrote: > I have tested it on my Windows 7 and I did not see any problems. Great, thanks for doing that Yihui. In that case, the question becomes -- should this be committed only to trunk? I would be in favor of committing it to branch, but I'm not sure if

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-09-30 Thread Yihui Xie
I have tested it on my Windows 7 and I did not see any problems. Regards, Yihui -- Yihui Xie Phone: 515-294-2465 Web: http://yihui.name Department of Statistics, Iowa State University 2215 Snedecor Hall, Ames, IA On Mon, Oct 1, 2012 at 1:35 AM, Scott Kostyshak wrote: > On Fri, Sep 28, 2012 at

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-09-30 Thread Scott Kostyshak
On Fri, Sep 28, 2012 at 2:50 AM, Yihui Xie wrote: > I'm confident enough with the updated lyxknitr.R, but we may still > need to test it under Windows. OK. Let's wait for someone to test on Windows first then. I'm not sure what the protocol for committing is if we can't find a Windows + LyX + R +

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-09-27 Thread Yihui Xie
I'm confident enough with the updated lyxknitr.R, but we may still need to test it under Windows. Regards, Yihui -- Yihui Xie Phone: 515-294-2465 Web: http://yihui.name Department of Statistics, Iowa State University 2215 Snedecor Hall, Ames, IA On Fri, Sep 28, 2012 at 1:43 AM, Scott Kostyshak

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-09-27 Thread Scott Kostyshak
On Thu, Sep 27, 2012 at 3:56 PM, Scott Kostyshak wrote: > On Thu, Sep 27, 2012 at 1:40 PM, Yihui Xie wrote: >> Hi Scott, >> >> Attached is my patch. Now lyxknitr.R does not move files at all; all >> old tricks are gone, and the R script is much cleaner. I have tested >> it under Ubuntu. > > It lo

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-09-27 Thread Scott Kostyshak
On Thu, Sep 27, 2012 at 1:40 PM, Yihui Xie wrote: > Hi Scott, > > Attached is my patch. Now lyxknitr.R does not move files at all; all > old tricks are gone, and the R script is much cleaner. I have tested > it under Ubuntu. It looks a lot cleaner indeed. > I'm not sure you can commit it to the

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-09-27 Thread Yihui Xie
Hi Scott, Attached is my patch. Now lyxknitr.R does not move files at all; all old tricks are gone, and the R script is much cleaner. I have tested it under Ubuntu. I'm not sure you can commit it to the git repository, so I cc JMarc. BTW, I also updated the homepage of the knitr package from yih

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-09-27 Thread Yihui Xie
I was bitten by this problem as well a few days ago, but I forgot to work on it. I think I have a better fix which does not involve with copying or renaming files at all. I'll do it soon. Thanks! Regards, Yihui -- Yihui Xie Phone: 515-294-2465 Web: http://yihui.name Department of Statistics, Iowa

Re: [PATCH] lyxknitr failed when /tmp on different fs

2012-09-27 Thread Kornel Benko
Am Donnerstag, 27. September 2012 um 07:18:36, schrieb Scott Kostyshak > When /tmp was on a different file system (e.g. encrypted home), > lyxknitr.R failed to move files to /tmp because it relied on R's > 'file.rename' function, which in turn relied on the rename function in > , which was failin