Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-18 Thread Jean-Marc Lasgouttes
Le 16/07/2024 à 17:26, Richard Kimberly Heck a écrit : On 7/16/24 9:48 AM, Jean-Marc Lasgouttes wrote: Le 15/07/2024 à 18:14, Scott Kostyshak a écrit : I cannot reproduce, but the following patch makes sense. Does it work? Yes it fixes the behavior both with and without change tracking. Tha

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-16 Thread Richard Kimberly Heck
On 7/16/24 9:48 AM, Jean-Marc Lasgouttes wrote: Le 15/07/2024 à 18:14, Scott Kostyshak a écrit : I cannot reproduce, but the following patch makes sense. Does it work? Yes it fixes the behavior both with and without change tracking. Thanks, I pushed it to master. I am very surprised to see s

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-16 Thread Jean-Marc Lasgouttes
Le 15/07/2024 à 18:14, Scott Kostyshak a écrit : I cannot reproduce, but the following patch makes sense. Does it work? Yes it fixes the behavior both with and without change tracking. Thanks, I pushed it to master. I am very surprised to see such a nasty error in our undo code. I thought it

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-15 Thread Scott Kostyshak
On Mon, Jul 15, 2024 at 02:58:10PM GMT, Jean-Marc Lasgouttes wrote: > Le 02/07/2024 à 18:01, Scott Kostyshak a écrit : > > To reproduce: > > > > 1. Fresh build on current master. > > 2. Open User Guide. > > 3. Make sure that editing is enabled, and turn off change tracking. > > 4. Scroll to the en

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-15 Thread Jean-Marc Lasgouttes
Le 02/07/2024 à 18:01, Scott Kostyshak a écrit : To reproduce: 1. Fresh build on current master. 2. Open User Guide. 3. Make sure that editing is enabled, and turn off change tracking. 4. Scroll to the end. 5. Select multiple bib items. 6. Click on the yellow note. 7. Do Undo with ctrl + z. I g

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-13 Thread Scott Kostyshak
On Sat, Jul 13, 2024 at 06:32:41PM GMT, Kornel Benko wrote: > Am Sat, 13 Jul 2024 10:42:26 -0400 > schrieb Scott Kostyshak : > > > On Sat, Jul 13, 2024 at 02:49:06PM GMT, Kornel Benko wrote: > > > Am Wed, 3 Jul 2024 22:04:44 -0400 > > > schrieb Scott Kostyshak : > > > > > > > On Thu, Jul 04, 20

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-13 Thread Kornel Benko
Am Sat, 13 Jul 2024 10:42:26 -0400 schrieb Scott Kostyshak : > On Sat, Jul 13, 2024 at 02:49:06PM GMT, Kornel Benko wrote: > > Am Wed, 3 Jul 2024 22:04:44 -0400 > > schrieb Scott Kostyshak : > > > > > On Thu, Jul 04, 2024 at 12:39:22AM GMT, Jean-Marc Lasgouttes wrote: > > > > Le 02/07/2024 à

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-13 Thread Scott Kostyshak
On Sat, Jul 13, 2024 at 02:49:06PM GMT, Kornel Benko wrote: > Am Wed, 3 Jul 2024 22:04:44 -0400 > schrieb Scott Kostyshak : > > > On Thu, Jul 04, 2024 at 12:39:22AM GMT, Jean-Marc Lasgouttes wrote: > > > Le 02/07/2024 à 18:01, Scott Kostyshak a écrit : > > > > To reproduce: > > > > > > > > 1. F

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-13 Thread Kornel Benko
Am Wed, 3 Jul 2024 22:04:44 -0400 schrieb Scott Kostyshak : > On Thu, Jul 04, 2024 at 12:39:22AM GMT, Jean-Marc Lasgouttes wrote: > > Le 02/07/2024 à 18:01, Scott Kostyshak a écrit : > > > To reproduce: > > > > > > 1. Fresh build on current master. > > > 2. Open User Guide. > > > 3. Make sure t

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-03 Thread Scott Kostyshak
On Thu, Jul 04, 2024 at 12:39:22AM GMT, Jean-Marc Lasgouttes wrote: > Le 02/07/2024 à 18:01, Scott Kostyshak a écrit : > > To reproduce: > > > > 1. Fresh build on current master. > > 2. Open User Guide. > > 3. Make sure that editing is enabled, and turn off change tracking. > > 4. Scroll to the en

Re: SIGSEGV when doing undo after putting bib items in a note

2024-07-03 Thread Jean-Marc Lasgouttes
Le 02/07/2024 à 18:01, Scott Kostyshak a écrit : To reproduce: 1. Fresh build on current master. 2. Open User Guide. 3. Make sure that editing is enabled, and turn off change tracking. 4. Scroll to the end. 5. Select multiple bib items. 6. Click on the yellow note. 7. Do Undo with ctrl + z. I g

SIGSEGV when doing undo after putting bib items in a note

2024-07-02 Thread Scott Kostyshak
To reproduce: 1. Fresh build on current master. 2. Open User Guide. 3. Make sure that editing is enabled, and turn off change tracking. 4. Scroll to the end. 5. Select multiple bib items. 6. Click on the yellow note. 7. Do Undo with ctrl + z. I get the attached backtrace. Can anyone else reproduc