Re: [Updated PATCH] Re: crash while dissolving tabular

2007-07-21 Thread Angus Leeming
Abdelrazak Younes wrote: @@ -32,16 +32,24 @@ { // try to get the current cell BufferView const * const bv = kernel().bufferview(); +InsetTabular const * current_inset = 0; if (bv) { Cursor const & cur = bv->cursor(); // get the innermost tabular inset;

Re: [Updated PATCH] Re: crash while dissolving tabular

2007-07-18 Thread Abdelrazak Younes
Angus Leeming wrote: Abdelrazak Younes wrote: I got a much better solution attached. Abdel. Index: frontends/controllers/ControlTabular.cpp === --- fronten

Re: [Updated PATCH] Re: crash while dissolving tabular

2007-07-18 Thread Angus Leeming
Abdelrazak Younes wrote: I got a much better solution attached. Abdel. Index: frontends/controllers/ControlTabular.cpp === --- frontends/controllers/Control

Re: [Updated PATCH] Re: crash while dissolving tabular

2007-07-18 Thread Abdelrazak Younes
José Matos wrote: On Wednesday 18 July 2007 10:13:58 Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I got a much better solution attached. This seems to work AFAICS. Jose? OK. Done. Abdel.

Re: [Updated PATCH] Re: crash while dissolving tabular

2007-07-18 Thread José Matos
On Wednesday 18 July 2007 10:13:58 Abdelrazak Younes wrote: > Jürgen Spitzmüller wrote: > > Abdelrazak Younes wrote: > >> I got a much better solution attached. > > > > This seems to work AFAICS. > > Jose? OK. -- José Abílio

Re: [Updated PATCH] Re: crash while dissolving tabular

2007-07-18 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I got a much better solution attached. This seems to work AFAICS. Jose?

Re: [Updated PATCH] Re: crash while dissolving tabular

2007-07-18 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I got a much better solution attached. This seems to work AFAICS. Thanks. Jürgen

[Updated PATCH] Re: crash while dissolving tabular

2007-07-18 Thread Abdelrazak Younes
Abdelrazak Younes wrote: Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Here is a radical solution. I should have thought about this earlier! The dialog will be updated in any case by the LyXFunc::dispatch() method so the updating done in InsetTabular::dispatch() is superfluous. This patc

Re: [PATCH] Re: crash while dissolving tabular

2007-07-18 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: Here is a radical solution. I should have thought about this earlier! The dialog will be updated in any case by the LyXFunc::dispatch() method so the updating done in InsetTabular::dispatch() is superfluous. This patch - doesn't compile (is_de

Re: [PATCH] Re: crash while dissolving tabular

2007-07-18 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Here is a radical solution. I should have thought about this earlier! > The dialog will be updated in any case by the LyXFunc::dispatch() method > so the updating done in InsetTabular::dispatch() is superfluous. This patch - doesn't compile (is_deleted_ is still used in

[PATCH] Re: crash while dissolving tabular

2007-07-18 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I cannot reproduce the crash under windows but this looks familiar to an old crash you had with the Toc if you remember. I rather think it's a remainder of bug 3258. Note that in the backtrace, line 3497 in InsetTabular::doDispatch is reached

Re: crash while dissolving tabular

2007-07-17 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > Yes, it should be true but as I said, I cannot reproduce the bug so I > guess it will be true for me. It also doesn't always crash for me (but very often). > I'll try to debug that today to verify that. Please let me know if I can do something. Jürgen

Re: crash while dissolving tabular

2007-07-17 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: Abdelrazak Younes wrote: I cannot reproduce the crash under windows but this looks familiar to an old crash you had with the Toc if you remember. I rather think it's a remainder of bug 3258. Note that in the backtrace, line 3497 in InsetTabular::doDispatch is reached

Re: crash while dissolving tabular

2007-07-17 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I cannot reproduce the crash under windows but this looks familiar to an > old crash you had with the Toc if you remember. I rather think it's a remainder of bug 3258. Note that in the backtrace, line 3497 in InsetTabular::doDispatch is reached, if (!is_deleted

Re: crash while dissolving tabular

2007-07-17 Thread Bo Peng
On 7/17/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote: - New Document - Insert 1x1 tabular (one cell) - type "foo" inside cell - hit DEL => crash I can confirm this. A really easy way to crash lyx. Bo

Re: crash while dissolving tabular

2007-07-17 Thread Jürgen Spitzmüller
Abdelrazak Younes wrote: > I just committed a fix in the std declaration, does that help? No. Jürgen

Re: crash while dissolving tabular

2007-07-17 Thread Abdelrazak Younes
Jürgen Spitzmüller wrote: - New Document - Insert 1x1 tabular (one cell) - type "foo" inside cell - hit DEL => crash I cannot reproduce the crash under windows but this looks familiar to an old crash you had with the Toc if you remember. I just committed a fix in the std declaration, does th

crash while dissolving tabular

2007-07-17 Thread Jürgen Spitzmüller
- New Document - Insert 1x1 tabular (one cell) - type "foo" inside cell - hit DEL => crash Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 47819059702400 (LWP 29034)] 0x in ?? () (gdb) bt #0 0x in ?? () #1 0x00a11d53 in lyx::Inset