Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-09 Thread Jean-Marc Lasgouttes
> "Andre" == Andre Poenitz <[EMAIL PROTECTED]> writes: >> > Let's wait a bit to see whether Andre chimes in... Andre> Aehm. What? Andre> Selection? This is two dociterators, 'anchor' and 'cursor', Andre> with anchor.size() >= cursor.size() and anchor[i].inset() == Andre> cursor[i].inset() fo

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-07 Thread Andre Poenitz
On Sat, Nov 05, 2005 at 08:10:39AM +0200, Martin Vermeer wrote: > On Fri, Nov 04, 2005 at 11:11:06PM +0100, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > Martin> I don't understand this at all. > > > > You mean what I wrote above? > > I mean

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-07 Thread Andre Poenitz
On Thu, Nov 03, 2005 at 06:01:53PM +0200, Martin Vermeer wrote: > On Thu, 2005-11-03 at 15:07 +0100, Jean-Marc Lasgouttes wrote: > > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > > > >> - do any font change (e.g. C-b) ==> crash > > > > Martin> No it doesn't. Not with this fix.

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-07 Thread Martin Vermeer
On Mon, 2005-11-07 at 15:23 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> In case you wondered, yes I did try it out ;-) > > It was just in case :) It's in now. - Martin signature.asc Description: This is a digitally signed mess

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> In case you wondered, yes I did try it out ;-) It was just in case :) JMarc

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-07 Thread Martin Vermeer
On Mon, 2005-11-07 at 14:25 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> Also, could you update the code in drawSelection (both versions > >> just in case) to use directly selectionBegin/End? > > Martin> Like this? > > Exactly. If it ac

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Also, could you update the code in drawSelection (both versions >> just in case) to use directly selectionBegin/End? Martin> Like this? Exactly. If it actually works, please commit. JMarc

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-07 Thread Martin Vermeer
On Mon, 2005-11-07 at 12:40 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> If selectionEnd is resize to go oustside an inset, the pos at top > >> level has to be incremented, so that the inset is in the selection. > >> Look at the comment

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-07 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> If selectionEnd is resize to go oustside an inset, the pos at top >> level has to be incremented, so that the inset is in the selection. >> Look at the comment in the anchor() method. Martin> OK, point taken. Better patch attached.

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-07 Thread Helge Hafting
This patch also removes my crash. :-) Helge Hafting

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-06 Thread Martin Vermeer
On Sat, Nov 05, 2005 at 11:03:08AM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Fri, Nov 04, 2005 at 11:11:06PM +0100, Jean-Marc Lasgouttes > Martin> wrote: > >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > >> >

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-05 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Fri, Nov 04, 2005 at 11:11:06PM +0100, Jean-Marc Lasgouttes Martin> wrote: >> > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> Martin> I don't understand this at all. >> You mean what I wrote above? Martin> I

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-04 Thread Martin Vermeer
On Fri, Nov 04, 2005 at 11:11:06PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> I don't understand this at all. > > You mean what I wrote above? I mean especially "Aren't you supposed to play similar ++ tricks like that?" > > Mar

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-04 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> I don't understand this at all. You mean what I wrote above? Martin> All I know is that my patch works, and that I thought I Martin> understood why. Now I'm not so sure anymore. Martin> Anyway, a working patch for 1.4. Shouldn

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-04 Thread Martin Vermeer
On Fri, 2005-11-04 at 14:42 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> The attached patch is perhaps more what you had in mind. It > Martin> forces the selectionBegin and selectionEnd iterators to be of > Martin> the same depth. Wo

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-04 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> The attached patch is perhaps more what you had in mind. It Martin> forces the selectionBegin and selectionEnd iterators to be of Martin> the same depth. Works for both cases: selecting to the left Martin> and to the right. I bel

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language] patch ok!

2005-11-04 Thread Helge Hafting
Martin Vermeer wrote: The attached patch is perhaps more what you had in mind. It forces the selectionBegin and selectionEnd iterators to be of the same depth. Works for both cases: selecting to the left and to the right. I believe that covers all bases. I can confirm that this patch fixes

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Martin Vermeer
On Thu, Nov 03, 2005 at 07:22:56PM +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> Your observation. that the "painting" of the selection somehow > Martin> keeps begin and end of the selection on the same depth, is > Martin> valid thoug

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> Your observation. that the "painting" of the selection somehow Martin> keeps begin and end of the selection on the same depth, is Martin> valid though. I wonder where that happens. It is in LyXText::drawSelection. The code is du

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Martin Vermeer
On Thu, 2005-11-03 at 15:07 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > >> - do any font change (e.g. C-b) ==> crash > > Martin> No it doesn't. Not with this fix. > > I understand that. However, what happens if ditend is deeper than dit?

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: >> - do any font change (e.g. C-b) ==> crash Martin> No it doesn't. Not with this fix. I understand that. However, what happens if ditend is deeper than dit? What happens if they are as deep but in two different insets? JMarc

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Martin Vermeer
On Thu, 2005-11-03 at 14:09 +0100, Jean-Marc Lasgouttes wrote: > > "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: > > Martin> On Thu, Nov 03, 2005 at 09:06:17AM +0100, Helge Hafting wrote: > >> The bugzilla entry is now updated with a test document and this > >> crash recipe. It trips

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Helge Hafting
Jean-Marc Lasgouttes wrote: "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Thu, Nov 03, 2005 at 09:06:17AM +0100, Helge Hafting wrote: The bugzilla entry is now updated with a test document and this crash recipe. It trips the assert everytime for me:

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Jean-Marc Lasgouttes
> "Martin" == Martin Vermeer <[EMAIL PROTECTED]> writes: Martin> On Thu, Nov 03, 2005 at 09:06:17AM +0100, Helge Hafting wrote: >> The bugzilla entry is now updated with a test document and this >> crash recipe. It trips the assert everytime for me: Martin> Here's the fix. I do not think it

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Martin Vermeer
On Thu, Nov 03, 2005 at 09:06:17AM +0100, Helge Hafting wrote: > The bugzilla entry is now updated with a test document and this crash > recipe. It trips the assert everytime for me: Here's the fix. - Martin Index: text2.C === RCS

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Martin Vermeer
On Thu, 2005-11-03 at 09:06 +0100, Helge Hafting wrote: > The bugzilla entry is now updated with a test document and this crash > recipe. It trips the assert everytime for me: Yesss! > Start the mouse in front of > the word "text" inside the box, end outside the box, so the entire box > with c

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-03 Thread Helge Hafting
The bugzilla entry is now updated with a test document and this crash recipe. It trips the assert everytime for me: * Make sure the lyx default language is something other than british, I used "norsk" * open lang.lyx * Use the mouse everytime you make a selection * select the word "text" (firs

Re: lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-02 Thread Martin Vermeer
On Wed, Nov 02, 2005 at 11:09:32AM +0100, Helge Hafting wrote: ... > Selected the entire box and some more text > Used edit->text style: > Decided to "reset" language. > Lyx-1.4cvs died with this assert message: > pasteSelection 0 > Assertion triggered in void Paragraph::setFont(lyx::pos_ty

lyx-1.4 cvs assertion crash when resetting "wrong" language]

2005-11-02 Thread Helge Hafting
Used todays cvs, opened a existing document. (Written in british language, which is unusual here) Wrote two lines of text, used edit->text style to give them different font sizes & sans serif. This is a customized heading. Marked it, inserted a box(minipage) around it. Noticed the silly blue lin