lyx2lyx for patch 1820

2007-07-17 Thread Dov Feldstern
Hi! Attached find a lyx2lyx for patch 1820. It's not perfect, though --- it actually corrupts some files which shouldn't be changed at all; if anyone wants to try and fix that, be my guest, I've just spent the past six hours on this and I'm not sure that it's doab

Re: lyx2lyx for patch 1820

2007-07-17 Thread Enrico Forestieri
On Wed, Jul 18, 2007 at 03:21:52AM +0300, Dov Feldstern wrote: > Hi! > > Attached find a lyx2lyx for patch 1820. It's not perfect, though --- it > actually corrupts some files which shouldn't be changed at all; if > anyone wants to try and fix that, be my guest, I'

Re: lyx2lyx for patch 1820

2007-07-17 Thread Richard Heck
Enrico Forestieri wrote: On Wed, Jul 18, 2007 at 03:21:52AM +0300, Dov Feldstern wrote: Hi! Attached find a lyx2lyx for patch 1820. It's not perfect, though --- it actually corrupts some files which shouldn't be changed at all; if anyone wants to try and fix that, be my guest,

Re: lyx2lyx for patch 1820

2007-07-17 Thread Abdelrazak Younes
Enrico Forestieri wrote: On Wed, Jul 18, 2007 at 03:21:52AM +0300, Dov Feldstern wrote: Hi! Attached find a lyx2lyx for patch 1820. It's not perfect, though --- it actually corrupts some files which shouldn't be changed at all; if anyone wants to try and fix that, be my guest,

Re: lyx2lyx for patch 1820

2007-07-18 Thread José Matos
On Wednesday 18 July 2007 01:21:52 Dov Feldstern wrote: > Also, this has only convinced me even more that it's wrong to apply a > lyx2lyx fix for this patch: this is a bug fix, there were previously > .lyx files which were ok, but which lyx was generating incorrect latex > for, and patch 1820 fixes

Re: lyx2lyx for patch 1820

2007-07-18 Thread Dov Feldstern
José Matos wrote: On Wednesday 18 July 2007 01:21:52 Dov Feldstern wrote: Also, this has only convinced me even more that it's wrong to apply a lyx2lyx fix for this patch: this is a bug fix, there were previously .lyx files which were ok, but which lyx was generating incorrect latex for, and pat

Re: lyx2lyx for patch 1820

2007-07-18 Thread Dov Feldstern
Dov Feldstern wrote: José Matos wrote: On Wednesday 18 July 2007 01:21:52 Dov Feldstern wrote: Also, this has only convinced me even more that it's wrong to apply a lyx2lyx fix for this patch: this is a bug fix, there were previously .lyx files which were ok, but which lyx was generating incorr

Re: lyx2lyx for patch 1820

2007-07-18 Thread Martin Vermeer
On Thu, Jul 19, 2007 at 12:35:52AM +0300, Dov Feldstern wrote: > Dov Feldstern wrote: > > José Matos wrote: > >> On Wednesday 18 July 2007 01:21:52 Dov Feldstern wrote: > >>> Also, this has only convinced me even more that it's wrong to apply a > >>> lyx2lyx fix for this patch: this is a bug fix,

Re: lyx2lyx for patch 1820

2007-07-19 Thread José Matos
On Wednesday 18 July 2007 22:35:52 Dov Feldstern wrote: > Attached find a patch which includes: > >   - a placeholder format change for bug 1820 Either we change the file format now or we don't. I don't want to be in a gray area. Since we have decided not to convert old document do I thi

Re: lyx2lyx for patch 1820

2007-07-19 Thread Dov Feldstern
José Matos wrote: On Wednesday 18 July 2007 22:35:52 Dov Feldstern wrote: Jose --- can I commit the patch itself, along with these additions? Without the placeholder for the file format yes. Committed (finally :) ) as r19150, without the placeholder format. I made some changes to this sin