Re: qt4 citation dialog

2006-06-28 Thread Edwin Leuven
Abdelrazak Younes wrote: Yep, go ahead. done I see that you didn't need the initializeParam() overload after all. Does buffer switch work as expected now? it didn't and doesn't work next on the todo list...

Re: qt4 citation dialog

2006-06-28 Thread Abdelrazak Younes
Edwin Leuven wrote: updated patch attached. i would suggest to put this in (unless i have overseen something important). things can always be taken further from there... Yep, go ahead. I see that you didn't need the initializeParam() overload after all. Does buffer switch work as expected no

Re: qt4 citation dialog

2006-06-27 Thread Edwin Leuven
updated patch attached. i would suggest to put this in (unless i have overseen something important). things can always be taken further from there... - natbib style (the combox) works - when moving/up down the item stays selected (allowing sequential ups/downs) - when deleting the next sele

Re: qt4 citation dialog

2006-06-27 Thread Jose' Matos
On Tuesday 27 June 2006 17:41, Juergen Spitzmueller wrote: > But only if the user does not use the Bibliography environment. ... and we should walk through all include files to guarantee this. > Jürgen -- José Abílio

Re: qt4 citation dialog

2006-06-27 Thread Juergen Spitzmueller
Abdelrazak Younes wrote: >> 2) For usability, it would be nice if when you try to insert a citation >> when you have not chosen a bibtex file to get a dialog box with an >> explanation "You have not inserted a bibliography in your document" > > I would even suggest a button that will call the "in

Re: qt4 citation dialog

2006-06-27 Thread Abdelrazak Younes
Charles de Miramon wrote: 2) For usability, it would be nice if when you try to insert a citation when you have not chosen a bibtex file to get a dialog box with an explanation "You have not inserted a bibliography in your document" I would even suggest a button that will call the "insert bibt

Re: qt4 citation dialog

2006-06-27 Thread Charles de Miramon
Edwin Leuven wrote: > the attached patch puts the citation dialog in a workable state for me > > comments appreciated > > ed. 1) Would it be possible to add a 'jurabib face' to the dialog with a subset of the natbib version : a) the text after field that should be renamed 'pagination' b) a chec

Re: qt4 citation dialog

2006-06-27 Thread Edwin Leuven
Abdelrazak Younes wrote: I mean, do you disable multiple-selection in the widget list? If not there would be a problem if you click on add or delete when two items are selected. only 1 item can be selected at a time.. I guess you need to overload "ControlCitation::initialiseParams()": will

Re: qt4 citation dialog

2006-06-27 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Fine with me but how do you handle the multiple-selection case? is this different from multiple add/delete? I mean, do you disable multiple-selection in the widget list? If not there would be a problem if you click on add or delete when two items

Re: qt4 citation dialog

2006-06-27 Thread Edwin Leuven
Juergen Spitzmueller wrote: It was added as a compromise when the "add dialog" has been introduced. Its advantage then was that you didn't have to reopen that subdialog multiple times for multiple citations. IMHO you can rid of it now that the add dialog has gone again in qt4 (which is a good mov

Re: qt4 citation dialog

2006-06-27 Thread Edwin Leuven
Abdelrazak Younes wrote: Fine with me but how do you handle the multiple-selection case? is this different from multiple add/delete? am not so sure we need the advanced search dialog, i would suggest to get rid of it I thought it might be useful for advanced Natbib and BibTex with Regexp e

Re: qt4 citation dialog

2006-06-27 Thread Abdelrazak Younes
Edwin Leuven wrote: Abdelrazak Younes wrote: Could you give me a summary of what you did please? I understand that you are disabling multiple add/delete citations, aren't you? yes. i didn't see the big advantage, it simplifies the code, and it makes the behavior consistent with the up/down bu

Re: qt4 citation dialog

2006-06-27 Thread Juergen Spitzmueller
Edwin Leuven wrote: > yes. i didn't see the big advantage, it simplifies the code, and it > makes the behavior consistent with the up/down buttons that handle one > entry at a time... It was added as a compromise when the "add dialog" has been introduced. Its advantage then was that you didn't ha

Re: qt4 citation dialog

2006-06-27 Thread Edwin Leuven
Abdelrazak Younes wrote: Could you give me a summary of what you did please? I understand that you are disabling multiple add/delete citations, aren't you? yes. i didn't see the big advantage, it simplifies the code, and it makes the behavior consistent with the up/down buttons that handle one

Re: qt4 citation dialog

2006-06-27 Thread Abdelrazak Younes
Edwin Leuven wrote: the attached patch puts the citation dialog in a workable state for me comments appreciated Hi Edwin, I welcome your initiative :-) Could you give me a summary of what you did please? I understand that you are disabling multiple add/delete citations, aren't you? Does "

qt4 citation dialog

2006-06-27 Thread Edwin Leuven
the attached patch puts the citation dialog in a workable state for me comments appreciated ed. Index: src/frontends/qt4/QCitation.C === --- src/frontends/qt4/QCitation.C (revision 14247) +++ src/frontends/qt4/QCitation.C

Re: SVN commit failed (was Re: [Patch] Qt4 Citation dialog model view separation.)

2006-04-11 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: No I use tortoiseSVN and there's nothing in the settings that offers a choice for line-ending. No svn client I know offers this choice, it is compiled in (depending on the OS). If you tell me this is a problem, I will swith for good to another e

Re: SVN commit failed (was Re: [Patch] Qt4 Citation dialog model view separation.)

2006-04-11 Thread Georg Baum
Abdelrazak Younes wrote: > No I use tortoiseSVN and there's nothing in the settings that offers a > choice for line-ending. No svn client I know offers this choice, it is compiled in (depending on the OS). > If you tell me this is a problem, I will swith for good to another editor. I don't know

Re: SVN commit failed (was Re: [Patch] Qt4 Citation dialog model view separation.)

2006-04-11 Thread Abdelrazak Younes
Georg Baum a écrit : Abdelrazak Younes wrote: Abdelrazak Younes a écrit : It seems that I cannot commit: Error: Commit failed (details follow): Error: 'pre-commit' hook failed with error output: Is it still the end-of-line problem? I have reverted to my crappy VC++ 6 editor so there might b

Re: SVN commit failed (was Re: [Patch] Qt4 Citation dialog model view separation.)

2006-04-11 Thread Georg Baum
Abdelrazak Younes wrote: > Abdelrazak Younes a écrit : >> It seems that I cannot commit: >> >> Error: Commit failed (details follow): >> Error: 'pre-commit' hook failed with error output: >> >> Is it still the end-of-line problem? I have reverted to my crappy VC++ 6 >> editor so there might be

Re: SVN commit failed (was Re: [Patch] Qt4 Citation dialog model view separation.)

2006-04-11 Thread Abdelrazak Younes
Abdelrazak Younes a écrit : It seems that I cannot commit: Error: Commit failed (details follow): Error: 'pre-commit' hook failed with error output: Is it still the end-of-line problem? I have reverted to my crappy VC++ 6 editor so there might be some CR-LF left. But you told me that was OK..

SVN commit failed (was Re: [Patch] Qt4 Citation dialog model view separation.)

2006-04-11 Thread Abdelrazak Younes
It seems that I cannot commit: Error: Commit failed (details follow): Error: 'pre-commit' hook failed with error output: Is it still the end-of-line problem? I have reverted to my crappy VC++ 6 editor so there might be some CR-LF left. But you told me that was OK... Abdel. Abdelrazak Youne

[Patch] Qt4 Citation dialog model view separation.

2006-04-11 Thread Abdelrazak Younes
Dear Qt4 followers, I have continued a bit on my track to do a real model view separation for the Citation Dialog. In this new scheme, QCitation is the controller and the model at the same time, it inherits ControlCitation and it doesn't know about the view. QCitationDialog is the view, it is