Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Jürgen Spitzmüller
vfr wrote: > Author: vfr > Date: Tue Jul 7 10:13:07 2009 > New Revision: 30395 > URL: http://www.lyx.org/trac/changeset/30395 > > Log: > Fix crash when selecting part of a macro and trying to resume macro-mode > editing. Please let me know whatever of these macro fixes is to be considered for br

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Vincent van Ravesteijn
Jürgen Spitzmüller schreef: vfr wrote: Author: vfr Date: Tue Jul 7 10:13:07 2009 New Revision: 30395 URL: http://www.lyx.org/trac/changeset/30395 Log: Fix crash when selecting part of a macro and trying to resume macro-mode editing. Please let me know whatever of these macro fixes is

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Jürgen Spitzmüller
Vincent van Ravesteijn wrote: > r30392, r30393, and r30395 are fixes problems that were introduced by > the fix for bug 5923. To be safe, I didn't backport this fix for the > previous release, but it might be a candidate for branch now. Could you come up with a complete patch for branch that integ

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Enrico Forestieri
On Tue, Jul 07, 2009 at 10:56:38AM +0200, Jürgen Spitzmüller wrote: > Vincent van Ravesteijn wrote: > > r30392, r30393, and r30395 are fixes problems that were introduced by > > the fix for bug 5923. To be safe, I didn't backport this fix for the > > previous release, but it might be a candidate fo

RE: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Vincent van Ravesteijn - TNW
>> Vincent van Ravesteijn wrote: >> > r30392, r30393, and r30395 are fixes problems that were introduced >> > by the fix for bug 5923. To be safe, I didn't backport this fix for >> > the previous release, but it might be a candidate for branch now. >> >> Could you come up with a complete patch

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Vincent van Ravesteijn
Enrico Forestieri schreef: On Tue, Jul 07, 2009 at 10:56:38AM +0200, Jürgen Spitzmüller wrote: Vincent van Ravesteijn wrote: r30392, r30393, and r30395 are fixes problems that were introduced by the fix for bug 5923. To be safe, I didn't backport this fix for the previous release, but i

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Enrico Forestieri
On Tue, Jul 07, 2009 at 09:37:14PM +0200, Vincent van Ravesteijn wrote: > Enrico Forestieri schreef: > > On Tue, Jul 07, 2009 at 10:56:38AM +0200, Jürgen Spitzmüller wrote: > > > >> Vincent van Ravesteijn wrote: > >> > >>> r30392, r30393, and r30395 are fixes problems that were introduced b

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-07 Thread Enrico Forestieri
On Tue, Jul 07, 2009 at 10:52:11PM +0200, Enrico Forestieri wrote: > I suggest reverting r30398, r30396, r30395, r30393, r30392, r29387, > and trying to find the correct fix for #5923. I did that in r30409 and r30410. Let's start from here for fixing remaining issues. Your commits at r30396 and r3

RE: r30395 - lyx-devel/trunk/src/mathed

2009-07-08 Thread Vincent van Ravesteijn - TNW
>> I suggest reverting r30398, r30396, r30395, r30393, >> r30392, r29387, and trying to find the correct fix >> for #5923. > > I did that in r30409 and r30410. Let's start from here > for fixing remaining issues. Good, I never said that my fix was the best, most proper fix, but I hope it contrib

Re: r30395 - lyx-devel/trunk/src/mathed

2009-07-09 Thread Enrico Forestieri
On Wed, Jul 08, 2009 at 11:23:11AM +0200, Vincent van Ravesteijn - TNW wrote: > > > Your commits at r30396 and r30398 were not correct. On > > one hand, one could still position the cursor with the > > mouse and perform a change, on the other hand, the user > > should be able to edit the macro a