toolbar disabled

2006-05-30 Thread Edwin Leuven
i just installed 1.4 (with joost's new installer, worked great) i noticed the following (also present in trunk): the toolbar gets disabled after using a dialog is this a known bug? edwin

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
Edwin == Edwin Leuven [EMAIL PROTECTED] writes: Edwin i just installed 1.4 (with joost's new installer, worked great) Edwin i noticed the following (also present in trunk): Edwin the toolbar gets disabled after using a dialog Edwin is this a known bug? Yes:

Re: toolbar disabled

2006-05-30 Thread Joost Verburg
Jean-Marc Lasgouttes wrote: Edwin i just installed 1.4 (with joost's new installer, worked great) Edwin i noticed the following (also present in trunk): Edwin the toolbar gets disabled after using a dialog Edwin is this a known bug? Yes: http://bugzilla.lyx.org/show_bug.cgi?id=2423 It's

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
Joost == Joost Verburg [EMAIL PROTECTED] writes: Joost Jean-Marc Lasgouttes wrote: Edwin i just installed 1.4 (with joost's new installer, worked great) Edwin i noticed the following (also present in trunk): Edwin the toolbar gets disabled after using a dialog Edwin is this a known bug? Yes:

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Jean-Marc This should fix the bug for everybody but LyX/Mac. This bug Jean-Marc is a byproduct of a LyX/Mac feature that tries to disable Jean-Marc useless menu entries when a dialog has focus. Here is a different idea: it may be that

Re: toolbar disabled

2006-05-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Jean-Marc This should fix the bug for everybody but LyX/Mac. This bug Jean-Marc is a byproduct of a LyX/Mac feature that tries to disable Jean-Marc useless menu entries when a dialog has focus. Here is a

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Jean-Marc Here is a different idea: it may be that no windows is Jean-Marc active (dialog closed, but not yet focus to the main Jean-Marc window). Jean-Marc Does this patch do something useful? Probably not. This should be better.

Re: toolbar disabled

2006-05-30 Thread Joost Verburg
Jean-Marc Lasgouttes wrote: Here is a different idea: it may be that no windows is active (dialog closed, but not yet focus to the main window). Does this patch do something useful? The main window has focus when a dialog is closed, only the toolbar is disabled. Joost

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
Joost == Joost Verburg [EMAIL PROTECTED] writes: Joost Jean-Marc Lasgouttes wrote: Here is a different idea: it may be that no windows is active (dialog closed, but not yet focus to the main window). Does this patch do something useful? Joost The main window has focus when a dialog is

Re: toolbar disabled

2006-05-30 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Jean-Marc Here is a different idea: it may be that no windows is Jean-Marc active (dialog closed, but not yet focus to the main Jean-Marc window). Jean-Marc Does this patch do something useful? Probably

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
Edwin == Edwin Leuven [EMAIL PROTECTED] writes: Edwin Jean-Marc Lasgouttes wrote: Jean-Marc == Jean-Marc Lasgouttes [EMAIL PROTECTED] writes: Jean-Marc Here is a different idea: it may be that no windows is Jean-Marc active (dialog closed, but not yet focus to the main Jean-Marc window).

Re: toolbar disabled

2006-05-30 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: The toolbar is not really disabled. It is in the same state as if there was no buffer loaded, right? yes The problem comes from the fact that the Dialog controller invokes BufferView::update() at some points I have no control on and at these points the code

Re: toolbar disabled

2006-05-30 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: Thanks for testing. And the first one? i only have qt4 here and that had return qApp-activeWindow() == this; which gives the same behavior as 1.4 returning false disables the toolbar always...

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
Edwin == Edwin Leuven [EMAIL PROTECTED] writes: Edwin returning false disables the toolbar always... It should return true of course. This is what happens when sending patches without testing them. JMarc Index: src/frontends/qt2/QtView.C

Re: toolbar disabled

2006-05-30 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: It should return true of course. This is what happens when sending patches without testing them. works for me

toolbar disabled

2006-05-30 Thread Edwin Leuven
i just installed 1.4 (with joost's new installer, worked great) i noticed the following (also present in trunk): the toolbar gets disabled after using a dialog is this a known bug? edwin

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
> "Edwin" == Edwin Leuven <[EMAIL PROTECTED]> writes: Edwin> i just installed 1.4 (with joost's new installer, worked great) Edwin> i noticed the following (also present in trunk): Edwin> the toolbar gets disabled after using a dialog Edwin> is this a known bug? Yes:

Re: toolbar disabled

2006-05-30 Thread Joost Verburg
Jean-Marc Lasgouttes wrote: Edwin> i just installed 1.4 (with joost's new installer, worked great) Edwin> i noticed the following (also present in trunk): Edwin> the toolbar gets disabled after using a dialog Edwin> is this a known bug? Yes: http://bugzilla.lyx.org/show_bug.cgi?id=2423 It's

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
> "Joost" == Joost Verburg <[EMAIL PROTECTED]> writes: Joost> Jean-Marc Lasgouttes wrote: Edwin> i just installed 1.4 (with joost's new installer, worked great) Edwin> i noticed the following (also present in trunk): >> Edwin> the toolbar gets disabled after using a dialog >> Edwin> is this a

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> This should fix the bug for everybody but LyX/Mac. This bug Jean-Marc> is a byproduct of a LyX/Mac feature that tries to disable Jean-Marc> useless menu entries when a dialog has focus. Here is a different idea: it

Re: toolbar disabled

2006-05-30 Thread Abdelrazak Younes
Jean-Marc Lasgouttes wrote: "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> This should fix the bug for everybody but LyX/Mac. This bug Jean-Marc> is a byproduct of a LyX/Mac feature that tries to disable Jean-Marc> useless menu entries when a dialog has focus. Here

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Here is a different idea: it may be that no windows is Jean-Marc> active (dialog closed, but not yet focus to the main Jean-Marc> window). Jean-Marc> Does this patch do something useful? Probably not. This should

Re: toolbar disabled

2006-05-30 Thread Joost Verburg
Jean-Marc Lasgouttes wrote: Here is a different idea: it may be that no windows is active (dialog closed, but not yet focus to the main window). Does this patch do something useful? The main window has focus when a dialog is closed, only the toolbar is disabled. Joost

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
> "Joost" == Joost Verburg <[EMAIL PROTECTED]> writes: Joost> Jean-Marc Lasgouttes wrote: >> Here is a different idea: it may be that no windows is active >> (dialog closed, but not yet focus to the main window). >> >> Does this patch do something useful? Joost> The main window has focus

Re: toolbar disabled

2006-05-30 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> writes: Jean-Marc> Here is a different idea: it may be that no windows is Jean-Marc> active (dialog closed, but not yet focus to the main Jean-Marc> window). Jean-Marc> Does this patch do something useful?

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
> "Edwin" == Edwin Leuven <[EMAIL PROTECTED]> writes: Edwin> Jean-Marc Lasgouttes wrote: >>> "Jean-Marc" == Jean-Marc Lasgouttes <[EMAIL PROTECTED]> >>> writes: >> Jean-Marc> Here is a different idea: it may be that no windows is Jean-Marc> active (dialog closed, but not yet focus to

Re: toolbar disabled

2006-05-30 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: The toolbar is not really disabled. It is in the same state as if there was no buffer loaded, right? yes The problem comes from the fact that the Dialog controller invokes BufferView::update() at some points I have no control on and at these points the code

Re: toolbar disabled

2006-05-30 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: Thanks for testing. And the first one? i only have qt4 here and that had return qApp->activeWindow() == this; which gives the same behavior as 1.4 returning false disables the toolbar always...

Re: toolbar disabled

2006-05-30 Thread Jean-Marc Lasgouttes
> "Edwin" == Edwin Leuven <[EMAIL PROTECTED]> writes: Edwin> returning false disables the toolbar always... It should return true of course. This is what happens when sending patches without testing them. JMarc Index: src/frontends/qt2/QtView.C

Re: toolbar disabled

2006-05-30 Thread Edwin Leuven
Jean-Marc Lasgouttes wrote: It should return true of course. This is what happens when sending patches without testing them. works for me