Re: use FindCXX11Compiler.cmake also for MSVC

Kornel Benko wrote: > I am a bit lost, since the small snippet below does not compile on MSVC > (for unknown reason) > > > template > struct check > { > static_assert(sizeof(int) <= sizeof(T), "not big enough"); > }; > > typedef check

Re: use FindCXX11Compiler.cmake also for MSVC

On 10.12.2015 22:48, Kornel Benko wrote: Am Donnerstag, 10. Dezember 2015 um 21:12:36, schrieb Georg Baum Kornel Benko wrote: I am a bit lost, since the small snippet below does not compile on MSVC (for unknown reason)

Re: use FindCXX11Compiler.cmake also for MSVC

Uwe Stöhr wrote: > So with a clean git tree one only had to apply the attached patch to get > cxx11 for MSVC but compiling leads to these 2 errors: > >D:\LyXGit\Master\src\frontends\qt4\GuiView.cpp(3357): error C3848: > expression having type 'const >

Re: use FindCXX11Compiler.cmake also for MSVC

Am Donnerstag, 10. Dezember 2015 um 21:12:36, schrieb Georg Baum > Kornel Benko wrote: > > > I am a bit lost, since the small snippet below does not compile on MSVC > > (for unknown reason) > > > > > > template > > struct

Re: use FindCXX11Compiler.cmake also for MSVC

Am Donnerstag, 10. Dezember 2015 um 23:39:17, schrieb Peter Kümmel > On 10.12.2015 22:48, Kornel Benko wrote: > > Am Donnerstag, 10. Dezember 2015 um 21:12:36, schrieb Georg Baum > > > >> Kornel Benko wrote: > >> > >>> I am a bit lost, since

Re: use FindCXX11Compiler.cmake also for MSVC

Am Mittwoch, 9. Dezember 2015 um 22:28:04, schrieb Georg Baum > Uwe Stöhr wrote: > > > I tried this but this doesn't make a difference. Also if I comment out > > the cxx11 part in regex.h the compilation fails as soon as I set > > > > set(LYX_USE_CXX11 1) > > >

Re: use FindCXX11Compiler.cmake also for MSVC

Uwe Stöhr wrote: > I tried this but this doesn't make a difference. Also if I comment out > the cxx11 part in regex.h the compilation fails as soon as I set > > set(LYX_USE_CXX11 1) > > I then get many of these: > > D:\LyXGit\Master\src\tex2lyx\table.cpp(284): error C3861: 'min': > identifier

Re: use FindCXX11Compiler.cmake also for MSVC

Am 09.12.2015 um 22:28 schrieb Georg Baum: D:\LyXGit\Master\src\tex2lyx\table.cpp(284): error C3861: 'min': identifier not found This is probably a side effect of less unneeded includes in C++11 mode. std::min is declared in , but table.cpp does not include that header. This is wrong, if it

Re: use FindCXX11Compiler.cmake also for MSVC

Am 08.12.2015 um 23:55 schrieb Kornel Benko: Can you set in development/cmake/modules/FindCXX11Compiler.cmake:93 set(FLAG) instead of set(FLAG "") I tried this but this doesn't make a difference. Also if I comment out the cxx11 part in regex.h the compilation fails as soon

Re: use FindCXX11Compiler.cmake also for MSVC

Am Dienstag, 8. Dezember 2015 um 23:55:02, schrieb Kornel Benko > Am Dienstag, 8. Dezember 2015 um 23:10:21, schrieb Uwe Stöhr > > > Am 08.12.2015 um 08:51 schrieb Kornel Benko: > > > > > I cannot test, since I don't have MSVC. > > > In _my_ implementation of

Re: use FindCXX11Compiler.cmake also for MSVC

Am Dienstag, 8. Dezember 2015 um 23:10:21, schrieb Uwe Stöhr > Am 08.12.2015 um 08:51 schrieb Kornel Benko: > > > I cannot test, since I don't have MSVC. > > In _my_ implementation of cmake modules (cmake 3.4) the MSVC_VERSION is > > defined for MSVC. > > Applying this patch

Re: use FindCXX11Compiler.cmake also for MSVC

Am 08.12.2015 um 08:51 schrieb Kornel Benko: I cannot test, since I don't have MSVC. In _my_ implementation of cmake modules (cmake 3.4) the MSVC_VERSION is defined for MSVC. Applying this patch breaks the compilation. I get the error FATAL_ERROR "A C++11 compatible compiler is required."

use FindCXX11Compiler.cmake also for MSVC

Looking into cmake internal handling of MSVC, maybe this patch should 1.) Unify use of find_package(CXX11Compiler) 2.) Allow using C++11 features for MSVC 3.) using std_regex for MSVC I cannot test, since I don't have MSVC. In _my_ implementation of cmake modules (cmake 3.4) the MSVC_VERSION is