Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread David DeHaven
Updated webrev for JDK (hotspot change is the same): http://cr.openjdk.java.net/~ddehaven/8025673/jdk.1/ Changes since last version: - Moved to jdk8/build/jdk to save someone a merge headache, moved changes to CompileNativeLibs.gmk to libs/Awt2dLibraries.gmk - Removed HToolkit option and toolkit

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread David DeHaven
I want to do one more iteration of this. Based on feedback it seems I can remove a bit more code from java_props_macosx.[ch] and make things a bit cleaner. -DrD- > Thanks guys. > > Anthony, can you sponsor this for me? > > -DrD- > >> This fix looks fine to me as well. >> >> -- >> best rega

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread David DeHaven
Thanks guys. Anthony, can you sponsor this for me? -DrD- > This fix looks fine to me as well. > > -- > best regards, > Anthony > > On 10/20/2013 11:56 PM, David DeHaven wrote: >> >> CCing: build-dev, macosx-port-dev, hotspot-dev >> >> Request for review of JDK-8025673: >> https://bugs.openj

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread Anthony Petrov
This fix looks fine to me as well. -- best regards, Anthony On 10/20/2013 11:56 PM, David DeHaven wrote: CCing: build-dev, macosx-port-dev, hotspot-dev Request for review of JDK-8025673: https://bugs.openjdk.java.net/browse/JDK-8025673 Proposed changes: http://cr.openjdk.java.net/~ddehaven/8

Re: RFR: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-10-21 Thread Anthony Petrov
Hi David, The fix looks fine to me. -- best regards, Anthony On 10/20/2013 11:53 PM, David DeHaven wrote: CCing: build-dev, macosx-port-dev Request for review of JDK-8016096: https://bugs.openjdk.java.net/browse/JDK-8016096 Proposed changes: http://cr.openjdk.java.net/~ddehaven/8016096/ Si

Re: RFR: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-10-21 Thread Artem Ananiev
Hi, David, client (AWT, Java2D) part of the fix looks fine. Thanks, Artem On 10/21/2013 3:53 AM, David DeHaven wrote: CCing: build-dev, macosx-port-dev Request for review of JDK-8016096: https://bugs.openjdk.java.net/browse/JDK-8016096 Proposed changes: http://cr.openjdk.java.net/~ddehaven

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread Artem Ananiev
Hi, David, the changes look fine to me. See more comments below. On 10/21/2013 3:56 AM, David DeHaven wrote: CCing: build-dev, macosx-port-dev, hotspot-dev Request for review of JDK-8025673: https://bugs.openjdk.java.net/browse/JDK-8025673 Proposed changes: http://cr.openjdk.java.net/~ddehav