Re: [8] Review request for 8028212 Custom cursor HiDPI support

2013-12-03 Thread Anthony Petrov
Hi Alexander, If we go with this fix, I suggest to move the CImage.Creator.resizeImageRepresentations() to the CImage class and make it a member method, so that you don't need to pass a CImage reference to it as an argument. Also, there's the CImage.resize() method already. Why does it not w

Re: [8] Review request for 8024926 [macosx] AquaIcon HiDPI support

2013-12-03 Thread Anthony Petrov
Hi Alexander, The Graphics obtained at line 519 in AquaImageFactory.java is never dispose()'d. Other than that, the fix looks good to me (although I'm not an expert in Aqua L&F or HiDPI support code). -- best regards, Anthony On 12/03/2013 08:11 PM, Alexander Scherbatiy wrote: Could y

[8] Review request for 8028212 Custom cursor HiDPI support

2013-12-03 Thread Alexander Scherbatiy
Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8028212 webrev: http://cr.openjdk.java.net/~alexsch/8028212/webrev.00 - MultiResolutionImage interface is used from the fix 8011059 - NSImage with representations are created for the multi-resolution cursor

Re: [8] Review request for 8024926 [macosx] AquaIcon HiDPI support

2013-12-03 Thread Alexander Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8024926/webrev.01/ - MultiResolutionImage interface is used from the fix 8011059 - Only icons with resolution 1x and 2x are created. The real Mac OS X system icon have more resolutions. The full fix requires

Re: [OpenJDK 2D-Dev] [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-12-03 Thread Alexander Scherbatiy
Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8011059/webrev.13/ - observer cache is returned back - resolution variant x/y/width/height are divided by 2 in the observer wrapper On 12/3/2013 1:16 AM, Jim Graham wrote: Hi Alexander, There must have bee