Re: Crashes in Java_sun_lwawt_macosx_LWCToolkit_stopAWTRunLoop (called with NULL argument)

2014-08-29 Thread Anthony Petrov
't have a test app that we could use to reproduce the crash and then confirm whether we've fixed anything or not. -- best regards, Anthony On 8/29/2014 4:45 PM, Hendrik Schreiber wrote: On Aug 28, 2014, at 20:16, Anthony Petrov wrote: JI-9014527 was closed as Incomplete "Not en

Re: Crashes in Java_sun_lwawt_macosx_LWCToolkit_stopAWTRunLoop (called with NULL argument)

2014-08-28 Thread Anthony Petrov
Hi Hendrik, JI-9014527 was closed as Incomplete "Not enough information.", supposedly because there's not a reproducible test case and instructions to reproduce the issue. If you come up with a simple test that crashes easily, we can re-open that bug. BTW, from the full stack trace in the

Re: FW: A small Aqua Swing bug report--how/where to file?

2014-07-14 Thread Anthony Petrov
You can file a new bug at: http://bugreport.java.com/bugreport/ -- best regards, Anthony On 7/11/2014 7:12 PM, Eirik Bakke wrote: (Resending without image attachment--I don't think my first message got through.) I have a small bug to file against the Aqua L&F in OpenJDK. What's the place/proc

Re: Toolkit.sync()

2014-06-26 Thread Anthony Petrov
There's no way to detect this with 100% certainty. On any platform. Toolkit.sync() is harmless and probably worth calling after your final Window.setVisible(true) call. However, this method doesn't do much. There's several workarounds though. You may want to Thread.sleep() for a while (like a

Re: Ugly flashing when opening a css-styled stage

2014-06-02 Thread Anthony Petrov
Hi Robert, Which of the two mailing lists is the more appropriate one to post these things (JFX problems which look like they might be platform-specific) to? FYI: the JDK Mac OS X Port Project has been completed long time ago, so currently the macosx-port-dev@ mailing list isn't appropriate f

Getting Your Java 8 App in the Mac App Store

2014-04-10 Thread Anthony Petrov
This may be of interest for people on this mailing list: http://speling.shemnon.com/blog/2014/04/10/getting-your-java-app-in-the-mac-app-store/ The solution works for both FX and Swing/AWT apps. PS. Originally published on openjfx-...@openjdk.java.net -- best regards, Anthony

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Anthony Petrov
All right, if you say this additional filtering is required for correct results and tests confirm that, let it be. I'm fine with the fix then. -- best regards, Anthony On 3/19/2014 11:29 PM, Sergey Bylokhov wrote: On 3/19/14 10:43 PM, Anthony Petrov wrote: Why would there be a regre

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Anthony Petrov
functions return all the mirrored displays. And again, there wouldn't be a regression from just using another function. Please clarify what regression you're talking about. -- best regards, Anthony On 3/19/2014 10:02 PM, Sergey Bylokhov wrote: On 3/19/14 9:35 PM, Anthony Petrov wrote

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Anthony Petrov
Hi Sergey, Generally the fix looks good. I have only two concerns: 1. Previously we didn't exclude mirrored displays from the list. So the new code that you're adding at lines 84-92 might be better integrated as a separate fix. 2. Before the fix, the list of display devices returned from ge

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Anthony Petrov
On 3/19/2014 9:29 PM, Sergey Bylokhov wrote: On 3/19/14 9:20 PM, Anthony Petrov wrote: 1. Previously we didn't exclude mirrored displays from the list. So the new code that you're adding at lines 84-92 might be better integrated as a separate fix. Before the fix we use CGGetActiveD

Re: On OSX with Editable combo box the button is not aligned correctly with the combobox field

2013-12-13 Thread Anthony Petrov
Thanks. -- best regards, Anthony On 12/13/2013 03:49 PM, Paul Taylor wrote: On 12/12/2013 20:39, Anthony Petrov wrote: Hi Paul, Can you please file bugs at http://bugs.sun.com/ for all the issues that you encounter? Okay, Ive submitted bug reports for the editablecombo, and Apple menu bar

Re: On OSX with Editable combo box the button is not aligned correctly with the combobox field

2013-12-12 Thread Anthony Petrov
Hi Paul, Can you please file bugs at http://bugs.sun.com/ for all the issues that you encounter? -- best regards, Anthony On 12/13/2013 12:12 AM, Paul Taylor wrote: With Editable combo box the button is not aligned correctly with the combobox field, at least I don't think so I'm struggling t

Re: [8] Review request for 8024926 [macosx] AquaIcon HiDPI support

2013-12-05 Thread Anthony Petrov
in the AquaImageFactory.MultiResolutionIconImage constructor Thanks, Alexandr. On 12/3/2013 8:39 PM, Anthony Petrov wrote: Hi Alexander, The Graphics obtained at line 519 in AquaImageFactory.java is never dispose()'d. Other than that, the fix looks good to me (although I'm not an

Re: [8] Review request for 8028212 Custom cursor HiDPI support

2013-12-05 Thread Anthony Petrov
:24 PM, Anthony Petrov wrote: Thanks for the update, Alexander. I understand. So, my only concerns that remain are: 1. The membership of the resizeImageRepresentations() method. 2. The encapsulation of the logic handling the Image/MultiResolutionImage case (see at the bottom of my original message

Re: [8] Review request for 8028212 Custom cursor HiDPI support

2013-12-04 Thread Anthony Petrov
, Anthony On 12/04/2013 06:59 PM, Alexander Scherbatiy wrote: On 12/3/2013 9:06 PM, Anthony Petrov wrote: Hi Alexander, If we go with this fix, I suggest to move the CImage.Creator.resizeImageRepresentations() to the CImage class and make it a member method, so that you don't need to pass a C

Re: [8] Review request for 8028212 Custom cursor HiDPI support

2013-12-03 Thread Anthony Petrov
Hi Alexander, If we go with this fix, I suggest to move the CImage.Creator.resizeImageRepresentations() to the CImage class and make it a member method, so that you don't need to pass a CImage reference to it as an argument. Also, there's the CImage.resize() method already. Why does it not w

Re: [8] Review request for 8024926 [macosx] AquaIcon HiDPI support

2013-12-03 Thread Anthony Petrov
Hi Alexander, The Graphics obtained at line 519 in AquaImageFactory.java is never dispose()'d. Other than that, the fix looks good to me (although I'm not an expert in Aqua L&F or HiDPI support code). -- best regards, Anthony On 12/03/2013 08:11 PM, Alexander Scherbatiy wrote: Could y

Re: [8] Review request for 8013581: [macosx] Key Bindings break with awt GraphicsEnvironment setFullScreenWindow

2013-10-28 Thread Anthony Petrov
Hi Leonid, The fix looks somewhat risky so late in the release. But I talked with Sergey and I see that it resolves a lot of real problems. So I'm sort of OK with it. A few comments: src/macosx/native/sun/awt/AWTWindow.m 255 self.preFullScreenLevel = [self.nsWindow level]; The alwaysO

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-22 Thread Anthony Petrov
"true" headless mode via ssh(w/o headless option and w/o access to Aqua session). On 22.10.2013 21:54, Anthony Petrov wrote: We don't have to. IIRC, the choice of HToolkit on Mac was made by chance. Since we must load the lwawt lib in headless on Mac anyway, we may as well us

Re: Crash on startup in SnowLeopard 1.7.0_45

2013-10-22 Thread Anthony Petrov
http://www.java.com/en/download/help/sysreq.xml Mac OS X Intel-based Mac running Mac OS X 10.7.3 (Lion) or later. So, 10.6.8 is simply unsupported. Please consider upgrading your OS. -- best regards, Anthony On 10/22/2013 08:27 PM, Steve Hannah wrote: I have an app that is bundled using ap

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-22 Thread Anthony Petrov
We don't have to. IIRC, the choice of HToolkit on Mac was made by chance. Since we must load the lwawt lib in headless on Mac anyway, we may as well use the CToolkit (properly wrapped in the HeadlessToolkit). But there's no need to continue to use the HToolkit on Mac. -- best regards, Anthony

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-22 Thread Anthony Petrov
Artem is correct. On Mac we can't start a GUI session via ssh, for example. Thus we choose the headless mode then. The isInAquaSession() is supposed to perform exactly this check. This logic needs to be preserved. -- best regards, Anthony On 10/22/2013 01:23 PM, Artem Ananiev wrote: Hi, David

Re: RFR: 8025673: Disable X11 AWT toolkit

2013-10-21 Thread Anthony Petrov
This fix looks fine to me as well. -- best regards, Anthony On 10/20/2013 11:56 PM, David DeHaven wrote: CCing: build-dev, macosx-port-dev, hotspot-dev Request for review of JDK-8025673: https://bugs.openjdk.java.net/browse/JDK-8025673 Proposed changes: http://cr.openjdk.java.net/~ddehaven/8

Re: RFR: 8016096: [macosx] jawt_md.h shipped with jdk is outdated

2013-10-21 Thread Anthony Petrov
Hi David, The fix looks fine to me. -- best regards, Anthony On 10/20/2013 11:53 PM, David DeHaven wrote: CCing: build-dev, macosx-port-dev Request for review of JDK-8016096: https://bugs.openjdk.java.net/browse/JDK-8016096 Proposed changes: http://cr.openjdk.java.net/~ddehaven/8016096/ Si

Re: Does Java 7 port support the apple.awt-use-dialog-packages system property

2013-10-18 Thread Anthony Petrov
On 10/18/2013 05:26 PM, Paul Taylor wrote: On 18/10/2013 14:02, Anthony Petrov wrote: Hi Paul, I've just filed this issue for you: https://bugs.openjdk.java.net/browse/JDK-8026869 It is currently targeted for JDK 9. After it's fixed in the mainline, we can consider porting the fix

Re: Does Java 7 port support the apple.awt-use-dialog-packages system property

2013-10-18 Thread Anthony Petrov
Hi Paul, I've just filed this issue for you: https://bugs.openjdk.java.net/browse/JDK-8026869 It is currently targeted for JDK 9. After it's fixed in the mainline, we can consider porting the fix to 8- and 7-update releases. -- best regards, Anthony On 10/18/2013 01:51 PM, Paul Taylor wrote

Re: Does Java 7 port support the apple.awt-use-dialog-packages system property

2013-10-17 Thread Anthony Petrov
Hi Paul, Apparently not: $ grep -r "awt-use-file-dialog-packages" jdk/src/* | wc -l 0 Your best bet is to file an RFE at http://bugs.sun.com/ -- best regards, Anthony On 10/17/2013 11:27 PM, Paul Taylor wrote: Im trying to port an application from Java 6 to Java 7 on Mac does Java 1.7.0_40-b