Re: apple.security.KeychainStore does not load private key (when called from javaws)

2014-07-29 Thread Petr Pchelko
Added security-dev. With best regards. Petr. > On Jul 29, 2014, at 12:36 PM, Florian Bruckner (3kraft) > wrote: > > Hey guys, > > any feedback on this? > > What is the process to have a patch like this accepted? > > regards, > > Florian > > On 15.07.14 10:56, Florian Bruckner (3kraft) wro

Re: IllegalArgumentException on Toolkit.getDefaultToolkit().getSystemClipboard().getContents(null)

2014-07-23 Thread Petr Pchelko
Hello, Hendrik. Interesting, because there was a similar problem that’s been fixed in 7u60 and 8: https://bugs.openjdk.java.net/browse/JDK-7173464 I’ll have a look at this, thank you for your report. With best regards. Petr. > On Jul 23, 2014, at 9:32 PM, Hendrik Schreiber wrote: > > Hi, >

Re: New button styles in Yosemite

2014-07-20 Thread Petr Pchelko
Hello, Hendrik. > Yosemite seems to offer some new button styles, e.g. in Finder. Yosemite is completely redesigned and it's not limited only to new button styles. Most of the controls are redesigned. > Is this on your radar? We are looking at this and thinking what can be done here. With bes

Re: HiDPI/Retina support for -splash option

2014-05-23 Thread Petr Pchelko
> But isnt there a much larger problem, the -splash option still broken only > to be fixed in https://bugs.openjdk.java.net/browse/JDK-8024185. To clarify > using the splash option will prevent my main application from working. This fix was integrated in JDK-9 long time ago and didn’t cause any

Re: [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

2014-05-21 Thread Petr Pchelko
er is called at least > once. > > Thanks, > Alexandr. > > On 5/21/2014 2:50 PM, Alexander Scherbatiy wrote: >> >> Could you review the updated fix: >> http://cr.openjdk.java.net/~alexsch/8040291/webrev.02/ >> >> - The isRVObserevr typo is fixed

Re: [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

2014-05-20 Thread Petr Pchelko
. With best regards. Petr. On May 20, 2014, at 7:07 PM, Alexander Scherbatiy wrote: > > Could you review the updated fix: > http://cr.openjdk.java.net/~alexsch/8040291/webrev.01 > > - The getRVSize() method from the SunToolkit is fixed > > On 5/20/2014 6:46 PM, Petr P

Re: [9] Review request for 8040291 [macosx] Http-Images are not fully loaded when using ImageIcon

2014-05-20 Thread Petr Pchelko
Hello, Alexander. SunToolkit:876 size == -1 ? -1 : size What’s going on here? Isn’t this equal to just size? I believe is’t wrong and the size should be multiplied by 2 somewhere? If the method is wrong how does the test pass? With best regards. Petr. On May 20, 2014, at 6:32 PM, Alexander S

Re: HTML tooltip in native Mac menu?

2014-04-21 Thread Petr Pchelko
Hello, Jörn. Looks like this feature can not be implemented in screen menu bar. Screen menu bar is implemented on top of the Cocoa menu API, but it does seem to support rich text in menu tooltips. With best regards. Petr. On 21.04.2014, at 16:59, Jörn Huxhorn wrote: > I just realized that a

Re: [9] Review request for 8040279 [macosx] Do not use the base image in the MultiResolutionBufferedImage constructor

2014-04-21 Thread Petr Pchelko
e in the CImage class. > > Thanks, > Alexandr. > > On 4/21/2014 2:36 PM, Petr Pchelko wrote: >> Hello, Alexander. >> >> Just one minor comment: In CImage createBufferedImage method does not create >> a BufferredImage any more, so it worths renaming. >>

Re: [9] Review request for 8040279 [macosx] Do not use the base image in the MultiResolutionBufferedImage constructor

2014-04-21 Thread Petr Pchelko
Hello, Alexander. Just one minor comment: In CImage createBufferedImage method does not create a BufferredImage any more, so it worths renaming. With best regards. Petr. On 15.04.2014, at 18:36, Alexander Scherbatiy wrote: > > Hello, > > Could you review the fix: > bug: https://bugs.openj

Re: Mac OS X JVMCapabilities

2014-04-11 Thread Petr Pchelko
Hello, David. A better alias to ask this is a macosx port alias. Could you please clarify your question: Are you using a native bundle? Are you writing a UI application? How do you get an Info.plist you talk about? just JDK has no info.plist.. With best regards. Petr. 11 апр. 2014 г., в 5:50 по

Re: [9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

2014-04-08 Thread Petr Pchelko
citly implements Icon interface now > - getOptimizedImage() method is removed from the CachingScalingIcon because > NSImage always scales an image to the requested size > - @Override annotation is added. > > Thanks, > Alexandr. > > On 4/2/2014 4:37 PM, Petr Pchelko

Re: [9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

2014-04-02 Thread Petr Pchelko
Hello, Alexander. Could you please add the @Override to the paintIcon method. Also I suggest to reuse the paintIcon in the createIcon. With best regards. Petr. On 02.04.2014, at 16:20, Alexander Scherbatiy wrote: > > Hello, > > Could you review the updated fix: >http://cr.openjdk.ja

Re: [9] Review Request: 8029196 Focus border of JButton.buttonType=roundRect is cut off

2014-04-01 Thread Petr Pchelko
Hello, Sergey. Thank you for the clarification. I was worried because the focus size is hard-coded. The fix looks good to me. With best regards. Petr. On 01.04.2014, at 16:53, Sergey Bylokhov wrote: > On 4/1/14 4:33 PM, Petr Pchelko wrote: >> Hello, Sergey. >> >>

Re: [9] Review Request: 8029196 Focus border of JButton.buttonType=roundRect is cut off

2014-04-01 Thread Petr Pchelko
Hello, Sergey. Does the fix work for retina thin focuses and non-retina thick? With best regards. Petr. On 01.04.2014, at 15:46, Sergey Bylokhov wrote: > Hello. > Please review the fix for jdk 9. > JRS draws all component in specified bounds, but if a component is in focus, > the frame of foc

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

2014-03-28 Thread Petr Pchelko
Still Looks good. With best regards. Petr. On 28.03.2014, at 18:01, Sergey Bylokhov wrote: > Hi, Alexander. > The fix looks good. > > On 3/28/14 4:43 PM, Alexander Scherbatiy wrote: >> >> Hello, >> >> Could you review the updated fix: >>http://cr.openjdk.java.net/~alexsch/8032667/webrev

Re: [9] Review request for 8036882 [macosx] Native memory leak in Java_sun_lwawt_macosx_CImage_nativeGetNSImageRepresentationSizes

2014-03-27 Thread Petr Pchelko
Hello, Alexander. The fix looks good to me. With best regards. Petr. 27 марта 2014 г., в 7:49 после полудня, Alexander Scherbatiy написал(а): > > Hello, > > Could you review the fix: > bug: https://bugs.openjdk.java.net/browse/JDK-8036882 > webrev: http://cr.openjdk.java.net/~alexsch/8036

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

2014-03-26 Thread Petr Pchelko
Hello, Alexander. The fix looks good to me too. With best regards. Petr. On 26.03.2014, at 17:54, Sergey Bylokhov wrote: > Hi, Alexander. > The fix looks fine to me. Probably the test can be automated? before the fix > COMP->imagex1->imagex2 and the COMP->imagex2 should be the same, and afte

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Petr Pchelko
It’s 10.9 - specific, so I could check this as soon as I bring a miniDP adaptor home. With best regards. Petr. 20 марта 2014 г., в 1:51 до полудня, Sergey Bylokhov написал(а): > On 3/19/14 11:50 PM, Petr Pchelko wrote: >> Hello, Sergey. >> >> After Anthony have a

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Petr Pchelko
Hello, Sergey. After Anthony have asked all the possible questions I’m left with the only option: The fix looks good to me. BTW: I see that there’s one more bug in this method: https://bugs.openjdk.java.net/browse/JDK-8036927 Is it also resolved by this fix? With best regards. Petr. 19 марта

Re: [9] Review request for 8035069 [macosx] Loading resolution variants by demand

2014-03-14 Thread Petr Pchelko
t; > On 3/13/2014 12:21 PM, Petr Pchelko wrote: >> Hello, Alexander. >> >> 1. As Sergey always says, could you please split the long lines. >> 2. Instead of the MultiResolutionImageMapper you could use a >> BiFunction >> 3. About the ImageCache. As it's u

Re: [9] Review request for 8035069 [macosx] Loading resolution variants by demand

2014-03-13 Thread Petr Pchelko
Hello, Alexander. 1. As Sergey always says, could you please split the long lines. 2. Instead of the MultiResolutionImageMapper you could use a BiFunction 3. About the ImageCache. As it's uses an AppContext, could you please mention in the JavaDoc that is must be used from the thread with an AppC

Re: [9] Review request for 8036598 [macosx] Create AquaIcons from image representations

2014-03-04 Thread Petr Pchelko
Hello, Alexander. I've been also looking around this code and I have a related question: when we call getThisApplicationsIcon we are drawing the Dock icon on top of a multi-resolution background image. However as I see, the dock icon image created with getThisApplicationsIcon and getGenericJav

Re: [9] Review request for 8033534 Get MultiResolution image from native system

2014-03-04 Thread Petr Pchelko
regards. Petr. On 04.03.2014, at 15:39, Alexander Scherbatiy wrote: > On 3/4/2014 3:30 PM, Petr Pchelko wrote: >> Hello, Alexander. >> >> In CImage.m:430 - Do we really want to describe and clear the exception? >> May be it's better to simply return NULL and let Ja

Re: [9] Review request for 8033534 Get MultiResolution image from native system

2014-03-04 Thread Petr Pchelko
pect from the SetObjectArrayElement and why we continue >> in this case? >> Also please split soo long lines in these files. >> >> On 2/26/14 6:40 PM, Alexander Scherbatiy wrote: >>> >>> Hello, >>> >>> Could you review the upda

Re: [9] Review request for 8033534 Get MultiResolution image from native system

2014-02-26 Thread Petr Pchelko
Hello, Alexander. The fix look good to me. With best regards. Petr. 26 февр. 2014 г., в 6:40 после полудня, Alexander Scherbatiy написал(а): > > Hello, > > Could you review the updated fix: > http://cr.openjdk.java.net/~alexsch/8033534/webrev.03/ > > On 2/

Re: [9] Review request for 8033534 Get MultiResolution image from native system

2014-02-26 Thread Petr Pchelko
Hello, Alexander. I have a couple of comments: 1. You could replace the first loop with indexOfObjectPassingTest method.. Not sure if this would look cleaner, up to you. 2. I suppose JNFNewObjectArray could throw the OOM and we would get a parfait warning, could you please add CHECK_NULL_RETU

Re: [9] Review request for 8031573 [macosx] Checkmarks of JCheckBoxMenuItems aren't rendered in high resolution on Retina

2014-02-24 Thread Petr Pchelko
Hello, Alexander. The fix looks good to me. With best regards. Petr. On 18.02.2014, at 16:20, Sergey Bylokhov wrote: > Hi, Alexander. > The fix looks good then. > > On 17.02.2014 18:38, Alexander Scherbatiy wrote: >> On 2/14/2014 3:16 PM, Sergey Bylokhov wrote: >>> On 2/14/14 2:32 PM, Alexand

Re: Java 7 application halting OSX when left unatteended

2014-01-31 Thread Petr Pchelko
Hello, Paul. Is this issue specific to Mavericks or it is also reproducible on 10.8? Could you please provide some test case to reproduce? Or any Swing based application with some background task would work? Thank you. With best regards. Petr. 31 янв. 2014 г., в 2:47 после полудня, Paul Taylor

Re: JFrame.setResizable(false) brings unexpected behaviour in j2sdk 8

2014-01-23 Thread Petr Pchelko
Hello, Yes, this indeed is a regression in JDK 8. I’ve created an issue for you: https://bugs.openjdk.java.net/browse/JDK-8032595 Thank you for reporting this problem. With best regards. Petr. 21 янв. 2014 г., в 6:22 до полудня, niagarasoft20-macosxport...@yahoo.com написал(а): > import javax

Re: Dragging an image from Webpage within Firefox no longer provides it as DataFlavour java.net.URL/java.util.List on OSX with Java 7

2014-01-15 Thread Petr Pchelko
thank you for noticing that something is wrong with the Finder. I think I know the reason, but anyway I've filed https://bugs.openjdk.java.net/browse/JDK-8031965 With best regards. Petr. On 15.01.2014, at 17:31, Hendrik Schreiber wrote: > On Jan 13, 2014, at 18:36, Petr Pchelko wr

Re: Dragging an image from Webpage within Firefox no longer provides it as DataFlavour java.net.URL/java.util.List on OSX with Java 7

2014-01-13 Thread Petr Pchelko
Hello, Hendrik. > I just tried that as well: no difference :-( We’ve had numerous regression in datatransfer area in JDK-8 but wight now they should all be fixed. However the URI transfer on Mac OS X still does not work in some cases, it’s simply not implemented. I have a related issue: http

Re: Using the Apple menu (Apple.laf.useScreenMenuBar) the menu items are always in English whatever set as Preferred Language

2013-12-25 Thread Petr Pchelko
дек. 2013 г., в 10:23 после полудня, Paul Taylor написал(а): > On 25/12/2013 13:26, Petr Pchelko wrote: >> Hello, Paul. >> >> Sorry for the delayed answer. >> >> The problem is that we are relying on Cocoa to create these menu items. >> However, to pro

Re: Using the Apple menu (Apple.laf.useScreenMenuBar) the menu items are always in English whatever set as Preferred Language

2013-12-25 Thread Petr Pchelko
Hello, Paul. Sorry for the delayed answer. The problem is that we are relying on Cocoa to create these menu items. However, to properly understand the locale Cocoa needs a special key in the Info.plist file (CFBundleAllowMixedLocalizations). However when you are running a java application as j

Re: Dragging an image from firefox browser works but not Google Chrome with Java 7

2013-12-10 Thread Petr Pchelko
Hello, Paul. Looks like the bug is indeed reproducible on 7u45, however my testing shows that JDK-8 works well. Could you please check your test case on JDK 8? It could be downloaded here: https://jdk8.java.net/download.html Thank you. With best regards. Petr. On 10.12.2013, at 17:41, Paul Tay

Re: Java 7 Application freeze at sun.lwawt.macosx.CCursorManager.nativeGetCursorPosition

2013-11-18 Thread Petr Pchelko
Hello, Viral. It's known that there are some deadlocks in SWT_AWT bridge on Mac. Here's an example: https://bugs.openjdk.java.net/browse/JDK-8020165 It would be useful if you also post the dump of an Appkit thread to identify your particular case. The deadlock occurs because AWT is called on t