Re: CFV: Dissolve the Mac OS X Port Project

2020-01-22 Thread Sergey Bylokhov
Vote: Yes On 1/22/20 10:47 am, Phil Race wrote: According to section 6 of the bylaws [1], the Committers of a Project may decide, by Lazy Consensus, to request that a Project should be dissolved. When a Project is dissolved its materials are archived. A dissolved Project may be re-created by

Re: JDK-8220154 Improve java2d rendering performance on macOS by using Metal framework

2019-03-05 Thread Sergey Bylokhov
Hi, Alexey. You are welcome! I know that one of the goal of this work is to improve the performance of 2d pipeline, did you try to drop the usage of the RenderQueue? I guess metal could be used from the different threads. Also did you try to compare stuff currently implemented in metal to the

Re: RFR: 8211962: Implicit narrowing in MacOSX java.desktop jsound

2018-10-10 Thread Sergey Bylokhov
Looks fine. On 09/10/2018 18:23, Kim Barrett wrote: Please review this trivial fix of a build failure on MacOSX when compiling with C++11/14 enabled. An int value is being used in an initializer where an unsigned int is needed, which is not permitted since C++11. The solution taken is to cast

Re: printing from the mac sandbox

2017-06-01 Thread Sergey Bylokhov
Hi, Sean. The correct mailing list for discussion of such issues is: 2d-dev (cc). - srei...@seanreilly.com wrote: > There seems to be a big printing problem using recent JDKs when > running within the macOS sandbox as of 10.12.4. > > Looking at the jdk8 sources, CUPSfuncs.c seems to ignore

Re: JScrollPane jitter during trackpad scrolling on MacOS/Aqua

2016-01-20 Thread Sergey Bylokhov
ser plenty of wiggle room. You can never scroll truly diagonally except by zig-zaging. Not sure but personally I like the possibility to scroll diagonally w/o zig-zaging when two scrolls are visible. -- Eirik On 1/19/16, 11:50 AM, "Sergey Bylokhov" <sergey.bylok...@oracle.c

Re: JScrollPane jitter during trackpad scrolling on MacOS/Aqua

2016-01-19 Thread Sergey Bylokhov
I am not sure that this is regression or a bug. In your case you scroll from left-down to right-up. But left-to-right is a scroll to up, and down-to-up is a scroll to down. So you scroll in both direction at the same time. On 19/01/16 19:18, Eirik Bakke wrote: Hi, macos-port-dev. Here's

Re: java2d performance java7 / java8

2015-02-17 Thread Sergey Bylokhov
Hello, Thanks for the provided info! I am able to reproduce this bug even on windows: gdi vs ogl. I will take a look at it. On 12.02.2015 8:28, DRC wrote: On 2/10/15 7:52 AM, Sergey Bylokhov wrote: You can run this test on jdk 8u31 and 8u40 to see a difference: http://cr.openjdk.java.net

Re: java2d performance java7 / java8

2015-02-10 Thread Sergey Bylokhov
On 10.02.2015 5:26, DRC wrote: You're missing my point. ARGB_PRE images are faster with OpenGL but not as fast with other blitters, so currently in order to achieve optimal performance, my program has to somehow predict when OpenGL blitting will be used and use an ARGB_PRE image only in those

Re: java2d performance java7 / java8

2015-02-09 Thread Sergey Bylokhov
Hello, Yes you are right, in the opengl pipeline usage of ARGB_PRE is preferable, but other pipelines can use different formats. So it is better to use GraphicsConfiguration.createCompatibleImage()

Re: HiDPI Scaling - OSX vs Windows

2014-05-28 Thread Sergey Bylokhov
Hi, Hendrik. The logic of how it should be implemented/updated still under discussion. So if you have some broken use-cases or you have to use some hacks, I suggest to file a new bugs. On 5/28/14 6:58 PM, Hendrik Schreiber wrote: On May 28, 2014, at 3:48, Richard Moir rich...@biomatters.com

Re: [9] Review request for 8038113 [macosx] JTree icon is not rendered in high resolution on Retina

2014-04-09 Thread Sergey Bylokhov
Hi, Alexander. The fix looks good. But can you remove the text in Quartz from the comments before the push. Thanks. On 4/7/14 7:30 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8038113/webrev.02 - CachableJRSUIIcon

[9] Review Request: 8029196 Focus border of JButton.buttonType=roundRect is cut off

2014-04-01 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. JRS draws all component in specified bounds, but if a component is in focus, the frame of focus can exceed the limit of the specified bounds. The focusable components take this into account in the insets, but we cut the focus anyway, because we create the

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

2014-03-28 Thread Sergey Bylokhov
- 2x image gives different result. Thanks, Alexandr. On 3/26/2014 5:54 PM, Sergey Bylokhov wrote: Hi, Alexander. The fix looks fine to me. Probably the test can be automated? before the fix COMP-imagex1-imagex2 and the COMP-imagex2 should be the same, and after the fix it should

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

2014-03-26 Thread Sergey Bylokhov
scaling - Bounds are used in the key instead of the scale factor. Thanks, Alexandr. On 3/25/2014 8:26 PM, Sergey Bylokhov wrote: Hello, Alexander. You cannot skip scalfactor as a key, because images with different scale are different. On 3/25/14 8:10 PM, Alexander Scherbatiy wrote

Re: [9] Review request for 8032667 [macosx] Components cannot be rendered in HiDPI to BufferedImage

2014-03-26 Thread Sergey Bylokhov
to the constructor. Thanks, Alexandr. On 3/26/2014 4:30 PM, Sergey Bylokhov wrote: Hello, Alexander. I think it will not work if the user set scale=1.5? On 3/26/14 4:18 PM, Alexander Scherbatiy wrote: Hello, Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8032667/webrev

[9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Sergey Bylokhov
Hello. Please review the fix for jdk 9. After the fix we use screen in sleep state as normal screen, where we can create new windows, etc. Disadvantage is that Robot still does not work on such devices. Bug: https://bugs.openjdk.java.net/browse/JDK-7124417 Webrev can be found at:

Re: [9] Review Request: 7124417 [macosx] failure in Window.initGC on Mac with monitor sleeping

2014-03-19 Thread Sergey Bylokhov
results and tests confirm that, let it be. I'm fine with the fix then. -- best regards, Anthony On 3/19/2014 11:29 PM, Sergey Bylokhov wrote: On 3/19/14 10:43 PM, Anthony Petrov wrote: Why would there be a regression? Displays using hardware mirroring are never included in the list by either

Re: [9] Review request for 8035069 [macosx] Loading resolution variants by demand

2014-03-17 Thread Sergey Bylokhov
Hello, Alexander. The fix looks good to me too. Thanks! On 3/14/14 10:38 PM, Petr Pchelko wrote: Hello, Alexander. The updated version of the fix looks good to me. With best regards. Petr. 14 марта 2014 г., в 7:53 после полудня, Alexander Scherbatiy alexandr.scherba...@oracle.com

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-03-04 Thread Sergey Bylokhov
. I updated the exception handling to return NULL if an exception occurs. Thanks, Alexandr. On 3/3/2014 11:48 PM, Sergey Bylokhov wrote: Hi, Alexander. nativeGetNSImageRepresentationsCount three times return different values in case of error (0, NULL, nil). What exception we expect from

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-03-04 Thread Sergey Bylokhov
. Thanks. The fix looks good. Thanks, Alexandr. On 3/4/2014 4:12 PM, Sergey Bylokhov wrote: On 3/4/14 3:53 PM, Petr Pchelko wrote: I'm fine with the fix. Hello, Alexander. In CImage.m:430 - Do we really want to describe and clear the exception? May be it's better to simply return NULL

Re: [9] Review request for 8036598 [macosx] Create AquaIcons from image representations

2014-03-04 Thread Sergey Bylokhov
Hi, Alexander. I have only two suggestions about MultiResolutionBufferedImage - It could be final and its fields can be private final. - .toArray(length - new Image[length])); can be replaced .toArray(Image[]::new)); On 3/4/14 5:32 PM, Alexander Scherbatiy wrote: Hello, Could you review

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-03-03 Thread Sergey Bylokhov
. On 2/4/2014 5:00 PM, Sergey Bylokhov wrote: Hi, Alexander. I think that getResolutionVariant should return an image which is close as much as possible to the requested size. On 04.02.2014 16:42, Alexander Scherbatiy wrote: Hello

Re: Horizontal scrolling in JScrollpad using trackpad

2014-02-26 Thread Sergey Bylokhov
Hi, Robert. What LF do you use? It should work under the Aqua LF. On 26.02.2014 12:39, Robert Krüger wrote: Hi, the default behaviour for JScrollPane seems to be that a two-finger drag always only scrolls vertically. This must be something someone has solved before or is this a limitation/bug

Re: [9] Review request for 8031573 [macosx] Checkmarks of JCheckBoxMenuItems aren't rendered in high resolution on Retina

2014-02-18 Thread Sergey Bylokhov
Hi, Alexander. The fix looks good then. On 17.02.2014 18:38, Alexander Scherbatiy wrote: On 2/14/2014 3:16 PM, Sergey Bylokhov wrote: On 2/14/14 2:32 PM, Alexander Scherbatiy wrote: On 2/14/2014 2:12 AM, Sergey Bylokhov wrote: Hi, Alexander. Did you check option of loading of the picture

Re: White flashing when opening Dialogs, Menus etc.

2014-02-05 Thread Sergey Bylokhov
Hi, Robert. This is unknown issue. Please file a new bug at http://bugreport.sun.com/bugreport Thanks! On 05.02.2014 19:01, Robert Krüger wrote: This is a simple test case for you to reproduce the flashing for opening a Dialog. It's basically the same for JMenus. import javax.swing.JButton;

Re: AWT Dev [9] Review request for 8033534 Get MultiResolution image from native system

2014-02-04 Thread Sergey Bylokhov
Hi, Alexander. I think that getResolutionVariant should return an image which is close as much as possible to the requested size. On 04.02.2014 16:42, Alexander Scherbatiy wrote: Hello, Could you review the fix: bug: https://bugs.openjdk.java.net/browse/JDK-8033534 webrev:

Re: Focus border of JButton.buttonType=roundRect is cut off

2013-11-25 Thread Sergey Bylokhov
Hi, Hendrik. Looks like the similar issue was fixed for textured buttons: https://bugs.openjdk.java.net/browse/JDK-8000435 It would be good if you create a new issue. Thanks! On 25.11.2013 12:52, Hendrik Schreiber wrote: Hi, the focus border of a roundRect JButton (as originally defined in

Re: AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-13 Thread Sergey Bylokhov
Hello, Jim. On 13.11.2013 22:49, Jim Graham wrote: That's could be a problem. Is it possible to wrap imageObserver, which was passed to the drawImage, and replace one image to another in the WrapperImageObserver.imageUpdate()? It's possible - the things to watch out for: - they could hand

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-07 Thread Sergey Bylokhov
On 07.11.2013 11:01, Jim Graham wrote: On 11/6/13 6:15 PM, Sergey Bylokhov wrote: In this example there is a problem. For example we have 2 BufferedImages/ToolkiImagest A and B; Both wants be scaled perfectly. - Image A draws to the image B - Image B draws to the window. When window