Re: [116514] trunk/base/src

2014-02-08 Thread Rainer Müller
On 2014-02-07 22:28, Christopher Jones wrote: >> of course, you are right, it should be changed to -if {$macosx_version == "10.5"} { +if {$macosx_version eq "10.5"} { >> >> Nonetheless: http://trac.macports.org/changeset/116781. > > Th change to trunk/ba

Re: [116514] trunk/base/src

2014-02-07 Thread Christopher Jones
> >>> of course, you are right, it should be changed to >>> >>> -if {$macosx_version == "10.5"} { >>> +if {$macosx_version eq "10.5"} { > > Nonetheless: http://trac.macports.org/changeset/116781. Th change to trunk/base/src/port1.0/portstartupitem.tcl looks suspicious -

Re: [116514] trunk/base/src

2014-02-07 Thread Clemens Lang
Hi, > > of course, you are right, it should be changed to > > > > -if {$macosx_version == "10.5"} { > > +if {$macosx_version eq "10.5"} { Nonetheless: http://trac.macports.org/changeset/116781. -- Clemens Lang ___ macports-dev

Re: [116514] trunk/base/src

2014-02-06 Thread Ryan Schmidt
On Feb 6, 2014, at 05:49, Gustaf Neumann wrote: > of course, you are right, it should be changed to > > -if {$macosx_version == "10.5"} { > +if {$macosx_version eq "10.5"} { > > > adding/removing quotes does not change the semantics. > > % expr 10.10 == "10.1" > 1 > %

Re: [116514] trunk/base/src

2014-02-06 Thread Gustaf Neumann
of course, you are right, it should be changed to -if {$macosx_version == "10.5"} { +if {$macosx_version eq "10.5"} { adding/removing quotes does not change the semantics. % expr 10.10 == "10.1" 1 % expr 10.10 eq "10.1" 0 although it will take a while until we hav

Re: [116514] trunk/base/src

2014-02-06 Thread Ryan Schmidt
On Jan 27, 2014, at 09:23, c...@macports.org wrote: > Revision > 116514 > Author > c...@macports.org > Date > 2014-01-27 07:23:40 -0800 (Mon, 27 Jan 2014) > Log Message > > base/src: further Tcl cleanup, by courtesy of Gustaf Neumann, Tcl8.4-clean > -if {${macports::macosx_ve

Re: [116514] trunk/base/src

2014-01-27 Thread Gustaf Neumann
dear all, i am afraid, that i am responsible for this bug, i was too eager in bracing expressions. Anyhow, unless i am missing something essential, i would recommend to simplify the construct for "const" and to drop the helper proc "_const" in proc const {name args} { interp alias {} $na

Re: [116514] trunk/base/src

2014-01-27 Thread Clemens Lang
On Tue, Jan 28, 2014 at 03:20:55AM +1100, Joshua Root wrote: > This doesn't look right. I would think the purpose of the expr here is > to do constant folding, so if you do > > const FOO 2+2 > > then [FOO] would return 4. But with the added braces it returns "2+2". You're right. Even though we n

[116514] trunk/base/src

2014-01-27 Thread Joshua Root
> Modified: trunk/base/src/port/port.tcl > === > --- trunk/base/src/port/port.tcl 2014-01-27 15:18:28 UTC (rev 116513) > +++ trunk/base/src/port/port.tcl 2014-01-27 15:23:40 UTC (rev 116514) > @@ -142,7 +142,7 @@ > # @param