Re: [123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

2014-08-10 Thread Ryan Schmidt
On Aug 9, 2014, at 8:31 PM, Joshua Root j...@macports.org wrote: On 2014-8-10 04:07 , Lawrence Velázquez wrote: On Aug 9, 2014, at 11:47 AM, Frank Schima m...@macports.org wrote: Just curious about why you are removing the indenting spacing in these perl ports? I would say it is more

Re: [123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

2014-08-09 Thread Frank Schima
Modified: trunk/dports/perl/p5-email-mime-contenttype/Portfile (123422 = 123423) --- trunk/dports/perl/p5-email-mime-contenttype/Portfile 2014-08-09 10:46:40 UTC (rev 123422) +++ trunk/dports/perl/p5-email-mime-contenttype/Portfile 2014-08-09 10:49:13 UTC (rev 123423

Re: [123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

2014-08-09 Thread Lawrence Velázquez
On Aug 9, 2014, at 11:47 AM, Frank Schima m...@macports.org wrote: Just curious about why you are removing the indenting spacing in these perl ports? I would say it is more common to indent in blocks. I’m open to a discussion about what is preferred. I know when I edit p5 and other ports, I

Re: [123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

2014-08-09 Thread Frank Schima
On Aug 9, 2014, at 12:07 PM, Lawrence Velázquez lar...@macports.org wrote: On Aug 9, 2014, at 11:47 AM, Frank Schima m...@macports.org wrote: Just curious about why you are removing the indenting spacing in these perl ports? I would say it is more common to indent in blocks. I’m open to

Re: [123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

2014-08-09 Thread David Evans
On 8/9/14 12:46 PM, Frank Schima wrote: On Aug 9, 2014, at 12:07 PM, Lawrence Velázquez lar...@macports.org wrote: On Aug 9, 2014, at 11:47 AM, Frank Schima m...@macports.org wrote: Just curious about why you are removing the indenting spacing in these perl ports? I would say it is more

Re: [123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

2014-08-09 Thread Lawrence Velázquez
On Aug 9, 2014, at 4:41 PM, David Evans dev...@macports.org wrote: On 8/9/14 12:46 PM, Frank Schima wrote: I think the code looks better indented. But I will stay with the consensus on this (of course). +1 for Frank's position here. I've been adding the 4 spaces when updating perl

Re: [123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

2014-08-09 Thread Marko Käning
On 8/9/14 12:46 PM, Frank Schima wrote: I think the code looks better indented. But I will stay with the consensus on this (of course). +1 But, I think, the removal of all these actually needed indentions were surely not intended by Mojca! (It’s probably just a glitch in the script used for

Re: [123423] trunk/dports/perl/p5-email-mime-contenttype/Portfile

2014-08-09 Thread Mojca Miklavec
On Sat, Aug 9, 2014 at 11:34 PM, Marko Käning wrote: On 8/9/14 12:46 PM, Frank Schima wrote: I think the code looks better indented. But I will stay with the consensus on this (of course). +1 But, I think, the removal of all these actually needed indentions were surely not intended by