Re: [151215] contrib/mp-buildbot

2016-08-10 Thread Mojca Miklavec
On 11 August 2016 at 05:56, Ryan Schmidt wrote: >> On Aug 10, 2016, at 1:25 PM, Mojca Miklavec wrote: >> >> Alternatively logdir could simply remain hardcoded as >> ${option_workdir}/logs. There's no need for an extra layer of >> complexity that doesn't really serve anyone. > > Yeah the log directo

Re: [151215] contrib/mp-buildbot

2016-08-10 Thread Ryan Schmidt
> On Aug 10, 2016, at 1:25 PM, Mojca Miklavec wrote: > > Alternatively logdir could simply remain hardcoded as > ${option_workdir}/logs. There's no need for an extra layer of > complexity that doesn't really serve anyone. Yeah the log directory doesn't really need to be configurable, does it? I

Re: [151215] contrib/mp-buildbot

2016-08-10 Thread Clemens Lang
Hi Mojca, a couple of review comments inline below. On Wed, Aug 10, 2016 at 11:09:30AM -0700, mo...@macports.org wrote: > Revision: 151215 > https://trac.macports.org/changeset/151215 > Author: mo...@macports.org > Date: 2016-08-10 11:09:29 -0700 (Wed, 10 Aug 2016) > Log Message:

Re: [151215] contrib/mp-buildbot

2016-08-10 Thread Lawrence Velázquez
On Aug 10, 2016, at 2:25 PM, Mojca Miklavec wrote: > Thanks a lot for catching this. > > Would you be willing to fix this properly before I make a bunch of > other mistakes? In particular I'm not absolutely sure how to handle > cases like this one in an elegant way: >./mpbb something --logdi

Re: [151215] contrib/mp-buildbot

2016-08-10 Thread Mojca Miklavec
On 10 August 2016 at 20:17, Lawrence Velázquez wrote: > > --- contrib/mp-buildbot/mpbb 2016-08-10 16:13:48 UTC (rev 151214) > +++ contrib/mp-buildbot/mpbb 2016-08-10 18:09:29 UTC (rev 151215) > @@ -77,6 +79,10 @@between builds. Your MacPorts installation in --prefix > needs to be able to >

Re: [151215] contrib/mp-buildbot

2016-08-10 Thread Lawrence Velázquez
essage > > mp-buildbot: create a log file with progress of installed dependencies > Modified Paths > > contrib/mp-buildbot/mpbb > contrib/mp-buildbot/mpbb-install-dependencies > > Diff > > <>Modified: contrib/mp-buildbot/mpbb (151214 => 151215