Re: svn:eol-style property

2007-01-25 Thread Kevin Ballard
I'm personally fond of just patch-. The .diff seems redundant, what with the patch- already there. On Jan 25, 2007, at 2:26 PM, Ryan Schmidt wrote: On Jan 25, 2007, at 02:26, Randall Wood wrote: I have seen no standard that states how patch files are to be named I have: http://darwinport

Re: svn:eol-style property

2007-01-25 Thread Ryan Schmidt
the repository. If this were to have broken any build, removing the svn:eol-style property would do just that; it would not also convert the line endings back to what they originally were, because Subversion does not know what they originally were

Re: svn:eol-style property

2007-01-25 Thread Ryan Schmidt
On Jan 24, 2007, at 16:22, Kevin Ballard wrote: I did a pass through Portfiles a while ago to set it on every Portfile. And any Portfiles which have been added since then probably never got it set. At the time, we discussed that a pre-commit hook should be added to the repository which

Re: svn:eol-style property

2007-01-25 Thread Ryan Schmidt
On Jan 25, 2007, at 02:26, Randall Wood wrote: I have seen no standard that states how patch files are to be named I have: http://darwinports.opendarwin.org/docs/ch04s07.html "The standard convention is to name the patch file 'patch- .diff, with one diff file per file altered in the source.

Re: svn:eol-style property

2007-01-25 Thread Kevin Ballard
Fair enough. I'll stick with native. On Jan 25, 2007, at 12:48 PM, Blair Zajac wrote: The point for svn:eol-style native is to allow people to check out files and edit them on their own box and not have to worry about the end of lines. If we set the style to LF, then people that do check t

Re: svn:eol-style property

2007-01-25 Thread Blair Zajac
Kevin Ballard wrote: On Jan 25, 2007, at 3:26 AM, Randall Wood wrote: I disagree. Take it off of the */*/patch* and the 200 other patches, which I guess are poorly named then since they don't start with the word patch, and leave everything else alone. I have seen no standard that states h

Re: svn:eol-style property

2007-01-25 Thread Kevin Ballard
On Jan 25, 2007, at 3:26 AM, Randall Wood wrote: I disagree. Take it off of the */*/patch* and the 200 other patches, which I guess are poorly named then since they don't start with the word patch, and leave everything else alone. I have seen no standard that states how patch files are to

Re: svn:eol-style property

2007-01-25 Thread Randall Wood
On 24 Jan 2007, at 16:06, Blair Zajac wrote: Kevin Ballard wrote: I'm not seeing a problem right now, because all of the current patchfiles are supposed to have unix line endings. But some time ago there was a problem - a patchfile I submitted had mixed line endings, and the committer conve

Re: svn:eol-style property

2007-01-24 Thread Kevin Ballard
On Jan 24, 2007, at 4:06 PM, Blair Zajac wrote: I do want svn:eol-style set on those in case somebody checks out a working copy on Windows, modifies those files and checks them back in. That would introduce CRLFs into them and gratuitous diffs. I'm of the mind that mostly everything should

Re: svn:eol-style property

2007-01-24 Thread Blair Zajac
Kevin Ballard wrote: I'm not seeing a problem right now, because all of the current patchfiles are supposed to have unix line endings. But some time ago there was a problem - a patchfile I submitted had mixed line endings, and the committer converted it to unix and added svn:eol-style, which

Re: svn:eol-style property

2007-01-24 Thread Blair Zajac
Kevin Ballard wrote: Why would you care about the eol style for python files? On Jan 24, 2007, at 12:35 PM, Blair Zajac wrote: I noticed that there are Python files that you would still want a native eol-style on, and presumable other scripts. Because somebody may edit it on a non-Unix platf

Re: svn:eol-style property

2007-01-24 Thread Kevin Ballard
Why would you care about the eol style for python files? On Jan 24, 2007, at 12:35 PM, Blair Zajac wrote: I noticed that there are Python files that you would still want a native eol-style on, and presumable other scripts. -- Kevin Ballard http://kevin.sb.org [EMAIL PROTECTED] http://www.til

Re: svn:eol-style property

2007-01-24 Thread Kevin Ballard
I'm not seeing a problem right now, because all of the current patchfiles are supposed to have unix line endings. But some time ago there was a problem - a patchfile I submitted had mixed line endings, and the committer converted it to unix and added svn:eol-style, which promptly broke the

Re: svn:eol-style property

2007-01-24 Thread Blair Zajac
Kevin Ballard wrote: There are a ton of files in the dports tree that have svn:eol-style set to native. In theory this would be a good thing, yes? Unfortunately, it's actually not. In the specific case of patchfiles (by far the most common type of file in the files/ directories), line endings

svn:eol-style property

2007-01-24 Thread Kevin Ballard
There are a ton of files in the dports tree that have svn:eol-style set to native. In theory this would be a good thing, yes? Unfortunately, it's actually not. In the specific case of patchfiles (by far the most common type of file in the files/ directories), line endings cannot be modified