Re: Commit History vs User Convenience

2018-10-08 Thread Ken Cunningham
On 2018-10-08, at 9:31 AM, Chris Jones wrote: > > To be honest, my concern with the above is to get adequate testing, across a > range of macOS versions, rather than nuances around the revisions... So lets > focus energies on that aspect... > > Chris Ah, the lure of the bikeshedding is

Re: Commit History vs User Convenience

2018-10-08 Thread Chris Jones
Hi, This makes absolutely no sense unless one change is straightforward and urgent (and could be merged quickly), and the other change is controversial & requires a lot of time to reach the consensus. Or some other "similar" scenario. Merging the first commit will necessarily introduce more

Re: Commit History vs User Convenience

2018-10-08 Thread Mojca Miklavec
Hi, Below is my opinion. On Mon, 8 Oct 2018 at 16:13, Marcus Calhoun-Lopez wrote: > > I was hoping to get some help with how best to balance commit history and > user convenience. > > I would like to make two unrelated changed to the GCC ports. > Each change requires a revision increase of all

Re: Commit History vs User Convenience

2018-10-08 Thread Michael Dickens
In my opinion: A single rev-bump is required when changes to the overall Portfile require it -- whether a single commit or multiple commits in a PR. The overall goal of a rev-bump is to force the port to be updated; it is a developer necessity & it's value is really not for the user's

Commit History vs User Convenience

2018-10-08 Thread Marcus Calhoun-Lopez
I was hoping to get some help with how best to balance commit history and user convenience. I would like to make two unrelated changed to the GCC ports. Each change requires a revision increase of all the GCC ports. There seem to be a few options: 1) Create two separate pull requests and have