Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-22 Thread Kirill A . Korinsky
Hi, On Mon, 22 Apr 2024 08:44:09 +0200, Riccardo Mottola wrote: > > Hi! > > Kirill A. Korinsky wrote: > > Keep in mind that suggested method removes support osx keyring from that > > system. User still be able to use SSH-based auth or enter password by hand > > for HTTP-based push. > > > > My

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-22 Thread Riccardo Mottola via macports-dev
Hi, Sergey Fedorov wrote: Some on MacRumors, for instance; quite likely that those who are on KDX and Hotline also run those on 10.4–10.5, though I have no statistics on that. this is a little off-topic and gave me a little tear. Hotline and KDX were my thing many years ago, like more than

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-22 Thread Riccardo Mottola via macports-dev
Hi! Kirill A. Korinsky wrote: Keep in mind that suggested method removes support osx keyring from that system. User still be able to use SSH-based auth or enter password by hand for HTTP-based push. My point: I assume that nobody uses HTTP-based auth on git on 10.5 and 10.6, I do not assume

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-21 Thread Kirill A . Korinsky
On Sun, 21 Apr 2024 10:51:24 +0200, Sergio Had wrote: > > I am pretty sure there are people outside of Macports, or at least not on > its developers list, who use < 10.7. > Some on MacRumors, for instance; quite likely that those who are on KDX and > Hotline also run those on 10.4–10.5, though I

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-21 Thread Kirill A . Korinsky
Hi, On Sun, 21 Apr 2024 09:38:24 +0200, Rliccardo Mottola wrote: > > I care for 10.5 and 10.6, but I read this mailing list :) > Probably most people developing or using these systems is on this > mailing list. Others may be using them but with old software only, not > trying to run latest on

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-21 Thread Sergey Fedorov
I am pretty sure there are people outside of Macports, or at least not on its developers list, who use < 10.7. Some on MacRumors, for instance; quite likely that those who are on KDX and Hotline also run those on 10.4–10.5, though I have no statistics on that. Sure enough, it is not a numerous

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-21 Thread Riccardo Mottola via macports-dev
Hi, Kirill A. Korinsky wrote: I really doubt that anyone care about of macOS 10.6 these days with exception for a few folks in the world, and probably half of them read this mail list:) But propose a patch for git isn't bad idea, indeed. I care for 10.5 and 10.6, but I read this mailing list

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-21 Thread Kirill A . Korinsky
On Sun, 21 Apr 2024 07:47:03 +0200, Sergio Had wrote: > > Given it is in contrib, presumably it got its own upstream? Nope, it is part of git. See it as optional part of git which aren't available on each supported system. -- wbr, Kirill

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-20 Thread Sergio Had
Given it is in contrib, presumably it got its own upstream? On Apr 21, 2024 at 11:24 +0800, Fred Wright , wrote: > > On Sat, 20 Apr 2024, Saagar Jha wrote: > > > Wait, I use osxkeychain. It’s basically a requirement if you’re pushing > > to an authenticated server over HTTPS and don’t want to have

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-20 Thread Fred Wright
On Sat, 20 Apr 2024, Saagar Jha wrote: Wait, I use osxkeychain. It’s basically a requirement if you’re pushing to an authenticated server over HTTPS and don’t want to have to deal with storing keys yourself. I suspect it is used a lot for this. I have yet to see a Git repo that didn't allow

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-20 Thread Kirill A . Korinsky
On Sat, 20 Apr 2024 20:45:36 +0200, Sergio Had wrote: > > Is someone in touch with Git upstream? It should be pretty trivial to > retain the working code, they are perhaps simply assuming that nobody uses > it. Which is not the case, obviously. I really doubt that anyone care about of macOS 10.6

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-20 Thread Sergio Had
Is someone in touch with Git upstream? It should be pretty trivial to retain the working code, they are perhaps simply assuming that nobody uses it. Which is not the case, obviously. On Apr 21, 2024 at 02:41 +0800, Kirill A. Korinsky , wrote: > On Sat, 20 Apr 2024 18:19:30 +0200, > Saagar Jha

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-20 Thread Kirill A . Korinsky
On Sat, 20 Apr 2024 18:19:30 +0200, Saagar Jha wrote: > > Wait, I use osxkeychain. It’s basically a requirement if you’re pushing to > an authenticated server over HTTPS and don’t want to have to deal with > storing keys yourself. I suspect it is used a lot for this. > Do you use on 10.6? I

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-20 Thread Sergio Had
Yes, I also use it for this. We want it to work. On Apr 21, 2024 at 00:19 +0800, Saagar Jha , wrote: > Wait, I use osxkeychain. It’s basically a requirement if you’re pushing to an > authenticated server over HTTPS and don’t want to have to deal with storing > keys yourself. I suspect it is

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-20 Thread Saagar Jha
Wait, I use osxkeychain. It’s basically a requirement if you’re pushing to an authenticated server over HTTPS and don’t want to have to deal with storing keys yourself. I suspect it is used a lot for this. > On Apr 19, 2024, at 23:52, Kirill A. Korinsky wrote: > > On Sat, 20 Apr 2024

Re: Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-20 Thread Kirill A . Korinsky
On Sat, 20 Apr 2024 00:25:47 +0200, Sergio Had wrote: > > What do we do? :) To fix the build you have two options: 1. Revert that patch for system before 10.7 2. Remove folder contrib/credential/osxkeychain I suggest to follow (2) as simpler thay and the good news that osxkeychain is something

Git-devel has broken git-credential-osxkeychain.c for older systems

2024-04-19 Thread Sergio Had
See: https://lore.kernel.org/all/f7031316a043b36fac10ecf784d2294894967e7b.1708212896.git.gitgitgad...@gmail.com/ Fails on 10.6 Intel now: https://github.com/macports/macports-ports/commit/e21cd2a3df66db81d79807fd83b5a7742fa07f97#commitcomment-141174012 What do we do? :)