Re: protobuf-cpp (was Re: Request for assistance closing some old pull requests)

2018-03-20 Thread Mojca Miklavec
On 20 March 2018 at 16:56, Perry E. Metzger wrote: > On Mon, 19 Mar 2018 21:46:54 -0500 Ryan Schmidt wrote: >> >> I would prefer that the bug that protobuf-cpp and protobuf3-cpp >> install to the same place is fixed first: >> >> https://trac.macports.org/ticket/56102 >> >> Then there's no reason wh

Re: Wine (was Re: Request for assistance closing some old pull requests)

2018-03-20 Thread Perry E. Metzger
On Tue, 20 Mar 2018 11:59:01 -0400 "Perry E. Metzger" wrote: > On Mon, 19 Mar 2018 11:44:48 -0400 "Perry E. Metzger" > wrote: > > > > 1: wine*: add 64-bit support > >https://github.com/macports/macports-ports/pull/442 > >Apr 22, 2017 (yes, almost a year old) > > There seems to be a con

Wine (was Re: Request for assistance closing some old pull requests)

2018-03-20 Thread Perry E. Metzger
On Mon, 19 Mar 2018 11:44:48 -0400 "Perry E. Metzger" wrote: > > 1: wine*: add 64-bit support >https://github.com/macports/macports-ports/pull/442 >Apr 22, 2017 (yes, almost a year old) There seems to be a consensus that the 64 bit stuff _should_ be committed for the sake of those apps th

protobuf-cpp (was Re: Request for assistance closing some old pull requests)

2018-03-20 Thread Perry E. Metzger
On Mon, 19 Mar 2018 21:46:54 -0500 Ryan Schmidt wrote: > > 2: mosh: Switch to protobuf3-cpp > > https://github.com/macports/macports-ports/pull/690 > > Aug 17, 2017 > > > > Zero King correctly notes in the course of the PR's comment thread > > that protobuf3-cpp conflicts with protobuf-cpp, s

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Ryan Schmidt
On Mar 19, 2018, at 10:44, Perry E. Metzger wrote: > There are a few pull requests that are pretty old and which I think > are, de facto, stuck. I'd like to get some feedback about what to do > about them. > > If we can close these three, we will have no PRs older than six months > active in the

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Joshua Root
On 2018-3-20 05:14 , Leonardo Brondani Schenkel wrote: > On 2018-03-19 18:17, Ken Cunningham wrote: >>> There's no good way to shim the ABI without having something >>> physically deal with this problem, which likely requires a lot of >>> work on very low level hacking. >> >> When last I read about

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Michael
On 2018-03-19, at 10:03 AM, Perry E. Metzger wrote: > So my understanding (and I might be mangling it) is that the issue > here is that there are two x86_64 registers that are reasonable > candidates for pointing at thread local data, and Windows has picked > a different one from macOS. The resu

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Perry E. Metzger
On Mon, 19 Mar 2018 14:27:44 -0400 "Perry E. Metzger" wrote: > On Mon, 19 Mar 2018 11:17:21 -0600 Ken Cunningham > wrote: > > > > > > There's no good way to shim the ABI without having something > > > physically deal with this problem, which likely requires a lot > > > of work on very low level

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Perry E. Metzger
On Mon, 19 Mar 2018 19:29:35 +0100 Rainer Müller wrote: [On the Wine 64 bit issue] > > So my understanding (and I might be mangling it) is that the issue > > here is that there are two x86_64 registers that are reasonable > > candidates for pointing at thread local data, and Windows has > > pi

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Mojca Miklavec
On 19 March 2018 at 19:29, Rainer Müller wrote: > > Unfortunately, we have no support to run builds from pull requests or > custom branches on the buildbot, as it would immediately publish the > resulting archives. > > This sounds like a nice enhancement for our buildbot, though. On a > forced buil

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Rainer Müller
On 2018-03-19 18:03, Perry E. Metzger wrote: > On Mon, 19 Mar 2018 17:10:52 +0100 Mojca Miklavec >> Last time I checked this PR was not entirely complete and from my >> understanding that was the only reason why it was not merged. We >> certainly need a solution for 64-bit wine in some not-too-dist

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Perry E. Metzger
On Mon, 19 Mar 2018 11:17:21 -0600 Ken Cunningham wrote: > > > > There's no good way to shim the ABI without having something > > physically deal with this problem, which likely requires a lot of > > work on very low level hacking. > > When last I read about this, the Wine devs were asking for

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Leonardo Brondani Schenkel
On 2018-03-19 18:17, Ken Cunningham wrote: There's no good way to shim the ABI without having something physically deal with this problem, which likely requires a lot of work on very low level hacking. When last I read about this, the Wine devs were asking for compiler support in clang to acco

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Ken Cunningham
> > There's no good way to shim the ABI without having something > physically deal with this problem, which likely requires a lot of > work on very low level hacking. When last I read about this, the Wine devs were asking for compiler support in clang to accomplish this feat. I bet they will g

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Perry E. Metzger
On Mon, 19 Mar 2018 17:10:52 +0100 Mojca Miklavec wrote: > On 19 March 2018 at 16:44, Perry E. Metzger wrote: > > > > 1: wine*: add 64-bit support > >https://github.com/macports/macports-ports/pull/442 > >Apr 22, 2017 (yes, almost a year old) > > > > This PR seems to be stuck on the fact t

Re: Request for assistance closing some old pull requests

2018-03-19 Thread Mojca Miklavec
On 19 March 2018 at 16:44, Perry E. Metzger wrote: > > 1: wine*: add 64-bit support >https://github.com/macports/macports-ports/pull/442 >Apr 22, 2017 (yes, almost a year old) > > This PR seems to be stuck on the fact that Wine de facto needs a 64 > bit version to be useful in a modern cont

Request for assistance closing some old pull requests

2018-03-19 Thread Perry E. Metzger
There are a few pull requests that are pretty old and which I think are, de facto, stuck. I'd like to get some feedback about what to do about them. If we can close these three, we will have no PRs older than six months active in the system, which I think is a win. 1: wine*: add 64-bit support