Re: implementation of configure.env-append

2019-10-12 Thread Ken Cunningham
> > On Tue, Oct 8, 2019 at 9:25 AM Blair Zajac wrote: > > > > >> Maybe the MacPorts could raise an error if one attempts to set a variable > >> like LDFLAGS outside of configure.* ? > > Yes, MacPorts could do that. I don't think anybody's tried to write code to > do that yet. > > and

Re: implementation of configure.env-append

2019-10-11 Thread Ken Cunningham
Yes, basically. I mean, we have about 1500 very carefully written lines of code in base designed to work out the perfect configure (and build) environment, and yet because we can't access it during the build, we have several hundred ports trying to cobble together a (usually poorly done) version

Re: implementation of configure.env-append

2019-10-11 Thread Ryan Schmidt
On Oct 9, 2019, at 10:57, Ken Cunningham wrote: > On Tue, Oct 8, 2019 at 9:25 AM Blair Zajac wrote: > >> Maybe the MacPorts could raise an error if one attempts to set a variable >> like LDFLAGS outside of configure.* ? Yes, MacPorts could do that. I don't think anybody's tried to write

Re: implementation of configure.env-append

2019-10-09 Thread Joshua Root
On 2019-10-10 07:28 , Ryan Schmidt wrote: > > > On Oct 9, 2019, at 12:04, Ken Cunningham wrote: > >> On Tue, Oct 8, 2019 at 1:59 AM Ryan Schmidt wrote: >> >>> No... it's the other way around... >>> >>> If you want to modify LDFLAGS, do so by modifying configure.ldflags. >>> MacPorts will set

Re: implementation of configure.env-append

2019-10-09 Thread Kenneth F. Cunningham
On 2019-10-09, at 1:28 PM, Ryan Schmidt wrote: > do whatever additional work is necessary to communicate that variable to the > build system, e.g. by using `build.args-append LDFLAGS="${configure.ldflags} > [get_canonical_archflags ld]"` or whatever. > Perhaps I'll try a new approach to

Re: implementation of configure.env-append

2019-10-09 Thread Ryan Schmidt
On Oct 9, 2019, at 12:04, Ken Cunningham wrote: > On Tue, Oct 8, 2019 at 1:59 AM Ryan Schmidt wrote: > >> No... it's the other way around... >> >> If you want to modify LDFLAGS, do so by modifying configure.ldflags. >> MacPorts will set the LDFLAGS environment variable to the value of >>

Re: implementation of configure.env-append

2019-10-09 Thread Ken Cunningham
Quite right, and that's of course what I usually do. And it works most of the time. But in some cases, ports don't run a configure phase, or it is not fully honored due to internal software tricks or malfeasance, or similar. So it is necessary to get the extra variables into the environment

Re: implementation of configure.env-append

2019-10-09 Thread Ken Cunningham
I wouldn't suggest raising an error. It's certainly useful to do at times. Lots of software doesn't run a configure phase, for example. I still don't think we have this properly sorted out. Look at what Marcus had to do here, for example <

Re: implementation of configure.env-append

2019-10-08 Thread Blair Zajac
> On Oct 8, 2019, at 1:59 AM, Ryan Schmidt wrote: > > > > On Oct 6, 2019, at 14:05, Ken Cunningham wrote: > >> I think I have tried this enough ways to be close, but I just want to be >> certain. >> >> I want to *append* a value onto an existing environment variable from a >> Portfile.

Re: implementation of configure.env-append

2019-10-08 Thread Ryan Schmidt
On Oct 6, 2019, at 14:05, Ken Cunningham wrote: > I think I have tried this enough ways to be close, but I just want to be > certain. > > I want to *append* a value onto an existing environment variable from a > Portfile. I don’t want to overwrite what is there in the environment variable

implementation of configure.env-append

2019-10-06 Thread Ken Cunningham
I think I have tried this enough ways to be close, but I just want to be certain. I want to *append* a value onto an existing environment variable from a Portfile. I don’t want to overwrite what is there in the environment variable already. adding for example this in the Portfile: