[Mahara-contributors] [Bug 784341] Re: Fix xmldb postgres generator to preserve unique keys during alter table

2013-11-13 Thread Robert Lyon
From what I understand the getAlterFieldSQL() function in postgres7.class.php will create a new temp column in some instances (for instance change of type / precision / decimal). It will copy the data from the old unaltered field we are changing to the temp one, drop the old field and then rename

[Mahara-contributors] [Bug 784960] Re: when a page is displayed, the navigation menu doesn't show where you are

2013-11-13 Thread Robert Lyon
What is really needed is a proper 'breadcrumb' option that displays the full navigational path depending where you are. I've attached some examples of breadcrumbs a mahara client uses to show what could be done to have the better navigation. They achieve this by having a breadcrumb.tpl called by

[Mahara-contributors] [Bug 788444] Re: Filtering pages by their tags - it's case sensitive

2013-11-13 Thread Robert Lyon
The discussion here relates to this bug also: https://bugs.launchpad.net/mahara/+bug/1231920 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on

[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls

2013-11-13 Thread Robert Lyon
Would flushing the output buffer for each iteration of the heavy load loops help? Or is more a server machine problem? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara

[Mahara-contributors] [Bug 785472] Re: Eliminate all raise_memory_limit() calls

2013-11-13 Thread Robert Lyon
Instead of eliminating them we now have more :( ./htdocs/lib/cron.php:raise_memory_limit('128M'); ./htdocs/lib/csvfile.php:raise_memory_limit(512M); ./htdocs/lib/mahara.php:raise_memory_limit('128M'); ./htdocs/lib/mahara.php:function raise_memory_limit ($newlimit) {

[Mahara-contributors] [Bug 789324] Re: Set block title behaves differently for block Group Pages

2013-11-13 Thread Robert Lyon
It has been over 2 years now and people are used to the way it works now (having the 'Set a block title' option) so changing it now will be just as confusing - so I will close this ticket. ** Changed in: mahara Status: Triaged = Won't Fix -- You received this bug notification because you

[Mahara-contributors] [Bug 799035] Re: Decrease the line height in page and group descriptions on the overview pages

2013-11-13 Thread Robert Lyon
The paragraph text for the group/find.php page looks to be consistent with other similar pages now in v1.8 - it isn't showing true p/p paragraphs but rather has brbrbr between each paragraph. The view/index.php page however is still not displaying paragraph breaks in the description. I note in

[Mahara-contributors] [Bug 802344] Re: institution is joined automatically when registering and only 2 institutions

2013-11-13 Thread Robert Lyon
As this has been the functionality of mahara since July 2009 I would see this as the correct way of doing things rather than being a bug. So will close ticket ** Changed in: mahara Status: Triaged = Won't Fix -- You received this bug notification because you are a member of Mahara

[Mahara-contributors] [Bug 746418] A change has been merged

2013-11-13 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/2706 Committed: http://gitorious.org/mahara/mahara/commit/74d25762f8cda54cecf6d164417ce4ed064daf31 Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit 74d25762f8cda54cecf6d164417ce4ed064daf31 Author: Robert Lyon

[Mahara-contributors] [Bug 803229] Re: Some file formats allow extracting when file is not an archive

2013-11-13 Thread Robert Lyon
This problem might also be related to: https://bugs.launchpad.net/mahara/+bug/1249166 https://bugs.launchpad.net/mahara/+bug/1249858 Where the mimetype is incorrectly set in the browser's registry and then mahara is not correctly sniffing out the true mimetype -- You received this bug

[Mahara-contributors] [Bug 731062] Re: Feedback ratings are not exportable

2013-11-13 Thread Robert Lyon
The rating stars are exportable in v1.8 for standalone html but there is a problem with the exported star file being .gif but the css expects .png - due to change done to default icons have added a patch for that issue: https://reviews.mahara.org/#/c/2707 However the comment star rating does not

[Mahara-contributors] [Bug 811394] Re: A url in this field contains the blacklisted domain ...'

2013-11-13 Thread Robert Lyon
Can't replicate so will mark as invalid. If someone can replicate this problem then feel free to reopen it and please give instructions on how to replicate. ** Changed in: mahara Status: Triaged = Invalid -- You received this bug notification because you are a member of Mahara

[Mahara-contributors] [Bug 803747] Re: Do not display the username to a person registering for an account

2013-11-13 Thread Robert Lyon
The display_name() function can take a $nameonly variable So maybe we could go display_name($USER, null, true) and then change the display_name function's line from $addusername = $username || !empty($userto-admin) || !empty($userto-staff); to $addusername = $username || (!empty($userto-admin)

[Mahara-contributors] [Bug 837437] Re: In lib/dml.php execute_sql_arr, $continue parameter can't ever work

2013-11-13 Thread Robert Lyon
This problem still exists. I do note that in mahara we have: function execute_sql_arr($sqlarr, $continue=true, $feedback=true) { but in moodle they have: protected function execute_sql_arr(array $sqlarr) { So it might be worth changing our function to be more like the moodle one (have

[Mahara-contributors] [Bug 850580] Re: Attempt to log in when deleted updates lastlogin field

2013-11-13 Thread Robert Lyon
This does not look to be happening for a deleted user anymore. It does, however, happen for a suspended user. The problem is the ./htdocs/auth/user.php has an authenticate() function that saves the new 'lastlogin' value and it is called before the check to see if one is suspended. If we swap

[Mahara-contributors] [Bug 852304] Re: Sending a friend request should return you to the page you were previously on

2013-11-13 Thread Robert Lyon
This was a quick change so I made a patch for it: https://reviews.mahara.org/#/c/2708/ ** Changed in: mahara Status: Triaged = In Progress ** Changed in: mahara Assignee: (unassigned) = Robert Lyon (robertl-9) -- You received this bug notification because you are a member of Mahara

[Mahara-contributors] [Bug 871351] Re: theme raw netbooks display of right column not correct

2013-11-13 Thread Robert Lyon
This problem looks to be obsolete as the latest (v1.8) has width: 100%; and there have been major changes to the css recently so will close this bug ** Changed in: mahara Status: Triaged = Invalid -- You received this bug notification because you are a member of Mahara Contributors,

[Mahara-contributors] [Bug 1251089] [NEW] Invalid value for licensedefault

2013-11-13 Thread Robert Lyon
Public bug reported: If I have a site and enable the 'General' setting: License metadata and then masquerade as different user and then go to their account settings page I get the below error (see first error). From what I can see in general_account_prefs_form_elements($prefs) there is a bit of

[Mahara-contributors] [Bug 1237137] A change has been merged

2013-11-13 Thread Mahara Bot
Reviewed: https://reviews.mahara.org/2705 Committed: http://gitorious.org/mahara/mahara/commit/2b9063d31f4e4d0c222b1cee84fa78f52191d40a Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch:master commit 2b9063d31f4e4d0c222b1cee84fa78f52191d40a Author: Robert Lyon