[Mahara-contributors] [Bug 1993481] [NEW] MNET pkey failure in PHP 8.0

2022-10-19 Thread Andrew Nicols
Public bug reported: auth/xmlrpc fails in xmlenc_envelope() for PHP 8.0 with the error: Could not generate public key resource from certificate This is because the return value for `openssl_get_publickey` is an instance of `OpenSSLAsymmetricKey` from PHP 8.0 onwards. ** Affects: mahara

[Mahara-contributors] [Bug 1189823] Re: Pieforms attempts to load renderer plugin even when already loaded

2013-06-12 Thread Andrew Nicols
Cheers Luke, That patch looks good to me. Just to confirm, this is to work around issues where you wish to use a function which is defined outside of the pieforms structure and where the function has already been defined. Therefore it is not necessary (or appropriate) to include the file from the

[Mahara-contributors] [Bug 897593] Re: Update .gitattributes to excluded tests from built releases

2012-01-22 Thread Andrew Nicols
I've made a merge request on the scripts directory for this. See http://gitorious.org/mahara/mahara-scripts/merge_requests/2 This change modifies the build process slightly to generate a new .gitattributes directory and use the --worktree-attributes option to git archive when generating the archiv

[Mahara-contributors] [Bug 920141] Re: Remove tests entry from .gitignore

2012-01-22 Thread Andrew Nicols
https://reviews.mahara.org/#change,928 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/920141 Title: Remove tests entry from .gitignore Status in Mahara ePortfolio: New Bug description:

[Mahara-contributors] [Bug 920141] [NEW] Remove tests entry from .gitignore

2012-01-22 Thread Andrew Nicols
Public bug reported: This is to allow us to write unit tests and actually commit them ;) ** Affects: mahara Importance: High Assignee: Andrew Nicols (dobedobedoh) Status: New ** Tags: tests -- You received this bug notification because you are a member of Mahara

[Mahara-contributors] [Bug 897593] Re: Update .gitattributes to excluded tests from built releases

2011-11-29 Thread Andrew Nicols
Posted the first option in https://reviews.mahara.org/898 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/897593 Title: Update .gitattributes to excluded tests from built releases Status in M

[Mahara-contributors] [Bug 897593] [NEW] Update .gitattributes to excluded tests from built releases

2011-11-29 Thread Andrew Nicols
so attempt to remove empty tests directories. ** Affects: mahara Importance: Low Assignee: Andrew Nicols (dobedobedoh) Status: New ** Tags: release tests -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mah

[Mahara-contributors] [Bug 897125] [NEW] Unit Test for cron_lock

2011-11-28 Thread Andrew Nicols
Public bug reported: Following bug #891170: Write relevant unit tests for cron_lock, and cron_free if possile This may not be possible without a reshuffle of lib/cron.php At present, the actual logic is not in a function so including the file to test the functions will lead to the cron system ru

[Mahara-contributors] [Bug 891170] Re: race conditions in cron

2011-11-28 Thread Andrew Nicols
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/891170 Title: race conditions in cron Status in Mahara ePortfolio: Fix Comm

[Mahara-contributors] [Bug 893621] Re: Institution plugins

2011-11-23 Thread Andrew Nicols
Actually, I wrote this 2 years ago but it hasn't been integrated in core. It was originally written as a component to isolated institutions, but I wrote it completely separately to that feature. I updated the feature for Mahara 1.3 and it's available on github at https://gitorious.org/~dobedobedoh

[Mahara-contributors] [Bug 891170] [NEW] race conditions in cron

2011-11-16 Thread Andrew Nicols
Public bug reported: Thanks to tim hunt at the OU for pointing the first issue out: It's possible for cron_lock to fail to get the $started value if the row has been deleted between attempting to insert the record, and attempting to retrieve the start date http://gitorious.org/mahara/mahara/blo

[Mahara-contributors] [Bug 887745] [NEW] Update release scripts to ignore all unit tests

2011-11-08 Thread Andrew Nicols
Public bug reported: We dont' need to produce releases including our unit tests. We need to modify the release scripts to remove the unit tests ** Affects: mahara Importance: High Assignee: Andrew Nicols (dobedobedoh) Status: New ** Tags: release tests ** Changed in: m

[Mahara-contributors] [Bug 871741] [NEW] Support alternative session storage implementations

2011-10-10 Thread Andrew Nicols
Public bug reported: We should look at the best way of implementing session storage, other than in the dataroot. I've seen issues where sessions stored on NFS suffer from lock issues, but we should also consider extending the current storage mechanism to allow administrators to choose alternative

[Mahara-contributors] [Bug 868851] Re: get_all_theme_objects and directory starts with dot

2011-10-09 Thread Andrew Nicols
** Changed in: mahara Milestone: None => 1.5.0 ** Changed in: mahara Assignee: (unassigned) => Andrew Nicols (dobedobedoh) ** Changed in: mahara Status: New => Triaged ** Changed in: mahara Status: Triaged => In Progress ** Changed in: mahara Importanc

[Mahara-contributors] [Bug 869193] Re: TinyMCE needs to be updated to version 3.4.6

2011-10-06 Thread Andrew Nicols
Hi Melissa, I've added a milestone of 1.5.0 for this. Is there a specific bug fix which affects you? Also, there's no need to attach the upstream zip - we'll download it and verify hashes when we work on the bug. Andrew ** Changed in: mahara Milestone: None => 1.5.0 ** Changed in: mahara

[Mahara-contributors] [Bug 869214] Re: TinyMCE buttons need to be updated

2011-10-06 Thread Andrew Nicols
Hi Melissa, Can you please summarise the effects of these changes and why they're required? Thanks, Andrew ** Changed in: mahara Milestone: None => 1.5.0 ** Changed in: mahara Status: New => Triaged ** Changed in: mahara Importance: Undecided => Low -- You received this bug no

[Mahara-contributors] [Bug 824445] Re: Missing Plugins Should be disabled automatically

2011-09-16 Thread Andrew Nicols
Updated to catch a missing case. Awaiting review -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/824445 Title: Missing Plugins Should be disabled automatically Status in Mahara ePortfolio:

[Mahara-contributors] [Bug 851638] [NEW] CLI framework should accept input

2011-09-16 Thread Andrew Nicols
Public bug reported: The CLI framework should allow for developers to ask users for input. For example: $sure = $cli->get_input(get_string('areyousure')); switch ($sure) { case('yes'): case('y'): // Do something default: // Don't do it } I believe that Moodle does

[Mahara-contributors] [Bug 851635] [NEW] CLI framework should support alternative option formats

2011-09-16 Thread Andrew Nicols
Public bug reported: At present the CLI framework grabs $argv wholesale and works through it testing whole words. Typically, the short form of an option has always allowed a slightly different form. Whilst the long option might be --foo=bar The short option should support: -f bar Additional

[Mahara-contributors] [Bug 819396] Re: Add unit testing to Mahara

2011-09-14 Thread Andrew Nicols
I've pushed a fix for part of the MySQL stuff - it turns out that you can't simply reverse the order of indexes and keys, as the names will get changed. You have to build the names, then order (the names are cached). https://reviews.mahara.org/693 Haven't worked out why tearDown is being called t

[Mahara-contributors] [Bug 841694] Re: Add uninstall_from_xmldb_file

2011-09-14 Thread Andrew Nicols
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/841694 Title: Add uninstall_from_xmldb_file Status in Mahara ePortfolio: Fi

[Mahara-contributors] [Bug 844604] Re: Create CLI installer/upgrader

2011-09-14 Thread Andrew Nicols
Fix committed, but found a minor bug in upgrade code. New patch submitted in https://reviews.mahara.org/692 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/844604 Title: Create CLI installer/u

[Mahara-contributors] [Bug 844607] Re: Create CLI Framework/Libraries

2011-09-14 Thread Andrew Nicols
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/844607 Title: Create CLI Framework/Libraries Status in Mahara ePortfolio: F

[Mahara-contributors] [Bug 844604] Re: Create CLI installer/upgrader

2011-09-13 Thread Andrew Nicols
https://reviews.mahara.org/688 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/844604 Title: Create CLI installer/upgrader Status in Mahara ePortfolio: In Progress Bug description: As di

[Mahara-contributors] [Bug 844607] Re: Create CLI Framework/Libraries

2011-09-13 Thread Andrew Nicols
https://reviews.mahara.org/687 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/844607 Title: Create CLI Framework/Libraries Status in Mahara ePortfolio: In Progress Bug description: I've

[Mahara-contributors] [Bug 844604] Re: Create CLI installer/upgrader

2011-09-08 Thread Andrew Nicols
I'd like a milestone of 1.5.0 to aid us in our unit testing desires... ** Changed in: mahara Milestone: None => 1.5.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/844604 Title: Create

[Mahara-contributors] [Bug 844604] Re: Create CLI installer/upgrader

2011-09-08 Thread Andrew Nicols
Ideally should be implemented with CLI libraries - see bug #844607 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/844604 Title: Create CLI installer/upgrader Status in Mahara ePortfolio: I

[Mahara-contributors] [Bug 844604] [NEW] Create CLI installer/upgrader

2011-09-08 Thread Andrew Nicols
Public bug reported: As discussed in the unit testing documentation, it would be pretty handy to have a CLI installer and upgrader ** Affects: mahara Importance: Wishlist Assignee: Andrew Nicols (dobedobedoh) Status: In Progress ** Tags: install upgrade ** Changed in

[Mahara-contributors] [Bug 844607] Re: Create CLI Framework/Libraries

2011-09-08 Thread Andrew Nicols
I've been pondering whether the log_exit should go with the other error functions (e.g. log_debug) in lib/errors.php. We currently have no log_die, and I doubt we want one except for CLI stuff (correct me if I'm wrong). Setting the exit code is very CLI specific. Therefore I've been toying with

[Mahara-contributors] [Bug 844607] [NEW] Create CLI Framework/Libraries

2011-09-08 Thread Andrew Nicols
cense=yes --upgrade-only -p=letmein -e=f...@example.org) * add a log_exit or equivelant which would exit with the appropriate exit code (0 = success, 127 = error, other supplied ints in range) and exit - e.g. cli_exit(). ** Affects: mahara Importance: Wishlist Assignee: Andrew N

[Mahara-contributors] [Bug 819396] Re: Add unit testing to Mahara

2011-09-06 Thread Andrew Nicols
Submitted for review. The actual framework is in https://reviews.mahara.org/#change,647 Some sample tests are in https://reviews.mahara.org/#change,648 Francois: No problem with doing this what-so-ever having thought about it more. ** Changed in: mahara Status: Confirmed => In Progress --

[Mahara-contributors] [Bug 819396] Re: Add unit testing to Mahara

2011-09-06 Thread Andrew Nicols
This bug also requires inclusion of: Bug #841708 Bug #841694 Bug #841723 Bug #841711 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/819396 Title: Add unit testing to Mahara Status in Mahara

[Mahara-contributors] [Bug 841723] Re: Use microtime instead of float for user deletion

2011-09-05 Thread Andrew Nicols
Commited supplied by Penny: https://reviews.mahara.org/641 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/841723 Title: Use microtime instead of float for user deletion Status in Mahara ePo

[Mahara-contributors] [Bug 841723] [NEW] Use microtime instead of float for user deletion

2011-09-05 Thread Andrew Nicols
ecise enough and you end up with collisions. Changing to use microtime fixes these issues and allows for unit tests to be run ** Affects: mahara Importance: Wishlist Assignee: Andrew Nicols (dobedobedoh) Status: In Progress ** Tags: accuracy deletion phpunit user ** Chang

[Mahara-contributors] [Bug 841708] Re: Allow page title specification at page creation

2011-09-05 Thread Andrew Nicols
Submitted Penny's change for this with minor changes: https://reviews.mahara.org/#change,639 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/841708 Title: Allow page title specification at pag

[Mahara-contributors] [Bug 841711] Re: Add wakeup support to adodb

2011-09-05 Thread Andrew Nicols
Submitted penny's change for this with changes - added to adodb/README.mahara and removed debugging echos https://reviews.mahara.org/640 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/841711 T

[Mahara-contributors] [Bug 841711] [NEW] Add wakeup support to adodb

2011-09-05 Thread Andrew Nicols
) can probably ignore this change and use stock adodb ** Affects: mahara Importance: Wishlist Assignee: Andrew Nicols (dobedobedoh) Status: In Progress ** Tags: adodb db phpunit ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importa

[Mahara-contributors] [Bug 841694] Re: Add uninstall_from_xmldb_file

2011-09-05 Thread Andrew Nicols
Submitted Penny's patch for this (with minor alternations): https://reviews.mahara.org/#change,638 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/841694 Title: Add uninstall_from_xmldb_file

[Mahara-contributors] [Bug 841708] Re: Allow page title specification at page creation

2011-09-05 Thread Andrew Nicols
This is required for some of the phpunit tests -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/841708 Title: Allow page title specification at page creation Status in Mahara ePortfolio: In

[Mahara-contributors] [Bug 841708] [NEW] Allow page title specification at page creation

2011-09-05 Thread Andrew Nicols
Public bug reported: When a page is created, if a title is given in the $viewdata it should be honoured. ** Affects: mahara Importance: Wishlist Assignee: Andrew Nicols (dobedobedoh) Status: In Progress ** Tags: creation page phpunit view ** Changed in: mahara Status

[Mahara-contributors] [Bug 841694] [NEW] Add uninstall_from_xmldb_file

2011-09-05 Thread Andrew Nicols
Public bug reported: Add support to uninstall tables from xmldb This is part of the work to provide unit testing ** Affects: mahara Importance: Wishlist Assignee: Andrew Nicols (dobedobedoh) Status: In Progress ** Tags: db phpunit xmldb ** Changed in: mahara Status

[Mahara-contributors] [Bug 824519] Re: Make default video size of internalmedia configurable

2011-08-12 Thread Andrew Nicols
AFAIK it's not possible to change the 300x300 default..? Or do you mean on a block level. I've updated the patch to reflect a better limit. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/824519

[Mahara-contributors] [Bug 824638] Re: Date of Birth time field on resume not translatable

2011-08-11 Thread Andrew Nicols
I'm putting the target to 1.4.1 for the moment as it is a bug which makes life harder for users of other languages -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/824638 Title: Date of Birth t

[Mahara-contributors] [Bug 824638] [NEW] Date of Birth time field on resume not translatable

2011-08-11 Thread Andrew Nicols
Public bug reported: In artefact/resume/index.php the following is defined for the format of the dateofbirth: 'ifFormat' => '%Y/%m/%d' Ideally, we need to convert thing to a get_string('strfYMD', 'langconfig') etc with appropriate name. Not sure whether this has any consequences, though I

[Mahara-contributors] [Bug 824445] Re: Missing Plugins Should be disabled automatically

2011-08-11 Thread Andrew Nicols
Fix committed in Change 578 - awaiting review -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/824445 Title: Missing Plugins Should be disabled automatically Status in Mahara ePortfolio: In

[Mahara-contributors] [Bug 824445] Re: Missing Plugins Should be disabled automatically

2011-08-11 Thread Andrew Nicols
** Changed in: mahara Milestone: None => 1.5.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/824445 Title: Missing Plugins Should be disabled automatically Status in Mahara ePortfolio:

[Mahara-contributors] [Bug 824445] Re: Missing Plugins Should be disabled automatically

2011-08-11 Thread Andrew Nicols
** Changed in: mahara Status: New => In Progress ** Changed in: mahara Importance: Undecided => Wishlist ** Changed in: mahara Assignee: (unassigned) => Andrew Nicols (dobedobedoh) -- You received this bug notification because you are a member of Mahara Contributors,

[Mahara-contributors] [Bug 824519] Re: Make default video size of internalmedia configurable

2011-08-11 Thread Andrew Nicols
Submitted for review in change 579 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/824519 Title: Make default video size of internalmedia configurable Status in Mahara ePortfolio: In Progre

[Mahara-contributors] [Bug 824519] [NEW] Make default video size of internalmedia configurable

2011-08-11 Thread Andrew Nicols
fects: mahara Importance: Wishlist Assignee: Andrew Nicols (dobedobedoh) Status: In Progress ** Tags: artefact file internalmedia size video ** Changed in: mahara Importance: Undecided => Wishlist ** Changed in: mahara Status: New => In Progress ** Changed

[Mahara-contributors] [Bug 824445] [NEW] Missing Plugins Should be disabled automatically

2011-08-11 Thread Andrew Nicols
Public bug reported: If a plugin has been installed, but then goes away (e.g. it is moved or the user wants to uninstall it by removing the plugin directory), this can cause various frustrations and site issues (unrecoverable error) which prevent all users from using any plugin. We should attempt

[Mahara-contributors] [Bug 819396] Re: Add unit testing to Mahara

2011-08-01 Thread Andrew Nicols
Another thought - once this is here, we need to consider the 'best' way of running these tests. Not sure whether we want to run the unit tests on every gerrit push or not? -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https:/

[Mahara-contributors] [Bug 819396] Re: Add unit testing to Mahara

2011-08-01 Thread Andrew Nicols
As I say, I've updated the original branch. I'm awaiting some feedback on how best to integrate Penny's commits (e.g. squash commits) using gerrit. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs

[Mahara-contributors] [Bug 819396] [NEW] Add unit testing to Mahara

2011-08-01 Thread Andrew Nicols
that this should go in to 1.5 to allow us to test the various new features which are planned more thoroughly. ** Affects: mahara Importance: Wishlist Assignee: Andrew Nicols (dobedobedoh) Status: New ** Tags: core infrastructure phpunit test unit ** Changed in: m

[Mahara-contributors] [Bug 818045] Re: Check repo for viruses to pass minaccept

2011-07-29 Thread Andrew Nicols
Commit added to gerrit ** Changed in: mahara Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/818045 Title: Check repo for viruses to pass minaccept Statu

[Mahara-contributors] [Bug 818045] Re: Check repo for viruses to pass minaccept

2011-07-29 Thread Andrew Nicols
I'd prefer to see this in every supported release -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/818045 Title: Check repo for viruses to pass minaccept Status in Mahara ePortfolio: New Bu

[Mahara-contributors] [Bug 818045] [NEW] Check repo for viruses to pass minaccept

2011-07-29 Thread Andrew Nicols
Public bug reported: It would be beneficial to protect ourselves from somehow adding a virus to the repo. I know it's less likely now we have peer review with gerrit, but it could still be possible to accept some form of infected image etc. ** Affects: mahara Importance: Undecided S

[Mahara-contributors] [Bug 817940] [NEW] Session directories are created on every init

2011-07-29 Thread Andrew Nicols
Public bug reported: htdocs/auth/session.php has a "TEMPORARY: this will be REMOVED..." which has been in there for four years and since 0.7.0 It's not a major issue, and it serves the job of ensuring that the session directories exist, but this should be done at install time, and should have b

[Mahara-contributors] [Bug 817373] [NEW] Add ability to 'send now' on a forum post

2011-07-28 Thread Andrew Nicols
Public bug reported: Similar to bug #817372 it would be helpful if it were possible to send a forum post immediately, rather than waiting for the post delay. This is probably much harder to display to users in a meaningful fashion though... ** Affects: mahara Importance: Wishlist St

[Mahara-contributors] [Bug 817372] [NEW] Override forum post delay for individual groups and/or forums

2011-07-28 Thread Andrew Nicols
Public bug reported: It would be really helpful if it were possible to set the post delay for a forum at either the whole group level, or the individual forum level. This is particularly useful for forums such as the Support forum on mahara.org where timely responses to people's queries would prob

[Mahara-contributors] [Bug 803955] Re: Overridden site admin fields not disabled unless also stored in database

2011-06-30 Thread Andrew Nicols
This increases the amount of fields held in the $OVERRIDDEN. I don't think that this is a major problem as only the field name is stored in the array, not the field value. This doesn't handle plugin setting overrides, but none of the plugins handle this at present anyway. -- You received this bu

[Mahara-contributors] [Bug 803962] Re: Some overridden fields are not disabled in admin/site/options.php

2011-06-30 Thread Andrew Nicols
Submitted fix in https://reviews.mahara.org/#change,421 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/803962 Title: Some overridden fields are not disabled in admin/site/options.php Status

[Mahara-contributors] [Bug 803955] Re: Overridden site admin fields not disabled unless also stored in database

2011-06-30 Thread Andrew Nicols
Submitted fix in https://reviews.mahara.org/#change,420 ** Changed in: mahara Status: New => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/803955 Title: Overridden site a

[Mahara-contributors] [Bug 803962] [NEW] Some overridden fields are not disabled in admin/site/options.php

2011-06-30 Thread Andrew Nicols
Public bug reported: Some of the fields in admin/site/options.php don't have the disabled => in_array('foo', $OVERRIDDEN) option set Have patch, will submit Affects 1.4.x and master ** Affects: mahara Importance: Low Assignee: Andrew Nicols (dobedobedoh) S

[Mahara-contributors] [Bug 803955] [NEW] Overridden site admin fields not disabled unless also stored in database

2011-06-30 Thread Andrew Nicols
mahara Importance: Low Assignee: Andrew Nicols (dobedobedoh) Status: New ** Tags: config override variable -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/803955 Title: Overr

[Mahara-contributors] [Bug 800231] [NEW] Add New post link to the blog blocktype

2011-06-21 Thread Andrew Nicols
Public bug reported: It'd be great if we could link to the new blog post page from the block type in a page (for the owner user) ** Affects: mahara Importance: Wishlist Status: New ** Tags: bitesize blog blogpost journal -- You received this bug notification because you are a me

[Mahara-contributors] [Bug 785703] Re: Googledocs blocktype not enabled after upgrade

2011-05-21 Thread Andrew Nicols
p.s. Haven't confirmed this yet but didn't want to forget about it - will try and check tomorrow and verify. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/785703 Title: Googledocs blocktype

[Mahara-contributors] [Bug 785703] Re: Googledocs blocktype don't show

2011-05-21 Thread Andrew Nicols
Hmm. Might be worth checking whether the plugin enables itself when users are upgrading. Since it's now a core plugin it should be enabled IMO, unlike new plugins just placed in the relevant directory. ** Summary changed: - Googledocs blocktype don't show + Googledocs blocktype not enabled after

[Mahara-contributors] [Bug 598425] Re: Feature Request: Spell checker

2010-12-17 Thread Andrew Nicols
Fix hasn't been released yet -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/598425 Title: Feature Request: Spell checker Status in Mahara ePortfolio: Fix Committed Bug description: I th

[Mahara-contributors] [Bug 690713] [NEW] notify_user() gets stuck in a loop if an admin user has disabled their email

2010-12-15 Thread Andrew Nicols
Public bug reported: A change introduced by 4ce12125c10984b946f4061e517521cbb6322389 meant that if email_user threw an exception, the admin was sent an e-mail. If an admin user has email disabled, then mahara gets stuck in an email loop trying to send them e-mail informing them of the failure. Ha

[Mahara-contributors] [Bug 690713] Re: notify_user() gets stuck in a loop if an admin user has disabled their email

2010-12-15 Thread Andrew Nicols
Now pushed :) I opted for the get_class($e) option rather than catching the exception to reduce code duplication. ** Changed in: mahara Assignee: (unassigned) => Andrew Nicols (dobedobedoh) ** Changed in: mahara Status: New => Fix Committed -- You received this bug notifi

[Mahara-contributors] [Bug 689045] Re: Passwort reminder is not sent if user disables email in settings

2010-12-14 Thread Andrew Nicols
I've pushed a fix which warns a user if the recipient address is over the bounce threshold but attempts to send the e-mail even if e-mail has been disabled. ** Changed in: mahara Status: New => In Progress ** Changed in: mahara Assignee: (unassigned) => Andrew Nicols (

[Mahara-contributors] [Bug 689045] Re: Passwort reminder is not sent if user disables email in settings

2010-12-14 Thread Andrew Nicols
I'm going to push this with a tidy up - removing the catching of the EmailDisabledException in forgotpass and removing the language string relating to this. Probably get around to finishing it this afternoon. I don't think that it makes sense to make this a configuration option, but I wonder wheth

[Mahara-contributors] [Bug 537505] Re: Feature Request: Messages to other users should provide message text in email

2010-12-14 Thread Andrew Nicols
The infrastructure for this is already in place. Mahara uses the Variable Envelope Return Path (VERP) technique for it's bounced e-mail catcher which validates a bounced mail and increases a bounce-count for that user, eventually disabling e-mail for this user. It should be possible to add a case

[Mahara-contributors] [Bug 689045] Re: Passwort reminder is not sent if user disables email in settings

2010-12-13 Thread Andrew Nicols
Ahh. Rather than adding another parameter, we could add a variable to $user (after it's selected from the database) such that: forgotpass.php->forgotpass_submit we set $user->ignoredisabled = true; after $user is pulled from the database and before it's passed to email_user In email_user we modif

[Mahara-contributors] [Bug 689045] Re: Passwort reminder is not sent if user disables email in settings

2010-12-13 Thread Andrew Nicols
Hmmm. All e-mail is handled by the email_user function in lib/user.php. If e-mail is disabled, an exception is thrown (EmailDisabledException). There's only one check for disabled e-mail so it would be relatively easy to bypass this check. The question is how best to do so. We could add a paramete

[Mahara-contributors] [Bug 685642] Re: Locked crons cause duplicate key errors in postgres logs

2010-12-08 Thread Andrew Nicols
Ahem. I do apologise. I'd forgotten to push the commit, and you are indeed correct, I'd missed the DB_IGNORE_SQL_EXCEPTIONS. I've pushed in 981808d9ec2983efe2847ca27b78b57dd25264c2 Andrew -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed

[Mahara-contributors] [Bug 685642] Re: Locked crons cause duplicate key errors in postgres logs

2010-12-06 Thread Andrew Nicols
fixed that too. ** Changed in: mahara Status: New => Fix Committed ** Changed in: mahara Assignee: (unassigned) => Andrew Nicols (dobedobedoh) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.laun

[Mahara-contributors] [Bug 684963] Re: Reformating in auth_config.host_url.html

2010-12-05 Thread Andrew Nicols
Have removed trailing whitespace from patch and added bug ID to commit message. ** Changed in: mahara Assignee: (unassigned) => Andrew Nicols (dobedobedoh) ** Changed in: mahara Importance: Undecided => Low ** Changed in: mahara Status: New => In Progress -- You rece

[Mahara-contributors] [Bug 684963] Re: Reformating in auth_config.host_url.html

2010-12-05 Thread Andrew Nicols
Pushed 388eb21753ad14bcf4c6a742677f3dab097adb52 ** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/684963 Title: Reformating in

[Mahara-contributors] [Bug 685642] Re: Locked crons cause duplicate key errors in postgres logs

2010-12-05 Thread Andrew Nicols
** Patch added: "0001-Check-whether-record-exists-before-inserting-rather.patch" https://bugs.launchpad.net/mahara/+bug/685642/+attachment/1756688/+files/0001-Check-whether-record-exists-before-inserting-rather.patch -- You received this bug notification because you are a member of Mahara Co

[Mahara-contributors] [Bug 685642] [NEW] Locked crons cause duplicate key errors in postgres logs

2010-12-05 Thread Andrew Nicols
Public bug reported: This affects postgres, and may affect MySQL too. Although this is currently the intended behaviour of lib/cron.php->cron_lock(), and the SQLException is caught in the php, the error is still seen by the database and logged in the database server's logs. Although it's not actu

[Mahara-contributors] [Bug 685640] [NEW] If a cron function causes an exception, it's lock isn't removed

2010-12-05 Thread Andrew Nicols
Public bug reported: Came across this whilst looking at #685633 but thought that it deserved a separate bug. If a cron function causes an exception for whatever reason, then the cron will stop, but the lock isn't removed. The job then isn't tried again for another 24 hours. Whilst this is poss

[Mahara-contributors] [Bug 685633] Re: export_cleanup_old_exports cron causes exception and long-running cron if export directory doesn't exist

2010-12-05 Thread Andrew Nicols
Check whether the directory exists before instantiating the DirectoryIterator. I considered using check_dir_exists, which would create the directory and then allow the cron to be run, but felt that the cron probably wasn't the best place to create the directory -- it's a little counter intuitive t

[Mahara-contributors] [Bug 685633] [NEW] export_cleanup_old_exports cron causes exception and long-running cron if export directory doesn't exist

2010-12-05 Thread Andrew Nicols
68.254.230] * export_cleanup_old_exports() at /home/nicols/mahara/htdocs/lib/cron.php:149 [Sun Dec 05 21:13:32 2010] [error] [client 192.168.254.230] ** Affects: mahara Importance: Low Assignee: Andrew Nicols (dobedobedoh) Status: Fix Committed ** Tags: cron exports ** Chan

[Mahara-contributors] [Bug 684425] Re: remote username doesn't lowercase usernames

2010-12-05 Thread Andrew Nicols
tatus: New => Fix Committed ** Changed in: mahara Assignee: (unassigned) => Andrew Nicols (dobedobedoh) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/684425 Title: remote username d

[Mahara-contributors] [Bug 684425] [NEW] remote username doesn't lowercase usernames

2010-12-02 Thread Andrew Nicols
Public bug reported: One of our many moodles somehow managed to convert their usernames from camelcase to lowercase. They did this after a number of users had SSOd to moodle. As a result, auth_remote_user has the camelcase variants, and auth/user.php::User->find_by_instanceid_username() doesn't

[Mahara-contributors] [Bug 676461] Re: Admin user unable to login after installation - salt issue

2010-11-18 Thread Andrew Nicols
Hi Richard, Cheers - that sheds a bit of light on things! I've pushed my fix to master. Andrew -- Admin user unable to login after installation - salt issue https://bugs.launchpad.net/bugs/676461 You received this bug notification because you are a member of Mahara Contributors, which is subscr

[Mahara-contributors] [Bug 676461] Re: Admin user unable to login after installation - salt issue

2010-11-18 Thread Andrew Nicols
** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Assignee: (unassigned) => Andrew Nicols (dobedobedoh) ** Changed in: mahara Status: Confirmed => Fix Committed -- Admin user unable to login after installation - salt issue https://bugs.launchpad

[Mahara-contributors] [Bug 671720] Re: Openssl installed but mahara don't recognice it

2010-11-08 Thread Andrew Nicols
Hi, Can you please ensure that have installed the php openssl module installed. You've included a snippet from your apache configuration which suggests you have apache's mod_ssl, but this is *not* the same as the php openssl module. phpinfo will give you details as to which PHP modules are runni

[Mahara-contributors] [Bug 671456] [NEW] Some time/date settings in langconfig.php are not compatible with Windows

2010-11-05 Thread Andrew Nicols
Public bug reported: According to the note for %e on http://uk3.php.net/manual/en/function.strftime.php windows doesn't support the %e format. There's a cross-platform 'fix' for this which involves determining whether you're running windows and substr ing any %e to a %#d. I've not confirmed ho

[Mahara-contributors] [Bug 663281] [NEW] When replying to a forum post, add option to subscribe to the topic

2010-10-19 Thread Andrew Nicols
Public bug reported: I keep forgetting to subscribe to forum posts because there's no direct way of subscribing when you reply to a forum post. It'd be quite handy and really pretty easy to add this. Also may be worth adding an option to set the default state of the option as a per-user setting.

[Mahara-contributors] [Bug 655631] [NEW] Forum post downloads should be publicly available in a public forum

2010-10-06 Thread Andrew Nicols
Public bug reported: In a public forum (such as the mahara community forum), posts are readable when users are not logged in. However, any files attached to a post are only available when logged in. As a result, you can only see images posted inline in a forum post when logged in. This also affec

[Mahara-contributors] [Bug 643654] Re: artefact feedback file uploads don't use upload with JS

2010-10-05 Thread Andrew Nicols
Richard, when I tried to use the file upload, I was expecting it to behave in exactly the same way as other uploads - e.g. javascript upload without having to submit the form for the file to be uploaded. On deeper inspection, it appears that the file upload on the comments input areas don't even t

[Mahara-contributors] [Bug 654589] Re: Invalid password on CSV Upload gives a rubbish error message

2010-10-04 Thread Andrew Nicols
I went for the combination approach -- Invalid password on CSV Upload gives a rubbish error message https://bugs.launchpad.net/bugs/654589 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: Fix Committed

[Mahara-contributors] [Bug 654589] [NEW] Invalid password on CSV Upload gives a rubbish error message

2010-10-04 Thread Andrew Nicols
t one digit and two letters. ** Affects: mahara Importance: Low Assignee: Andrew Nicols (dobedobedoh) Status: Fix Committed ** Tags: creation language password user ** Changed in: mahara Status: New => Fix Committed -- Invalid password on CSV Upload gives a rubbish er

[Mahara-contributors] [Bug 652784] [NEW] Inserting a file with no description using tinymce gives default description of 'null'

2010-10-01 Thread Andrew Nicols
Public bug reported: Bug reproduced using master Steps to reproduce: * Login as a user * My Portfolio -> My Blog -> New Post * Add a new file using the attachments section * Using TinyMCE, Insert/Edit Image * Select the image from the 'Attached image' section * Description is set to 'null' Screen

[Mahara-contributors] [Bug 652784] Re: Inserting a file with no description using tinymce gives default description of 'null'

2010-10-01 Thread Andrew Nicols
** Attachment added: "image_description.png" https://bugs.launchpad.net/bugs/652784/+attachment/1661860/+files/image_description.png -- Inserting a file with no description using tinymce gives default description of 'null' https://bugs.launchpad.net/bugs/652784 You received this bug notific

[Mahara-contributors] [Bug 643647] Re: Inserting a file with no description using tinymce gives default description of 'null'

2010-10-01 Thread Andrew Nicols
Hi Eugene, Here are the steps I took: * Create a new post in admin's blog with a picture uploaded and displayed inline in the blog; * Add the 'Recent Blog Posts' (or any other Blog blocktype I should imagine) into the user's Profile View * Login as a new user * View admin's profile * View the ind

[Mahara-contributors] [Bug 643647] Re: Viewing a user's blog (whole blog) doesn't show images or allow downloads (Access Denied)

2010-10-01 Thread Andrew Nicols
Sorry - I was reporting a glut of related bugs at the same time and managed to get my wires crossed with the bug subjects. I've opened a new bug for the original title. -- Viewing a user's blog (whole blog) doesn't show images or allow downloads (Access Denied) https://bugs.launchpad.net/bugs/64

[Mahara-contributors] [Bug 646691] [NEW] Blog account settings still available when blog disabled

2010-09-24 Thread Andrew Nicols
Public bug reported: Reported in the forum: http://mahara.org/interaction/forum/topic.php?id=2303 I've already pushed a potential fix for this in merge request 10 - though on second thoughts testing all plugin types is a bad idea, and it's best kept at just artefacts (as the current status quo).

  1   2   >