[Mahara-contributors] [Bug 1576074] Re: Adopt PSR-2 for our PHP code format

2016-05-26 Thread Jono Mingard
I'm definitely in favour of having a JS coding standard as well - preferably an industry standard rather than trying to duplicate the PHP guidelines. http://jscs.info/overview has a list of common presets (and the tool itself might be useful for checking and autoformatting). As far as I know, AirB

[Mahara-contributors] [Bug 1482470] Re: Position and configure block dialogs no longer have focus management

2015-10-22 Thread Jono Mingard
This is mostly OK now, but there is still an issue when adding a block: when you press "Add" in the Add block dialog, focus does not go to the close button of the configure dialog. That dialog does have the dialog role so modern screen readers should pick it up (and lock focus to it), but it's stil

[Mahara-contributors] [Bug 1507928] Re: "Login" link not shown on small screens when login box is not available

2015-10-22 Thread Jono Mingard
** Changed in: mahara/16.04 Status: Confirmed => Fix Committed ** Changed in: mahara/15.10 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for

[Mahara-contributors] [Bug 1490569] Re: Sort submitted pages "Most recently submitted" doesn't work

2015-10-21 Thread Jono Mingard
This is now fixed in both 15.04 and 15.10, BUT the group pages block does not update when you click "Save" - you need to refresh the page before the new sort order takes effect. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. M

[Mahara-contributors] [Bug 1508760] [NEW] Rows added to artefact_file_embedded when editing Note not in a page

2015-10-21 Thread Jono Mingard
Public bug reported: When a Note is removed from all pages it is in, any embedded images in the note have their entries removed from the artefact_file_embedded table (since the note can't be shared they aren't needed). However, if you then edit the note from the Notes area and click Save, the embe

[Mahara-contributors] [Bug 1472446] Re: Add MathSlate TinyMCE plugin

2015-10-14 Thread Jono Mingard
** Changed in: mahara Milestone: 15.10.0 => 16.04.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before e

[Mahara-contributors] [Bug 1482448] Re: Help links should include the form element they refer to in their alt text

2015-10-08 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1497053] Re: Cron error with over 65535 users

2015-10-07 Thread Jono Mingard
ress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev

[Mahara-contributors] [Bug 1482480] Re: Add row button in custom layout creator should have focus management

2015-09-27 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1486817] Re: Incorrect label setup when creating custom layout

2015-09-27 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) ** Changed in: mahara Importance: Low => Medium -- You received this bug notification because you are a member of Mahara Contributors,

[Mahara-contributors] [Bug 1489700] Re: Switches don't show 'disabled' state

2015-09-27 Thread Jono Mingard
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org foru

[Mahara-contributors] [Bug 1482453] Re: "Skip to main content" link isn't visible on focus

2015-09-27 Thread Jono Mingard
** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org foru

[Mahara-contributors] [Bug 1492081] Re: Accessibility problems with select2 4.0

2015-09-27 Thread Jono Mingard
The keyboard controls for select2 are still ... unusual, so some explanation probably needs to be added to the user manual. Basically: - To open the selection dropdown, focus on the combo box and press Enter twice. Screen reader users should hear "Please enter 1 or more characters" - Use the arro

[Mahara-contributors] [Bug 1482458] Re: Bootstrap tabs are not accessible

2015-09-27 Thread Jono Mingard
Hi, I wasn't able to fix this bug entirely, so the user manual should probably be updated to specify how screen reader users can use the tabs. The tabs don't work if you focus them using the arrow keys, so you need to focus them using the Tab key in order to switch tabs. ** Tags added: usermanual

[Mahara-contributors] [Bug 1499583] Re: get_string_ajax() doesn't work properly with arguments

2015-09-24 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum be

[Mahara-contributors] [Bug 1482456] Re: Pages should include an ARIA "main" landmark

2015-09-24 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum be

[Mahara-contributors] [Bug 1482456] Re: Pages should include an ARIA "main" landmark

2015-09-24 Thread Jono Mingard
** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev

[Mahara-contributors] [Bug 1499583] Re: get_string_ajax() doesn't work properly with arguments

2015-09-24 Thread Jono Mingard
One way to verify this: in Firebug (or whatever) enter "get_string_ajax('deletespecific', 'mahara', '1')" then a few seconds later enter "get_string_ajax('deletespecific', 'mahara', '2')". The output from the second command should be "Delete "2"" but is "Delete "1"" -- You received this bug notif

[Mahara-contributors] [Bug 1499583] [NEW] get_string_ajax() doesn't work properly with arguments

2015-09-24 Thread Jono Mingard
ce: Medium Assignee: Jono Mingard (mingard) Status: Confirmed ** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notif

[Mahara-contributors] [Bug 1440931] Re: Compose form is too wide on small screens

2015-09-24 Thread Jono Mingard
No longer relevant thanks to the new Bootstrap themes ** Changed in: mahara Status: Confirmed => Invalid -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -

[Mahara-contributors] [Bug 1487246] Re: Close button on initial configure dialog does not delete block

2015-09-23 Thread Jono Mingard
Fixed in https://reviews.mahara.org/#/c/5269/ ** Changed in: mahara Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -

[Mahara-contributors] [Bug 1497053] [NEW] Cron error with over 65535 users

2015-09-17 Thread Jono Mingard
Public bug reported: I discovered another case of things failing when there are too many users to substitute IDs as question marks in a postgres query - specifically, when running cron on a site with ~68000 users I get: [WAR] 3f (lib/dml.php:480) Failed to get a recordset: postgres8 error: [-1:

[Mahara-contributors] [Bug 1496683] [NEW] Unescaped 'title' strings used in pieforms elements

2015-09-16 Thread Jono Mingard
aped everywhere it's used (to be consistent). To complicate things, there's an optional 'labelescaped' attribute that can be added to elements which (contrary to the name) means the label *shouldn't* be escaped. Affects latest master ** Affects: mahara Impor

[Mahara-contributors] [Bug 1265089] Re: Dual listbox (in Admin) is not easily accessible to screen readers

2015-09-10 Thread Jono Mingard
** Description changed: + *** Superseded and fixed in Bug #1489245 + In pages such as /admin/users/staff.php and /admin/users/admins.php, staff or administrators are chosen by selecting items in one list then clicking a button to transfer them to another list. However, the buttons do not have

[Mahara-contributors] [Bug 1489245] Re: Two-way list boxes (eg. in Site staff) have no button labels

2015-09-10 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1489243] Re: Incorrect labels in user name filters (Admin -> User search)

2015-09-10 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1482446] Re: Alerts and status messages should be ARIA alerts

2015-09-09 Thread Jono Mingard
These work when using ChromeVox, so I assume this is a JAWS-specific bug (maybe to do with having multiple alerts on the page when the site is not in production mode). Closing, but feel free to reopen if something like this crops up again. ** Changed in: mahara Status: Incomplete => Invalid

[Mahara-contributors] [Bug 1492081] Re: Accessibility problems with select2 4.0

2015-09-09 Thread Jono Mingard
rting to type) - however, an alternative could be to include this as an accessible description on the page itself. Affects latest master ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) ** Changed in: mahara Status: Confirmed => In Progress --

[Mahara-contributors] [Bug 1492102] Re: Moving files with the keyboard no longer works

2015-09-03 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum be

[Mahara-contributors] [Bug 1492103] Re: Numbers in pagination are read twice by screen readers

2015-09-03 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum be

[Mahara-contributors] [Bug 1487246] Re: Close button on initial configure dialog does not delete block

2015-09-03 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum be

[Mahara-contributors] [Bug 1492102] Re: Moving files with the keyboard no longer works

2015-09-03 Thread Jono Mingard
** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev

[Mahara-contributors] [Bug 1492103] Re: Numbers in pagination are read twice by screen readers

2015-09-03 Thread Jono Mingard
** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev

[Mahara-contributors] [Bug 1492102] [NEW] Moving files with the keyboard no longer works

2015-09-03 Thread Jono Mingard
Public bug reported: With the new Bootstrap themes, users are no longer able to move files and folders in the file browser using the keyboard. The desired functionality is - Press Enter on the file icon, which will open a list of possible folders to move the file to - Select a folder and press E

[Mahara-contributors] [Bug 1492103] [NEW] Numbers in pagination are read twice by screen readers

2015-09-03 Thread Jono Mingard
Public bug reported: When navigating the paginator in places like "Portfolio", screen readers read out each page number twice: when focused on "1" they read "11", etc. Presumably there is hidden text somewhere in the element that is causing this. Affects latest master ** Affects: mahara Imp

[Mahara-contributors] [Bug 1492081] [NEW] Accessibility problems with select2 4.0

2015-09-03 Thread Jono Mingard
Public bug reported: Mahara has recently upgraded to select2 4.0, but there appear to be outstanding accessibility issues with this version, eg. https://github.com/select2/select2/issues/3735 These need to be evaluated and fixed (more info coming when I've found out how serious they are ...) I

[Mahara-contributors] [Bug 1487246] Re: Close button on initial configure dialog does not delete block

2015-09-02 Thread Jono Mingard
** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) ** Changed in: mahara Status: New => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription f

[Mahara-contributors] [Bug 1489700] Re: Switches don't show 'disabled' state

2015-09-02 Thread Jono Mingard
** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Importance: Undecided => Medium ** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug

[Mahara-contributors] [Bug 1482490] Re: New toggles are confusing for screen reader users

2015-08-27 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1489700] [NEW] Switches don't show 'disabled' state

2015-08-27 Thread Jono Mingard
Public bug reported: For example: Go to Groups -> Create group (http://mahara/group/edit.php). Some of the new-style switches in this form may be disabled (eg. "Request", "Allow archiving of submissions") but they don't look any different - clicking them seems like it should work, but they don't t

[Mahara-contributors] [Bug 1482461] Re: "Add block" accordion has useful descriptions only available to screen reader users

2015-08-27 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1484779] Re: Expanders in Site options are all ARIA-expanded by default

2015-08-27 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1487294] Re: Focus management needed in Resume forms

2015-08-27 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1487304] Re: When creating a folder, focus should go to the new folder

2015-08-27 Thread Jono Mingard
** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1482469] Re: Expand/contract accordion button has no accessible text

2015-08-26 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1487301] Re: Selected tab not indicated in "Shared by me"

2015-08-26 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1487290] Re: Better accessible text for inbox header link

2015-08-26 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1487292] Re: Close buttons in help boxes don't have alt text

2015-08-26 Thread Jono Mingard
** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1489259] [NEW] Edit/delete buttons under iframe sources are not accessible

2015-08-26 Thread Jono Mingard
Public bug reported: In Administration -> Allowed iframe sources, the accessibility features of the edit and delete buttons in the table are somewhat inconsistent, and the edit button is actually broken. In particular: - When using JAWS, pressing Enter on the edit button jumps to the top of the

[Mahara-contributors] [Bug 1489258] [NEW] Unnecessary labels on buttons in Plugin administration

2015-08-26 Thread Jono Mingard
Public bug reported: In Administration -> Plugin administration, each "Show" and "Hide" button has a hidden label associated with it. This isn't actually necessary and is confusing for screen reader users since it appears that there is plain text in front of each button with the same text as the b

[Mahara-contributors] [Bug 1489254] [NEW] When creating an institution "Locked fields" is ARIA-expanded by default

2015-08-26 Thread Jono Mingard
Public bug reported: Another case of a collapsed expander having the attribute ARIA- expanded="1" by default: When adding or editing an institution there is a "Locked fields" section at the bottom of the form which is collapsed by default - its ARIA state should reflect this. Affects latest maste

[Mahara-contributors] [Bug 1489256] [NEW] Confusing description and title when adding or editing institution

2015-08-26 Thread Jono Mingard
Public bug reported: When adding or editing an institution (from Administration -> Institutions), the page title is still "Institutions". This needs to be changed to something more descriptive to be properly accessible. In addition, when adding an institution the at the top of the page still rea

[Mahara-contributors] [Bug 1489252] [NEW] Authentication plugin form element is not accessible

2015-08-26 Thread Jono Mingard
Public bug reported: When configuring an institution (Administration -> Institutions -> Edit) there is an option to change the authentication methods available to that institution. However, there are various accessibility issues with the form element used to configure this: - The "Add" combo box

[Mahara-contributors] [Bug 1489249] [NEW] No search box label in Manage institutions

2015-08-26 Thread Jono Mingard
Public bug reported: In Administration -> Institutions, there is a search box above the table of institutions which doesn't have an associated hidden label. A "Search" label needs to be added like for similar forms around the rest of the site. Affects latest master ** Affects: mahara Import

[Mahara-contributors] [Bug 1489245] [NEW] Two-way list boxes (eg. in Site staff) have no button labels

2015-08-26 Thread Jono Mingard
Public bug reported: For adding and removing users from the staff or administrators list of an institution (eg. in Administration -> Site staff), there are two list boxes with buttons to move users from one to the other. However, the buttons to move users in these list boxes don't have labels, whi

[Mahara-contributors] [Bug 1489243] [NEW] Incorrect labels in user name filters (Admin -> User search)

2015-08-26 Thread Jono Mingard
Public bug reported: On the User search page it is possible to filter users by the first letter of their first or last name. However, these links have the aria- labelledby attribute set to the label of the group, so screen readers only read out "First name" or "Last name" instead of the actual let

[Mahara-contributors] [Bug 1487308] [NEW] All inbox messages are ARIA-expanded by default

2015-08-20 Thread Jono Mingard
Public bug reported: Related to Bug #1484779 In the Inbox, messages are now shown as expanders with the aria-expanded attribute showing their state. By default they all have the attribute aria-expanded="1" even though they are all collapsed. This should therefore be changed to aria-expanded="fals

[Mahara-contributors] [Bug 1487306] [NEW] Move the "select" checkbox out of item heading in Inbox

2015-08-20 Thread Jono Mingard
Public bug reported: In the Inbox, all notifications have a "Select" checkbox as part of the panel header. This is wrapped in an , which causes screen readers such as JAWS to read out the checkbox strangely. It would be nice to make the panel header a and have a heading inside it containing just

[Mahara-contributors] [Bug 1487299] Re: All edit and delete buttons should contain the name of what they manage

2015-08-20 Thread Jono Mingard
** Description changed: Reopening Bug #1276397 - in the new Bootstrap theme, all edit and delete buttons seem to have descriptive text attached to them ("Edit" and "Delete"), but it is sometimes ambiguous for screen reader users which list item they refer to. In particular: - On the M

[Mahara-contributors] [Bug 1487301] [NEW] Selected tab not indicated in "Shared by me"

2015-08-20 Thread Jono Mingard
Public bug reported: In the new Bootstrap theme, the tabs on the "Shared by me" page use ARIA attributes, but both are marked as deselected on page load. The selected tab ("Collections") should have aria-selected="true". Affects latest master ** Affects: mahara Importance: Medium S

[Mahara-contributors] [Bug 1487304] [NEW] When creating a folder, focus should go to the new folder

2015-08-20 Thread Jono Mingard
Public bug reported: In the file browser (eg. Content -> Files) there is an option to "Create folder", which adds a new folder with AJAX. To make sure screen reader users are aware that this has worked, focus should be set to the newly created folder. Affects latest master ** Affects: mahara

[Mahara-contributors] [Bug 1487299] [NEW] All edit and delete buttons should contain the name of what they manage

2015-08-20 Thread Jono Mingard
Public bug reported: Reopening Bug #1276397 - in the new Bootstrap theme, all edit and delete buttons seem to have descriptive text attached to them ("Edit" and "Delete"), but it is sometimes ambiguous for screen reader users which list item they refer to. In particular: - On the My groups page,

[Mahara-contributors] [Bug 1487294] Re: Focus management needed in Resume forms

2015-08-20 Thread Jono Mingard
** Description changed: With the new Bootstrap theme, forms to add content to the Resume (eg. under Education and employment / Achievements) are displayed inline when the "Add" button is clicked. These need to have focus management so that it is clear to screen reader users what has happen

[Mahara-contributors] [Bug 1487294] [NEW] Focus management needed in Resume forms

2015-08-20 Thread Jono Mingard
Public bug reported: With the new Bootstrap theme, forms to add content to the Resume (eg. under Education and employment / Achievements) are displayed inline when the "Add" button is clicked. These need to have focus management so that it is clear to screen reader users what has happened. In part

[Mahara-contributors] [Bug 1487292] [NEW] Close buttons in help boxes don't have alt text

2015-08-20 Thread Jono Mingard
Public bug reported: When one of the blue "i" links is clicked, an ARIA-enabled help dialog is shown and focus is set to the close button of the dialog. However, this close button has an icon and no accessible text - text such as "Close" should be added so that it is clear to screen reader users w

[Mahara-contributors] [Bug 1487290] [NEW] Better accessible text for inbox header link

2015-08-20 Thread Jono Mingard
Public bug reported: The Inbox link in the header currently only contains the number of unread messages, making it confusing for screen reader users. There should be hidden text added so that it's clear what the link does ("Inbox: 7" would be good enough). Affects latest master ** Affects: mahar

[Mahara-contributors] [Bug 1487246] [NEW] Close button on initial configure dialog does not delete block

2015-08-20 Thread Jono Mingard
Public bug reported: In latest master when adding a block to a page, clicking the "X" button in the Configure dialog pops up a warning asking if you want to delete the block, and does actually delete it from the database. However, unlike when you click the Remove button it doesn't remove the block

[Mahara-contributors] [Bug 1486826] [NEW] "make minaccept" should skip code in third-party libraries

2015-08-19 Thread Jono Mingard
Public bug reported: Currently, "make minaccept" checks the code style of all changed lines in the latest git commit. This is usually a good thing, but falls down when a third-party library is added which doesn't follow Mahara's code style. The current convention for including third-party code is

[Mahara-contributors] [Bug 1482450] Re: TinyMCE instances should link to their form labels

2015-08-19 Thread Jono Mingard
It might actually be possible to add an aria-label or aria-labelledby attribute to the TinyMCE iframe (see http://stackoverflow.com/questions/4258701/tinymce-accessibility-label- for), although I'm not sure how straightforward this would be -- You received this bug notification because you are a

[Mahara-contributors] [Bug 1482491] Re: Date picker checkbox needs a more descriptive label

2015-08-19 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1482469] Re: Expand/contract accordion button has no accessible text

2015-08-19 Thread Jono Mingard
The button also has the same title attribute as the "External" tab above it - presumably not intended ** Changed in: mahara Status: New => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions

[Mahara-contributors] [Bug 1486817] [NEW] Incorrect label setup when creating custom layout

2015-08-19 Thread Jono Mingard
Public bug reported: Steps to reproduce - "Edit layout" on any page - Open "Create custom layout", change some stuff and click "Create new layout" - Without refreshing the page, inspect the newly created radio button and its associated label The radio button ID and label 'for' attribute don't m

[Mahara-contributors] [Bug 1482446] Re: Alerts and status messages should be ARIA alerts

2015-08-19 Thread Jono Mingard
Actually these do seem to be marked as alerts - need to do more testing to see if it's a problem with a particular screen reader or theme ** Changed in: mahara Status: Confirmed => Incomplete -- You received this bug notification because you are a member of Mahara Contributors, which is s

[Mahara-contributors] [Bug 1482452] Re: Default focus outline is too pale

2015-08-19 Thread Jono Mingard
Note: this actually works well for ordinary links, because an underline is shown on focus in addition to the pale outline. The main time this is not clear is with image links, eg. the site logo in the top left corner and the "Powered by Mahara" logo at the bottom -- You received this bug notifica

[Mahara-contributors] [Bug 1482453] Re: "Skip to main content" link isn't visible on focus

2015-08-19 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1484780] Re: Would be nice to have a "Reply" link in inbox block

2015-08-19 Thread Jono Mingard
(Notice how the friend request contains a link to go to requests, but the message doesn't have any links at the bottom) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contrib

[Mahara-contributors] [Bug 1484780] Re: Would be nice to have a "Reply" link in inbox block

2015-08-19 Thread Jono Mingard
Yes, I have the same when going to the Inbox page - it's specifically the Dashboard block I was referring to. Probably should have clarified with a screenshot ... ** Attachment added: "mahara-inbox-block.png" https://bugs.launchpad.net/mahara/+bug/1484780/+attachment/4449097/+files/mahara-inbo

[Mahara-contributors] [Bug 1482461] Re: "Add block" accordion has useful descriptions only available to screen reader users

2015-08-13 Thread Jono Mingard
** Description changed: Each button in the page editor's "Add block" accordion has a screen- reader-only description (eg. "Image" is described as "A single image from your files area"). This is actually quite useful, so it would be nice if this could be accessed by sighted users as well (e

[Mahara-contributors] [Bug 1484791] [NEW] Use headers in forms

2015-08-13 Thread Jono Mingard
Public bug reported: Various forms in Mahara contain elements grouped under headers, for example "Membership" on the Edit group page (/group/edit.php). These would be more accessible if they were wrapped in the element, as screen reader users would hear them when navigating their attached control

[Mahara-contributors] [Bug 1482462] Re: Buttons in page editor accordion still contain radio inputs

2015-08-13 Thread Jono Mingard
Update: These radio buttons are not visible and not read out in the Raw or Default theme, so although they don't seem to do anything, they don't actually cause any problems. ** Changed in: mahara Importance: Medium => Wishlist -- You received this bug notification because you are a member of

[Mahara-contributors] [Bug 1484786] [NEW] Consider having a search button on the top search form

2015-08-13 Thread Jono Mingard
Public bug reported: The top-level search form no longer has a search button, unlike most other search forms (eg. Portfolio -> Pages). In the interest of consistency it might be good to have an explicit search button on the top form as well, rather than relying on the user knowing they need to pre

[Mahara-contributors] [Bug 1484781] [NEW] Font Awesome icons cause screen reader weirdness

2015-08-13 Thread Jono Mingard
Public bug reported: With the new Font Awesome icons in Mahara 15.10, the JAWS screen reader reads each icon as "Unknown character". This also messes up link order when using JAWS' "List links" feature. Since the icons use the :before CSS pseudo-element, I suspect this is unfixable (and a problem

[Mahara-contributors] [Bug 1484780] [NEW] Would be nice to have a "Reply" link in inbox block

2015-08-13 Thread Jono Mingard
Public bug reported: With my copy of latest master, messages from other users in the "Inbox" dashboard block don't have a "Reply" or "More ..." link when expanded. I can't remember whether this link existed in previous versions, but either way it would be good to be able to reply to messages strai

[Mahara-contributors] [Bug 1484779] [NEW] Expanders in Site options are all ARIA-expanded by default

2015-08-13 Thread Jono Mingard
Public bug reported: In 15.10, the sections in Site options (/admin/site/options.php) use new Bootstrap expanders, with the ARIA-expanded attribute added for accessibility. However, on page load all the expanders have the attribute aria-expanded="1" despite being collapsed by default. This needs t

[Mahara-contributors] [Bug 1482458] Re: Bootstrap tabs are not accessible

2015-08-12 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1482474] Re: "Basic options" expander in layout editor is ARIA-collapsed by default

2015-08-12 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => Won't Fix ** Changed in: mahara Status: Won't Fix => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Con

[Mahara-contributors] [Bug 1482492] Re: Hour and minute combo boxes in date picker have no labels

2015-08-12 Thread Jono Mingard
** Changed in: mahara Status: Confirmed => In Progress ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1482470] Re: Position and configure block dialogs no longer have focus management

2015-08-12 Thread Jono Mingard
** Changed in: mahara Status: New => Confirmed ** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors,

[Mahara-contributors] [Bug 1482455] Re: Dropdown menus are no longer keyboard-accessible

2015-08-12 Thread Jono Mingard
** Changed in: mahara Assignee: (unassigned) => Jono Mingard (mingard) ** Changed in: mahara Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscr

[Mahara-contributors] [Bug 1482493] [NEW] Accent colour in Raw theme is too low contrast

2015-08-06 Thread Jono Mingard
Public bug reported: The new Bootstrap-based Raw theme is mostly pretty good in terms of accessibility, but the bright green accent colour used on buttons and links isn't high enough contrast to meet WCAG 2 guidelines. According to http://leaverou.github.io/contrast-ratio/ the contrast ratio betwe

[Mahara-contributors] [Bug 1482491] [NEW] Date picker checkbox needs a more descriptive label

2015-08-06 Thread Jono Mingard
Public bug reported: The checkboxes used the date/time pickers on the Group settings page do have screen-reader-accessible labels, but the labels only read "Set date". This is confusing since there appear to be two identical versions of the form, so the labels should be changed to include the comp

[Mahara-contributors] [Bug 1482492] [NEW] Hour and minute combo boxes in date picker have no labels

2015-08-06 Thread Jono Mingard
Public bug reported: In the date picker used on the Group settings page, the first three combo boxes (year, month, day) have screen reader accessible labels describing the control. However, the last two (hour and minute) have no such label, and screen reader users would find it hard to figure out

[Mahara-contributors] [Bug 1482490] [NEW] New toggles are confusing for screen reader users

2015-08-06 Thread Jono Mingard
Public bug reported: The new toggle-style checkboxes (used, for example, in the user settings page) are mostly accessible, but can be confusing to screen reader users because they include both "On" and "Off" text regardless of whether they are checked or unchecked. This text uses CSS :before and :

[Mahara-contributors] [Bug 1482482] [NEW] Group settings and delete buttons should contain name of group

2015-08-06 Thread Jono Mingard
Public bug reported: When viewing "My pages", the edit and delete buttons contain screen- reader-accessible text specifying which page will be edited or deleted. However, in the My groups list, the settings and delete buttons don't contain the same level of information. This makes it hard to know

[Mahara-contributors] [Bug 1482480] [NEW] Add row button in custom layout creator should have focus management

2015-08-06 Thread Jono Mingard
Public bug reported: When creating a custom layout, the "Add a row" button creates a new row editor with JavaScript. To make sense for screen reader users, it should also focus the new row - probably the "Number of columns" combo box since it's the first control in the new form. Affects latest ma

[Mahara-contributors] [Bug 1482479] [NEW] Combo boxes in custom layout creator should have better labels

2015-08-06 Thread Jono Mingard
Public bug reported: When creating a custom layout, combo boxes labelled "Number of columns" and "Column layout" show up. These labels are descriptive, but it can be ambiguous to a screen reader user which row they refer to. It would be useful to include extra hidden text so that their labels are

[Mahara-contributors] [Bug 1482474] [NEW] "Basic options" expander in layout editor is ARIA-collapsed by default

2015-08-06 Thread Jono Mingard
Public bug reported: "Basic options" is the default expander in the page layout editor and is expanded by default. However, (probably due to something in the bootstrap-accessibility library) it has the attribute aria- expanded=false added to it by default, making it confusing for screen reader use

[Mahara-contributors] [Bug 1482473] [NEW] Reword block position selection combobox

2015-08-06 Thread Jono Mingard
Public bug reported: When positioning a block using the keyboard (after clicking on one of the block type buttons), the default option in the "Position" combobox is "Top of column". That's not strictly correct, however, and if there are multiple rows in a page it becomes confusing - "Top of cell"

[Mahara-contributors] [Bug 1482471] [NEW] It would be nice to have a for the cell selector in the position block dialog

2015-08-06 Thread Jono Mingard
Public bug reported: The radio buttons to choose which cell a new block should be created in function well for screen reader and keyboard users, but it would be nice to have a element (saying "Cell", for example) associated with them to make their purpose more explicit. Affects latest master **

[Mahara-contributors] [Bug 1482470] [NEW] Position and configure block dialogs no longer have focus management

2015-08-06 Thread Jono Mingard
Public bug reported: With the new Bootstrap theme, it is still possible to add blocks using the keyboard (by pressing Enter when focused on a block type in the accordion) but the dialogs that appear no longer have focus management, making it appear to screen reader users as if nothing has happened

  1   2   3   4   5   6   >