Reviewed: https://reviews.mahara.org/2800 Committed: http://gitorious.org/mahara/mahara/commit/2f41bf3c10974b1c537236e9390bf28ae8ba4202 Submitter: Robert Lyon (robe...@catalyst.net.nz) Branch: master
commit 2f41bf3c10974b1c537236e9390bf28ae8ba4202 Author: Son Nguyen <son.ngu...@catalyst.net.nz> Date: Mon Dec 16 09:28:43 2013 +1300 Using empty() instead of is_null (Bug 1095934) Change-Id: I32cf198a8fa33a9e9773a752c6b32ce5fa079c7b Signed-off-by: Son Nguyen <son.ngu...@catalyst.net.nz> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1095934 Title: cleanurl's only checks !is_null, but a urlid could be '' Status in Mahara ePortfolio: Fix Committed Bug description: group_homepage_url lib/group.php line 2351 There was a problem where the links only showed /group/, but no id, I think this is to do with the $group->urlid being '', which is not null, but empty. I suggest using empty instead. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1095934/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
