[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-23 Thread Aaron Wells
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org for

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-07 Thread Aaron Wells
Yeah, those BOM's are pretty sneaky. It didn't show up on any of my text editors either. The only program I could actually see it in was the command-line version of "git diff". I had to track it down by trial and error -- the program continued to fail when I deleted all the contents of skin.php; it

Re: [Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-07 Thread Mike Kelly
Hi Aaron, I just got your messages on this. Your BOM bug fix worked here. Thanks, Mike Mike Kelly Learning Technologies Developer University of the Arts London Centre for Learning and Teaching in Art and Design (CLTAD) 272 High Holborn London WC1V 7EY United Kingdom Tel: +44 (0)20 7514 6206 Webs

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-07 Thread Mike Kelly
Good catch. I had to create a completely new skin.php file here and copy the content across. The BOM wasn't visible in the original file even when I was displaying invisible characters. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to M

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-06 Thread Aaron Wells
** Changed in: mahara Status: Confirmed => Fix Committed ** Changed in: mahara Assignee: Son Nguyen (ngson2000) => Aaron Wells (u-aaronw) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subs

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-06 Thread Aaron Wells
https://reviews.mahara.org/2580 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-06 Thread Aaron Wells
I just had the same porblem. It turned out there was a BOM ( http://en.wikipedia.org/wiki/Byte_order_mark ) at the beginning of lang/en.utf8/skin.php, and PHP isn't great at handling those. I now realize this was sort of obvious because it's mentioned in the first line of that error: "output start

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-06 Thread Aaron Wells
** Changed in: mahara Status: Incomplete => Confirmed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum bef

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-03 Thread Aaron Wells
** Changed in: mahara Status: New => Incomplete ** Changed in: mahara Importance: Undecided => High -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors --

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-03 Thread Aaron Wells
Hi Mike, Oh, or better yet, do a "view HTML source" on one of the affected pages and see what's printed on the very first line. That may give us some idea of what is being output before the headers. Cheers again, Aaron -- You received this bug notification because you are a member of Mahara Con

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-03 Thread Aaron Wells
Hi Mike, "Output before headers sent" can be a tough one to track down. It just means header() got called after something, *anything*, printed some output. This can be as simple as an empty line before "" in one file. So, that said, I'm able to replicate this error if I put some whitespace outsid

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-01 Thread Aaron Wells
** Changed in: mahara Assignee: (unassigned) => Son Nguyen (ngson2000) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahar

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-10-01 Thread Mike Kelly
Yes, I'm getting the same error from the admin pages too. Strange one. Maybe I've missed something? I checked again just now - checked out commit 92356eb6a27337280e4e21659397a4dc9e62b81e (Version bump for 1.8rc2dev) and installed to a new database. Same error. -- You received this bug notificat

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-09-30 Thread Robert Lyon
Hmm, now that I read the error messages it looks to be wigging out on line 496 of the lib/pieforms/pieform.php file. which is a header('Location: ') call, which should be reached if one hit cancel in a form (not when they are saving it). Skins can be made both in the Portfolio -> Skins section a

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-09-30 Thread Robert Lyon
I suspect it might be the form rendering code being mixed in with smarty template code and has a select dropdown in the form. -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara C

[Mahara-contributors] [Bug 1233171] Re: Can't save custom skin

2013-09-30 Thread Aaron Wells
** Changed in: mahara Milestone: None => 1.8.0 ** Tags added: skins -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.o