I have a proposed patch ... will update tomorrow.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing
Added patch.
This shows the generic notfound icon for a comment when there is no user
account associated with the comment.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Con
** Patch added: "1300289.mahara18.patch"
https://bugs.launchpad.net/mahara/+bug/1300289/+attachment/4057488/+files/1300289.mahara18.patch
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription
** Changed in: mahara
Assignee: (unassigned) => Robert Lyon (robertl-9)
** Changed in: mahara
Milestone: None => 1.10.0
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Maha
** Changed in: mahara
Status: New => Confirmed
** Changed in: mahara
Importance: Undecided => Medium
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors --
Hi Brian,
Thank you for the patch.
I've taken the patch you supplied and simplified it a little bit so that if no
user is passed to profile_icon_url it gives us the
no_userphoto icon rather than needing a new Dwoo function to handle this.
See https://reviews.mahara.org/#/c/3202/
Cheers
Robert
** Changed in: mahara
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org foru
** Also affects: mahara/1.8
Importance: Undecided
Status: New
** Also affects: mahara/1.9
Importance: Undecided
Status: New
** Changed in: mahara/1.8
Milestone: None => 1.8.3
** Changed in: mahara/1.9
Milestone: None => 1.9.0
** Changed in: mahara/1.8
Importance:
For the record, the patch that caused this regression was
https://reviews.mahara.org/#/c/2347/ , Evonne's big theme patch. It
appears she just accidentally removed an "if" clause from the comment
template.
--
You received this bug notification because you are a member of Mahara
Contributors, whic
** Changed in: mahara/1.9
Status: Fix Committed => Fix Released
** Changed in: mahara/1.8
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription
** Changed in: mahara/1.8
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org
** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org for
12 matches
Mail list logo
