Patch for "master" branch: https://reviews.mahara.org/4401
-- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1431668 Title: Annotation "feedback" Javascript breaks on clean-urls and sites in subdirectories Status in Mahara ePortfolio: In Progress Bug description: In artefact/annotation/js/annotation.js, in the function "connectAnnotationFeedbackLinks()", there's a check for "window.location.pathname == '/view/view.php'", meant to make sure that the link only gets activated via Javascript when you're viewing a page. However, this breaks in two scenarios: 1. If the Mahara site is in a subdirectory. For instance, my own test site sits at the URL http://vegas.wgtn.cat-it.co.nz/mahara/, so my pathname is '/mahara/view/view.php' 2. Clean URLs. If a site has Clean URLs turned on, then the URL to a page will be something like "https://mahara.org/user/aaronw/files-for- sharing", in which case the pathname is '/user/aaronw/files-for- sharing'. So relying on the suffix of the URL to determine if we're on the right page to run that JS, is not going to work. What we should probably do instead, is that when the block is being rendered on a page where that link should be Javascriptified, then we should add some inline JS that invokes the connectAnnotationFeedbackLinks() method. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1431668/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
