[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-10-22 Thread Aaron Wells
** Changed in: mahara/15.10 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.o

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-10-22 Thread Aaron Wells
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org for

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-05-28 Thread Robert Lyon
** Changed in: mahara/15.04 Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.o

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-05-04 Thread Jinelle Foley-Barnes
** Tags removed: behat needs-behat -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribi

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-28 Thread Robert Lyon
** Changed in: mahara/15.04 Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.or

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-27 Thread Robert Lyon
** Changed in: mahara/15.10 Status: Confirmed => Fix Committed ** Changed in: mahara/15.04 Status: Confirmed => In Progress -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-22 Thread Aaron Wells
Testing instructions: The easiest way to test this is to inspect the raw HTTP response headers, using the network tab of Firefox's "Web Developer" feature (Tools -> Web Developer -> Network) or Chromium's "Developer Tools" feature (Menu -> More Tools -> Developer Tools, then click the Network tab)

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-22 Thread Aaron Wells
On further research, it looks like directly manipulating the session through SessionHandler isn't going to work. If you're using the default session handler it causes a fatal error. If you're using a custom session handler, like memcached, then it doesn't throw a fatal error, but it doesn't seem to

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-22 Thread Aaron Wells
After discussing this with Robert and some other folks, here are my conclusions: 1. For Mahara 15.10dev, we raise the minimum required PHP version to 5.4. 2. For Mahara 15.04, we keep it at 5.3 (so that we don't strand anyone who upgraded their Mahara to 15.04.0) 3. In 15.04.1, we add the PHP 5.

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-22 Thread Aaron Wells
Having looked through it some more, it looks quite unlikely that PHP is going to fix this bug. They've closed a couple of bug reports about it, saying that you shouldn't open and close the session like this anyway, because it can cause race conditions. Which is true, but based on the kinds of thing

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-22 Thread Aaron Wells
On the third hand, we really shouldn't be changing support versions in a minor release (which 15.04.1 will be), so perhaps for 15.04.1 the hacky header-sniffing fix is the way to go... -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Ma

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-21 Thread Aaron Wells
** Description changed: For the new Ajax progress bar, Bug 1352028, we changed htdocs/auth/session.php so that it closes the PHP session when not in use. This was necessary in order to allow multiple requests to the same session to process simultaneously; PHP by default locks the session

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-21 Thread Aaron Wells
So, after that patch was added, most pages in Mahara only add one or two copies of the session cookie to the header. Admin section pages add at least 5, perhaps because of all the checking to make sure you're an admin. The Mnet landing page adds 102 copies of the session cookie! That's over 7000 c

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-20 Thread Jinelle Foley-Barnes
** Tags added: behat -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https:/

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-20 Thread Jinelle Foley-Barnes
** Tags added: needs-behat -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! h

[Mahara-contributors] [Bug 1446036] Re: Session changes in Mahara 15.04 can cause excessively large response headers

2015-04-19 Thread Aaron Wells
As a workaround, reverting the changes to htdocs/auth/session.php corrects the problem: git checkout 55a8deb8cb~ -- htdocs/auth/session.php This will cause the ajax status bar to not load properly, and it will cause the ajax block loader to load blocks in serial instead of in parallel, but otherw