[Mahara-contributors] [Bug 1705162] Re: Send institution messages for new users in the correct language

2017-10-29 Thread Robert Lyon
** Changed in: mahara Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org for

[Mahara-contributors] [Bug 1705162] Re: Send institution messages for new users in the correct language

2017-09-27 Thread Robert Lyon
** Changed in: mahara Status: Confirmed => Fix Committed ** Changed in: mahara Milestone: None => 17.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contribut

[Mahara-contributors] [Bug 1705162] Re: Send institution messages for new users in the correct language

2017-07-19 Thread Kristina Hoeppner
Thank you for the change, Nelson. We'll take a look. It seems you could connect to Gerrit in the end. :-) How did you solve the problem? I updated your commit message so it will pass Jenkins when it gets to that stage. -- You received this bug notification because you are a member of Mahara Cont

[Mahara-contributors] [Bug 1705162] Re: Send institution messages for new users in the correct language

2017-07-19 Thread Nelson
@Kristina: I've follow the setup for gerrit (I've added my public key there before :)) and I get: {code} 10:55 $ git remote add gerrit ssh://nmol...@reviews.mahara.org:29418/mahara ✔ ~/dev/mahara/dev [master|✔] 10:55 $ git fetch gerrit ssh: connect to host reviews.mahara.org port 29418: Connectio

[Mahara-contributors] [Bug 1705162] Re: Send institution messages for new users in the correct language

2017-07-19 Thread Nelson
I'll propose something like: class ActivityTypeInstitutionmessage extends ActivityType { protected $messagetype; protected $institution; protected $username; protected $fullname; public function __construct($data, $cron=false) { parent::__construct($data, $cron);

[Mahara-contributors] [Bug 1705162] Re: Send institution messages for new users in the correct language

2017-07-19 Thread Nelson
To correctly treat that, you need to do a similar treatment as the one done in https://bugs.launchpad.net/mahara/+bug/1703608 for the methods get_subject and get message in the class ActivityTypeInstitutionmessage (line 1071 lib/activity.php). The institution is available in $this->institution (p

[Mahara-contributors] [Bug 1705162] Re: Send institution messages for new users in the correct language

2017-07-18 Thread Kristina Hoeppner
For 2: Or the site's language. ** Description changed: 1. When a site admin registers a new user, the account information message, i.e. the one that contains the username and password, is sent in the language of the admin but should be sent in the institution's language (as the user doesn