** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org
** Changed in: mahara
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org
** Changed in: mahara
Status: New => In Progress
** Changed in: mahara
Milestone: None => 20.04.0
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors --
Thank you.
Your patch (https://reviews.mahara.org/#/c/10578/3) works fine on my
environment.
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on
Hmm, in simplesamlphp they do this check as:
if (php_sapi_name() === 'cli' || defined('STDIN')) {
...
}
As there are a few places in mahara where we check the CLI we should
make a function to check this.
I'll update the patch to handle these places.
- can you please test
I think it's better to use isset(['REQUEST_METHOD']) instead of
php_sapi_name(), because both web access and cron run returns 'cgi-fcgi'
as PHP mode.
File to modify:
lib/cron.php
Line:
40
[before]
if (php_sapi_name() != 'cli' && get_config('urlsecret') !== null) {
$urlsecret =
** Changed in: mahara
Importance: Undecided => High
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before
7 matches
Mail list logo
