Public bug reported:
Code in get_basic_elements is duplicated in get_advanced_elements
In Mahara, the options are only used in get_advanced_elements. So should
be removed in the basic elements area.
$ownerformatoptions = array(
FORMAT_NAME_FIRSTNAME => sprintf($formatstring,
get_string('firstname'), $USER->get('firstname')),
FORMAT_NAME_LASTNAME => sprintf($formatstring, get_string('lastname'),
$USER->get('lastname')),
FORMAT_NAME_FIRSTNAMELASTNAME => sprintf($formatstring,
get_string('fullname'), full_name())
);
$displayname = display_name($USER);
$studentid = (string)get_field('artefact', 'title', 'owner',
$USER->get('id'), 'artefacttype', 'studentid');
if ($displayname !== '') {
$ownerformatoptions[FORMAT_NAME_DISPLAYNAME] = sprintf($formatstring,
get_string('preferredname'), $displayname);
}
** Affects: mahara
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1907718
Title:
Double up of code that doesn't do anything in editlayout
Status in Mahara:
New
Bug description:
Code in get_basic_elements is duplicated in get_advanced_elements
In Mahara, the options are only used in get_advanced_elements. So
should be removed in the basic elements area.
$ownerformatoptions = array(
FORMAT_NAME_FIRSTNAME => sprintf($formatstring,
get_string('firstname'), $USER->get('firstname')),
FORMAT_NAME_LASTNAME => sprintf($formatstring,
get_string('lastname'), $USER->get('lastname')),
FORMAT_NAME_FIRSTNAMELASTNAME => sprintf($formatstring,
get_string('fullname'), full_name())
);
$displayname = display_name($USER);
$studentid = (string)get_field('artefact', 'title', 'owner',
$USER->get('id'), 'artefacttype', 'studentid');
if ($displayname !== '') {
$ownerformatoptions[FORMAT_NAME_DISPLAYNAME] = sprintf($formatstring,
get_string('preferredname'), $displayname);
}
To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1907718/+subscriptions
_______________________________________________
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help : https://help.launchpad.net/ListHelp
