[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views

2010-09-09 Thread Richard Mansfield
** Changed in: mahara Status: Fix Committed = Fix Released -- newviews blocktype shows grouphomepage views https://bugs.launchpad.net/bugs/619168 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara

[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views

2010-08-24 Thread Richard Mansfield
** Changed in: mahara Status: Opinion = Fix Committed -- newviews blocktype shows grouphomepage views https://bugs.launchpad.net/bugs/619168 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: Fix

[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views

2010-08-17 Thread Andrew Robert Nicols
So we want to remove grouphomepage views from the newviews block type (where they shouldn't be displayed). newviews/lib.php uses View::view_search() However, the grouphomepage views should be visible to group admins on view/groupviews.php for editting etc and view/groupviews.php also uses

[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views

2010-08-17 Thread Andrew Robert Nicols
I've pushed the above fixes. I'll leave this for others to decide whether the newviews blocktype should display grouphomepage views. ** Changed in: mahara Assignee: Andrew Robert Nicols (dobedobedoh) = (unassigned) -- newviews blocktype shows grouphomepage views

[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views

2010-08-17 Thread Richard Mansfield
** Changed in: mahara Status: New = Opinion -- newviews blocktype shows grouphomepage views https://bugs.launchpad.net/bugs/619168 You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Status in Mahara ePortfolio: Opinion Bug

[Mahara-contributors] [Bug 619168] Re: newviews blocktype shows grouphomepage views

2010-08-17 Thread Richard Mansfield
I don't think they should be in the newviews block, but yeah, I agree it's not super high priority because it's only admin's that see them. Maybe we could pass a view type filter to the view_search function. It would make that function even more hairy and indecipherable, but it could be the