** Changed in: mahara
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/702264
Title:
Item order in Site Settings -> Security Settings -> Anti-spam
** Changed in: mahara
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/702264
Title:
Item order in Site Settings -> Security Settings -> Anti-spam
S
** Changed in: mahara
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/702264
Title:
Item order in Site Settings -> Security Settings -> Anti-spam
Statu
** Changed in: mahara
Assignee: (unassigned) => Melissa Draper (melissa)
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/702264
Title:
Item order in Site Settings -> Security Settings ->
** Changed in: mahara
Assignee: Dominik Schmid (dominikschmid93) => (unassigned)
** Changed in: mahara
Status: In Progress => Confirmed
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bug
Hi Dominik,
No, this time the order should be defined as an array somewhere in
antispam.php. The file names and the name of trap that we keep in the database
should remain the same.
** Tags added: antispam bite-sized
--
You received this bug notification because you are a member of Mahara
Con
Hi,
I am currently writing form an internet cafe as I'm on holiday untill the 14th.
I also moved my to a new workstation, so I'd have to re-setup my mahara
(+patch).
Nevertheless, I'd be able to change this, although it would take a bit more
time. =]
Just avoid confusion, the changes that nee
qwert33: will you have time to write the patch that would do what has
been suggested above?
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchpad.net/bugs/702264
Title:
Item order in Site Settings -> Securit
There is no obvious reason to define the weight at the moment, I just
suggest using it for ordering. Defining it inside each fine might make
things slightly complicated. Say, if we will have 8 different traps,
adding one more will require checking the existing ones to find out
which weight to defin
If the intention is to allow site admins to 'drop in' more antispam
files and be able to order them as they like, then the default weights
should leave gaps: maybe number them as 10, 20, 30 rather than 00, 01,
02. I don't think it's very likely that anyone would make use of this
though, so it does
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I would suggest removing the numbering scheme and go for a config file
that has an array of the files to use in the order to use them.
On 28/01/11 23:14, Ruslan Kabalin wrote:
> Would be great if someone else from dev-team could advice on it, using
>
Would be great if someone else from dev-team could advice on it, using
numbers in the file name for weightening the spam methods seems OK to me
(it could be replaced with keeping the weight as constants in the files,
but it will be difficult to maintain). If it is all right I will
implement the pat
Use this patch instead of my previous one.
** Patch added: "Updated filenames on request and edited the loading of them"
https://bugs.launchpad.net/mahara/+bug/702264/+attachment/1799860/+files/0001-lp-702264-Antispam-patch.patch
--
You received this bug notification because you are a member
Hi qwert33, you had to foresee your filename change in new_spam_trap
function as well, it is using the old names.
The idea of using numbers to define the weight is not bad, though I
would eliminate hyphens and would just leave the number, e.g.
00NoneSpamTrap.php
--
You received this bug notific
** Patch added: "Renamed Spamfilters to be in logical order and adjusted the
code to use this."
https://bugs.launchpad.net/mahara/+bug/702264/+attachment/1798716/+files/0001-antispam-lp-702264.patch
--
You received this bug notification because you are a member of Mahara
Contributors, which
** Changed in: mahara
Status: Triaged => Confirmed
** Changed in: mahara
Assignee: (unassigned) => qwert33 (dominikschmid93)
** Changed in: mahara
Status: Confirmed => In Progress
--
You received this bug notification because you are a member of Mahara
Contributors, which is
** Changed in: mahara
Milestone: None => 1.4.0
** Changed in: mahara
Importance: Undecided => Low
** Changed in: mahara
Status: New => Triaged
--
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
https://bugs.launchp
17 matches
Mail list logo
