[Mahara-contributors] [Bug 845948] Re: missing primary keys

2016-03-13 Thread Kristina Hoeppner
** Changed in: mahara Milestone: 16.04.0 => 16.10.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2016-01-04 Thread Robert Lyon
I'll not worry at this stage about the view_visit table as that is only two columns none of which can be null and the data there is automatically cleaned out after 1 week so there is no old data that could cause problems. I'll also not worry about the artefact_log table also as the data saved

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2016-01-04 Thread Robert Lyon
I believe some of the slowness with the view_access table is due to the lack of a primary key as the db system has to work out indexing itself based on a number of rows. I'll add a patch to add a primary 'id' column to the view_access table ** Changed in: mahara Status: Won't Fix => In

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2014-02-24 Thread Aaron Wells
Current Mahara policy is to add a primary key ID column to every new table, but in most cases to not bother adding them to existing tables. ** Changed in: mahara Milestone: 1.9.0 = None ** Changed in: mahara Status: Confirmed = Won't Fix -- You received this bug notification because

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2013-11-20 Thread Aaron Wells
Yep, I believe the practice is called a surrogate key ( http://en.wikipedia.org/wiki/Surrogate_key ). There are arguments for and against them, and certainly previous Mahara devs didn't care for mandatory surrogate keys. But I'm in favor of them. In my experience it's a lot more common to find

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2013-11-19 Thread Robert Lyon
** Changed in: mahara Milestone: None = 1.9.0 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2012-08-14 Thread Kristina Hoeppner
Some recent discussion about a problem that might be related at https://mahara.org/interaction/forum/topic.php?id=4761#post21014 -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/845948 Title:

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2011-11-29 Thread François Marier
blocktype_installed_category is now done on master but these ones would require adding a new id column: - artefact_log - view_access - view_visit because they currently don't have to be unique. ** Changed in: mahara Milestone: 1.5.0 = None ** Changed in: mahara Assignee: Hugh

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2011-11-14 Thread Hugh Davenport
** Changed in: mahara Assignee: (unassigned) = Hugh Davenport (hugh-catalyst) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. https://bugs.launchpad.net/bugs/845948 Title: missing primary keys Status in Mahara

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2011-11-14 Thread Hugh Davenport
Technical points: view_access currently doesn't limit anything at the code level, so the primary key would simply be the entire row. Any thoughts on what to do here? Same with view_visit (though there are only two fields here) Review for the other two at https://reviews.mahara.org/856 **

[Mahara-contributors] [Bug 845948] Re: missing primary keys

2011-09-11 Thread François Marier
** Changed in: mahara Status: New = Triaged ** Changed in: mahara Milestone: None = 1.5.0 ** Changed in: mahara Importance: Undecided = Medium ** Tags added: dbschema -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to