Re : More proposed changes across code

2008-10-19 Thread deneche abdelhakim
> 5. BruteForceTravellingSalesman says "copyright Daniel > Dwyer" -- can > this be replaced by the standard copyright header? Oups, I tought I changed them all ! Yes you can replace it. __ Do You Yahoo!? En finir avec le spam? Yahoo! Mail vous offre

Re: More proposed changes across code

2008-10-19 Thread Ted Dunning
On Sun, Oct 19, 2008 at 5:58 AM, Sean Owen <[EMAIL PROTECTED]> wrote: > 1. serialVersionUID should not be used. +1 > 2. Javadoc that just read (non-javadoc) with a @see tag, or just has > [EMAIL PROTECTED], adds no value and can be removed. +1 I read Grant's comments, but I would rather hav

Re: In case you haven't noticed

2008-10-19 Thread Ted Dunning
On Sun, Oct 19, 2008 at 5:53 AM, Sean Owen <[EMAIL PROTECTED]> wrote: > ... > I am no expert on JIT but I would not imagine the JIT can optimize a > case where an object really is expected, where it's used as a return > value, orf key in a map and so on. Absolutely true. But in these cases, you

Re: [jira] Commented: (MAHOUT-65) Add Element Labels to Vectors and Matrices

2008-10-19 Thread Ted Dunning
I see what you mean. To repeat in other words, the problems that need to be solved are: a) there are many uses already so adding attributes should be transparent to those who don't use them b) the encoding should not be ad hoc because this would be our second ad hoc encoding and only one should

Re: More proposed changes across code

2008-10-19 Thread Grant Ingersoll
On Oct 19, 2008, at 11:16 AM, Sean Owen wrote: On Sun, Oct 19, 2008 at 4:07 PM, Grant Ingersoll <[EMAIL PROTECTED]> wrote: Doesn't the javadoc tool used @inherit to fill in the inherited docs when viewing? Yes... I suppose I find that redundant. The subclass method gets documented exactly

Re: More proposed changes across code

2008-10-19 Thread Sean Owen
On Sun, Oct 19, 2008 at 4:07 PM, Grant Ingersoll <[EMAIL PROTECTED]> wrote: > Doesn't the javadoc tool used @inherit to fill in the inherited docs when > viewing? Yes... I suppose I find that redundant. The subclass method gets documented exactly as the superclass does. It looks like the subclass

Re: More proposed changes across code

2008-10-19 Thread Grant Ingersoll
On Oct 19, 2008, at 8:58 AM, Sean Owen wrote: Since I'm back on this topic, here are some items I'd propose to change. Yeah I know you can say they're small, but they get harder to fix as time goes on. But nevertheless what do you think of... 1. serialVersionUID should not be used. The defaul

Re: [jira] Commented: (MAHOUT-65) Add Element Labels to Vectors and Matrices

2008-10-19 Thread Jeff Eastman
Hi Ted, Sure, consider the following, somewhat simplified implementation. What the various TODOs indicate is the places where encoding/decoding decisions need to be made. Some of these are non-trivial, such as in Attributes where the nameIndex and attributes need to refer to common values. I

More proposed changes across code

2008-10-19 Thread Sean Owen
Since I'm back on this topic, here are some items I'd propose to change. Yeah I know you can say they're small, but they get harder to fix as time goes on. But nevertheless what do you think of... 1. serialVersionUID should not be used. The default serialization mechanism errs on the side of cons

Re: In case you haven't noticed

2008-10-19 Thread Sean Owen
On Sat, Oct 18, 2008 at 2:52 AM, Ted Dunning <[EMAIL PROTECTED]> wrote: > In fact, this won't normally be any slower at all. The reason is that for > really simple samplers, they will get inlined and the boxing will get > optimized away. I am no expert on JIT but I would not imagine the JIT can o