[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840530#action_12840530 ] Sean Owen commented on MAHOUT-320: -- On a related note, as Robin mentioned, this class coul

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Robin Anil (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840553#action_12840553 ] Robin Anil commented on MAHOUT-320: --- This too does binary comparison right. compare by fi

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840560#action_12840560 ] Sean Owen commented on MAHOUT-320: -- Oh what are we referring to by 'binary'? Bigram has s

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Robin Anil (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840564#action_12840564 ] Robin Anil commented on MAHOUT-320: --- This was what intpairwritable does now. This patch h

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840575#action_12840575 ] Sean Owen commented on MAHOUT-320: -- I can see that at the end now. How do you feel about r

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Drew Farris (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840592#action_12840592 ] Drew Farris commented on MAHOUT-320: The big win here is sortability of the binary form

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840593#action_12840593 ] Sean Owen commented on MAHOUT-320: -- Good point. That's what Bigram is doing. Ankur any tho

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Ankur (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840601#action_12840601 ] Ankur commented on MAHOUT-320: -- Binary comparison looks more or less the same in both the clas

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Drew Farris (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840617#action_12840617 ] Drew Farris commented on MAHOUT-320: I certainlly can't argure about the space savings.

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Robin Anil (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840620#action_12840620 ] Robin Anil commented on MAHOUT-320: --- Yeah VInt Does give savings. but the overhead i see

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Ankur (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840619#action_12840619 ] Ankur commented on MAHOUT-320: -- And yes I see the issue with (firstb1 - firstb2) thing in Bigr

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Ankur (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840634#action_12840634 ] Ankur commented on MAHOUT-320: -- I can't apply the patch cleanly. Here is what it says can't f

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Ankur (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840636#action_12840636 ] Ankur commented on MAHOUT-320: -- Robin, Can you update your revision and create a fresh patch ?

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Robin Anil (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840695#action_12840695 ] Robin Anil commented on MAHOUT-320: --- Any issues or does it look good to commit ? > Modif

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Ankur (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841059#action_12841059 ] Ankur commented on MAHOUT-320: -- It still complains that it cannot find the file to patch - co

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-03 Thread Robin Anil (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841065#action_12841065 ] Robin Anil commented on MAHOUT-320: --- I will commit the LDA part with IntWritable, and lea

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-04 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841181#action_12841181 ] Sean Owen commented on MAHOUT-320: -- After the fact here, but I'm going to fix a number of

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-04 Thread Sean Owen (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841187#action_12841187 ] Sean Owen commented on MAHOUT-320: -- While I'm here, what's the point in the "^ 0x80" expre

[jira] Commented: (MAHOUT-320) Modify IntPairWritable in LDA implementation to be binary comparable to improve performance.

2010-03-04 Thread Drew Farris (JIRA)
[ https://issues.apache.org/jira/browse/MAHOUT-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12841220#action_12841220 ] Drew Farris commented on MAHOUT-320: I haven't reviewed the round of patches, when I wr