Re: [Mailman-Developers] Click CLI branch

2017-07-21 Thread Mark Sapiro
On 07/21/2017 08:03 PM, Barry Warsaw wrote: > On Jul 20, 2017, at 03:56 PM, Barry Warsaw wrote: > >> This will close #319 and #346 and make adding new `mailman` subcommands much >> easier. > > This is now merged! And MRs !202 and !301 have been rebased and CI is running. -- Mark Sapiro

Re: [Mailman-Developers] Click CLI branch

2017-07-21 Thread Barry Warsaw
On Jul 20, 2017, at 03:56 PM, Barry Warsaw wrote: >This will close #319 and #346 and make adding new `mailman` subcommands much >easier. This is now merged! -Barry pgpSeSITuYKLP.pgp Description: OpenPGP digital signature ___ Mailman-Developers mailing

Re: [Mailman-Developers] Click CLI branch

2017-07-21 Thread Barry Warsaw
On Jul 21, 2017, at 11:46, Mark Sapiro wrote: > > Another thing I noticed is the help for the withlist --run option says > in part: > > If additional arguments are given at the end of the command line, they > are passed as subsequent positional arguments to the callable. For > additional help,

Re: [Mailman-Developers] Click CLI branch

2017-07-21 Thread Mark Sapiro
Another thing I noticed is the help for the withlist --run option says in part: If additional arguments are given at the end of the command line, they are passed as subsequent positional arguments to the callable. For additional help, see --details. The additional arguments are not actually pass

Re: [Mailman-Developers] Click CLI branch

2017-07-21 Thread Barry Warsaw
On Jul 20, 2017, at 05:22 PM, Mark Sapiro wrote: >On 07/20/2017 03:11 PM, Mark Sapiro wrote: > >One more thing. '-h' doesn't invoke help. See > >for how to enable this. Thanks, fixed! -Barry pgpD88ZMYVUjJ.pgp Description: Ope

Re: [Mailman-Developers] Click CLI branch

2017-07-21 Thread Barry Warsaw
On Jul 20, 2017, at 02:26 PM, Mark Sapiro wrote: >The first thing I notice right away is the help text doesn't fill. E.g., Now that you remind me, I noticed this too and I was going to file an upstream issue on this, but I forgot. I did some pdb tracing through the click source and figured out t

Re: [Mailman-Developers] Click CLI branch

2017-07-20 Thread Barry Warsaw
On Jul 20, 2017, at 02:12 PM, Mark Sapiro wrote: >I'll look at it. I'll also rebase !301 and !202 after it lands, and I'll >now delete my branch >as this supercedes that. Thanks Mark! -Barry pgpighh58zCwB.pgp Description: OpenPGP digital signat

Re: [Mailman-Developers] Click CLI branch

2017-07-20 Thread Barry Warsaw
On Jul 20, 2017, at 11:33 PM, Jan Jancar wrote: >Looking at the dynamic loading of subcommands, plugin subcommands can be >easily integrated. Pretty much a one line change on top of this and !288: > > - add_components('mailman.commands', ICLISubCommand, self._commands) > + add_pluggable_compon

Re: [Mailman-Developers] Click CLI branch

2017-07-20 Thread Mark Sapiro
On 07/20/2017 03:11 PM, Mark Sapiro wrote: One more thing. '-h' doesn't invoke help. See for how to enable this. -- Mark Sapiro The highway is for gamblers, San Francisco Bay Area, Californiabetter use your sense

Re: [Mailman-Developers] Click CLI branch

2017-07-20 Thread Mark Sapiro
On 07/20/2017 02:26 PM, Mark Sapiro wrote: > > The first thing I notice right away is the help text doesn't fill. E.g., > >> $ ./mailman --help >> Usage: mailman [OPTIONS] COMMAND [ARGS]... >> >> The GNU Mailman mailing list management system Copyright 1998-2017 by the >> Free Software Founda

Re: [Mailman-Developers] Click CLI branch

2017-07-20 Thread Jan Jancar
On 07/20/2017 10:56 PM, Barry Warsaw wrote: > Just a quick note to mention that my big branch to adopt click for command > line option parsing should now be done. > > https://gitlab.com/mailman/mailman/merge_requests/292 > > This will close #319 and #346 and make adding new `mailman` subcommands

Re: [Mailman-Developers] Click CLI branch

2017-07-20 Thread Mark Sapiro
On 07/20/2017 02:12 PM, Mark Sapiro wrote: > On 07/20/2017 01:56 PM, Barry Warsaw wrote: >> Just a quick note to mention that my big branch to adopt click for command >> line option parsing should now be done. >> >> https://gitlab.com/mailman/mailman/merge_requests/292 > > I'll look at it. ...

Re: [Mailman-Developers] Click CLI branch

2017-07-20 Thread Mark Sapiro
On 07/20/2017 01:56 PM, Barry Warsaw wrote: > Just a quick note to mention that my big branch to adopt click for command > line option parsing should now be done. > > https://gitlab.com/mailman/mailman/merge_requests/292 ... > Please feel free to review it and play with it. It’s finishing CI now

[Mailman-Developers] Click CLI branch

2017-07-20 Thread Barry Warsaw
Just a quick note to mention that my big branch to adopt click for command line option parsing should now be done. https://gitlab.com/mailman/mailman/merge_requests/292 This will close #319 and #346 and make adding new `mailman` subcommands much easier. (We still need the bits to define additi