Re: [Mailman-Developers] Postorius test debugging problem : tests_forms.py

2015-02-27 Thread Abhilash Raj
On 28 February 2015 at 10:07, Pranjal Yadav godricg...@gmail.com wrote: Abhilash, Thanks! it worked as you said. But renaming clean method is not conventional. I changed the names and it looks like 'clean_password_repeat' is good and that is the last input for that test as well, so I don't

Re: [Mailman-Developers] Postorius test debugging problem : tests_forms.py

2015-02-27 Thread Abhilash Raj
On 27 February 2015 at 20:39, Pranjal Yadav godricg...@gmail.com wrote: Hi Abhilash, Thanks for your help. I read that we need to define methods as clean_fieldname however I missed I was cleaning multiple fields. For the listname method it works the way you told me but I tried something

Re: [Mailman-Developers] Postorius test debugging problem : tests_forms.py

2015-02-27 Thread Pranjal Yadav
Abhilash, renaming 'clean_password' to 'clean' did help in running all the tests successfully but looking at the coverage stats I realized the 'invalid_email' test is still not functional since those lines are shown as 'missing' in stats, So it was just a work around and it didn't actually help.

Re: [Mailman-Developers] Postorius test debugging problem : tests_forms.py

2015-02-27 Thread Pranjal Yadav
Hi Abhilash, Thanks for your help. I read that we need to define methods as clean_fieldname however I missed I was cleaning multiple fields. For the listname method it works the way you told me but I tried something similar ( http://pastebin.com/p40A19hU ) and it didn't work. If you could tell me

Re: [Mailman-Developers] Postorius test debugging problem : tests_forms.py

2015-02-27 Thread Abhilash Raj
Hi Pranjal, I was able to run the tests in ListNewTest, and kind of debug the other test too. In ListNewTest you have two tests doing the same thing, probably you intended at doing something else, but there is nothing in there right now. there is a method of django forms called as `errors`. So

[Mailman-Developers] Postorius test debugging problem : tests_forms.py

2015-02-19 Thread Pranjal Yadav
I started writing tests to improve the coverage for postorius and I ran into few problems which I couldn't solve for past few days. I added few new test cases and re-ran tox. It seems somehow none of the tests ran although the tox output says ran 11 tests in 72.332s, failures = 3 Here is the link