Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Da Zhou
sounds good! +1 Regards, Da > On Jul 17, 2019, at 7:32 PM, Dinesh Chitlangia > wrote: > > +1, this is certainly useful. > > Thank you, > Dinesh > > > > >> On Wed, Jul 17, 2019 at 10:04 PM Akira Ajisaka wrote: >> >> Makes sense, +1 >> >>> On Thu, Jul 18, 2019 at 10:01 AM Sangjin Lee

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Dinesh Chitlangia
+1, this is certainly useful. Thank you, Dinesh On Wed, Jul 17, 2019 at 10:04 PM Akira Ajisaka wrote: > Makes sense, +1 > > On Thu, Jul 18, 2019 at 10:01 AM Sangjin Lee wrote: > > > > +1. Sounds good to me. > > > > On Wed, Jul 17, 2019 at 10:20 AM Iñigo Goiri wrote: > > > > > +1 > > > > >

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Akira Ajisaka
Makes sense, +1 On Thu, Jul 18, 2019 at 10:01 AM Sangjin Lee wrote: > > +1. Sounds good to me. > > On Wed, Jul 17, 2019 at 10:20 AM Iñigo Goiri wrote: > > > +1 > > > > On Wed, Jul 17, 2019 at 4:17 AM Steve Loughran > > > > wrote: > > > > > +1 for squash and merge, with whoever does the merge

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Sangjin Lee
+1. Sounds good to me. On Wed, Jul 17, 2019 at 10:20 AM Iñigo Goiri wrote: > +1 > > On Wed, Jul 17, 2019 at 4:17 AM Steve Loughran > > wrote: > > > +1 for squash and merge, with whoever does the merge adding the full > commit > > message for the logs, with JIRA, contributor(s) etc > > > > One

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Iñigo Goiri
+1 On Wed, Jul 17, 2019 at 4:17 AM Steve Loughran wrote: > +1 for squash and merge, with whoever does the merge adding the full commit > message for the logs, with JIRA, contributor(s) etc > > One limit of the github process is that the author of the commit becomes > whoever hit the squash

Apache Hadoop qbt Report: trunk+JDK8 on Linux/x86

2019-07-17 Thread Apache Jenkins Server
For more details, see https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/1200/ [Jul 16, 2019 2:44:27 AM] (ayushsaxena) HDFS-14642. processMisReplicatedBlocks does not return correct processed [Jul 16, 2019 4:51:59 AM] (github) HDDS-1736. Cleanup 2phase old HA code for Key requests.

[jira] [Created] (MAPREDUCE-7225) Fix broken current folder expansion during MR job start

2019-07-17 Thread Adam Antal (JIRA)
Adam Antal created MAPREDUCE-7225: - Summary: Fix broken current folder expansion during MR job start Key: MAPREDUCE-7225 URL: https://issues.apache.org/jira/browse/MAPREDUCE-7225 Project: Hadoop

Apache Hadoop qbt Report: branch2+JDK7 on Linux/x86

2019-07-17 Thread Apache Jenkins Server
For more details, see https://builds.apache.org/job/hadoop-qbt-branch2-java7-linux-x86/385/ [Jul 16, 2019 2:22:45 PM] (xkrogen) HDFS-14547. Improve memory efficiency of quotas when storage type quotas [Jul 16, 2019 10:50:24 PM] (iwasakims) HADOOP-16386. FindBugs warning in branch-2:

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Steve Loughran
+1 for squash and merge, with whoever does the merge adding the full commit message for the logs, with JIRA, contributor(s) etc One limit of the github process is that the author of the commit becomes whoever hit the squash button, not whoever did the code, so it loses the credit they are due.

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Gabor Bota
+1 Good idea. On Wed, Jul 17, 2019 at 9:37 AM Ayush Saxena wrote: > Thanks Marton, Makes Sense +1 > > > On 17-Jul-2019, at 11:37 AM, Elek, Marton wrote: > > > > Hi, > > > > Github UI (ui!) helps to merge Pull Requests to the proposed branch. > > There are three different ways to do it [1]: > >

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Ayush Saxena
Thanks Marton, Makes Sense +1 > On 17-Jul-2019, at 11:37 AM, Elek, Marton wrote: > > Hi, > > Github UI (ui!) helps to merge Pull Requests to the proposed branch. > There are three different ways to do it [1]: > > 1. Keep all the different commits from the PR branch and create one > additional

Re: Re: Any thoughts making Submarine a separate Apache project?

2019-07-17 Thread dashuiguailu...@gmail.com
+1 ,Good idea, we are very much looking forward to it. dashuiguailu...@gmail.com From: Szilard Nemeth Date: 2019-07-17 14:55 To: runlin zhang CC: Xun Liu; Hadoop Common; yarn-dev; Hdfs-dev; mapreduce-dev; submarine-dev Subject: Re: Any thoughts making Submarine a separate Apache project? +1,

Re: Any thoughts making Submarine a separate Apache project?

2019-07-17 Thread Szilard Nemeth
+1, this is a very great idea. As Hadoop repository has already grown huge and contains many projects, I think in general it's a good idea to separate projects in the early phase. On Wed, Jul 17, 2019, 08:50 runlin zhang wrote: > +1 ,That will be great ! > > > 在 2019年7月10日,下午3:34,Xun Liu 写道:

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Vinod Kumar Vavilapalli
Makes sense, +1. Thanks +Vinod > On Jul 17, 2019, at 11:37 AM, Elek, Marton wrote: > > Hi, > > Github UI (ui!) helps to merge Pull Requests to the proposed branch. > There are three different ways to do it [1]: > > 1. Keep all the different commits from the PR branch and create one >

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Mukul Kumar Singh
+1, Lets have Squash and merge as the default & only option on github UI. Thanks, Mukul On 7/17/19 11:37 AM, Elek, Marton wrote: Hi, Github UI (ui!) helps to merge Pull Requests to the proposed branch. There are three different ways to do it [1]: 1. Keep all the different commits from the

Re: [VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Weiwei Yang
Thanks Marton, +1 on this. Weiwei On Jul 17, 2019, 2:07 PM +0800, Elek, Marton , wrote: > Hi, > > Github UI (ui!) helps to merge Pull Requests to the proposed branch. > There are three different ways to do it [1]: > > 1. Keep all the different commits from the PR branch and create one >

[VOTE] Force "squash and merge" option for PR merge on github UI

2019-07-17 Thread Elek, Marton
Hi, Github UI (ui!) helps to merge Pull Requests to the proposed branch. There are three different ways to do it [1]: 1. Keep all the different commits from the PR branch and create one additional merge commit ("Create a merge commit") 2. Squash all the commits and commit the change as one